Skip to content

Add FEAT_CMH support#430

Open
ricbal02 wants to merge 3 commits into
ARM-software:mainfrom
ricbal02:FEAT_CMH
Open

Add FEAT_CMH support#430
ricbal02 wants to merge 3 commits into
ARM-software:mainfrom
ricbal02:FEAT_CMH

Conversation

@ricbal02
Copy link
Copy Markdown
Contributor


Hi all,

This is a PR to propose the addition of new intrinsics required as part of FEAT_CMH.

Quality Level: ALP


Thank you for submitting a pull request!

If this PR is about a bugfix:

Please use the bugfix label and make sure to go through the checklist below.

If this PR is about a proposal:

We are looking forward to evaluate your proposal, and if possible to
make it part of the Arm C Language Extension (ACLE) specifications.

We would like to encourage you reading through the contribution
guidelines
, in particular the section on submitting
a proposal
.

Please use the proposal label.

As for any pull request, please make sure to go through the below
checklist.

Checklist: (mark with X those which apply)

  • If an issue reporting the bug exists, I have mentioned it in the
    PR (do not bother creating the issue if all you want to do is
    fixing the bug yourself).
  • I have added/updated the SPDX-FileCopyrightText lines on top
    of any file I have edited. Format is SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}>
    (Please update existing copyright lines if applicable. You can
    specify year ranges with hyphen , as in 2017-2019, and use
    commas to separate gaps, as in 2018-2020, 2022).
  • I have updated the Copyright section of the sources of the
    specification I have edited (this will show up in the text
    rendered in the PDF and other output format supported). The
    format is the same described in the previous item.
  • I have run the CI scripts (if applicable, as they might be
    tricky to set up on non-*nix machines). The sequence can be
    found in the contribution
    guidelines
    . Don't
    worry if you cannot run these scripts on your machine, your
    patch will be automatically checked in the Actions of the pull
    request.
  • I have added an item that describes the changes I have
    introduced in this PR in the section Changes for next
    release
    of the section Change Control/Document history
    of the document. Create Changes for next release if it does
    not exist. Notice that changes that are not modifying the
    content and rendering of the specifications (both HTML and PDF)
    do not need to be listed.
  • When modifying content and/or its rendering, I have checked the
    correctness of the result in the PDF output (please refer to the
    instructions on how to build the PDFs
    locally
    ).
  • The variable draftversion is set to true in the YAML header
    of the sources of the specifications I have modified.
  • Please DO NOT add my GitHub profile to the list of contributors
    in the README page of the project.

@CarolineConcatto CarolineConcatto self-requested a review March 25, 2026 16:20
Comment thread main/acle.md Outdated
Comment thread main/acle.md Outdated
Comment thread main/acle.md Outdated
Comment thread main/acle.md Outdated
Comment thread main/acle.md Outdated
Comment thread main/acle.md
Comment thread main/acle.md Outdated
Comment thread main/acle.md Outdated
ricbal02 and others added 2 commits May 7, 2026 16:16
Following changes to PCDPHINT update ACLE description
Comment thread main/acle.md
These intrinsics provide some atomic fetch operations, which will
make use of hint instructions immediately followed by the
associated fetch instructions. These intrinsics are type generic and
supports scalar integral and floating-point types of 8, 16, 32, and 64 bits.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

floating point??? Let's stick to scalar integer only. I don't believe there is any use of FP variants anyway.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea was to be consistent with the store intrinsic. Or is there a reason to have different type support between the 2 ?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it can't be done on compare&exchange loops, you'd have to check that for all architectures where CMH is allowed that FP atomics are a must-have and not optional. It's complex.

Comment thread main/acle.md
These intrinsics provide some atomic fetch operations, which will
make use of hint instructions immediately followed by the
associated fetch instructions. These intrinsics are type generic and
supports scalar integral and floating-point types of 8, 16, 32, and 64 bits.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supports -> support

Comment thread main/acle.md
type __arm_atomic_fetch_or_with_hint(type *ptr, type data, int memory_order, int hint);
```

The first argument in these intrinsic is a pointer `ptr` which is the location to store to.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"store" is not accurate here, it does a RMW.

Comment thread main/acle.md
```

The first argument in these intrinsic is a pointer `ptr` which is the location to store to.
The second argument `data` is the data which is to be stored.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here "to be stored"

Copy link
Copy Markdown

@Wilco1 Wilco1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants