fontsrv: improve rendering of slanted fonts (italics) on X11#767
Open
yrk-lab wants to merge 1 commit into9fans:masterfrom
Open
fontsrv: improve rendering of slanted fonts (italics) on X11#767yrk-lab wants to merge 1 commit into9fans:masterfrom
yrk-lab wants to merge 1 commit into9fans:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves renderings of Italic fonts, e.g. URWBookman-DemiItalic.
Improve renderings of Italic fonts, e.g. the Go font.
Before and after, as presented with tweak(1):
As before, the nature of the fix is to include the actual rendering width into the character size math, while retaining the original logic of tracking the position advancements: note the larger iwidth values, with the width and left values used for the tracking.
This does not yet address the remaining visual artefacts produced by the programs which make certain assumptions in frselect and the direct uses of frdrawsel of libframe in acme, sam and other clients; the assumptions being that the adjacent characters never overlap. Being much, much trickier to address, those fall outside of the scope of the proposed fix.
In #766 a similar fix was made to the macOS version of the program, and yrk-lab/fontsrv#4 is equivalent to the proposed fix.
Fixes #765 for X11 systems (Linux).
Tested on Raspbian (Debian) Trixie.