fix: consider FocusIn when X11 devdraw repaints; remove a delaying check#747
Open
markvanatten wants to merge 1 commit into9fans:masterfrom
Open
fix: consider FocusIn when X11 devdraw repaints; remove a delaying check#747markvanatten wants to merge 1 commit into9fans:masterfrom
markvanatten wants to merge 1 commit into9fans:masterfrom
Conversation
Contributor
Author
|
This fix was partially generated by an LLM. |
dancrossnyc
reviewed
Apr 1, 2026
| break; | ||
| case FocusIn: | ||
| case Expose: /* Handle standard Expose here too for consistency */ | ||
| /* * Force a copy from backing store (screenpm) to the window. |
Collaborator
There was a problem hiding this comment.
The formatting is kind of strange; it looks like a newline (and indentation) following the opening /* was swallowed?
dancrossnyc
reviewed
Apr 1, 2026
| XCopyArea(_x.display, w->screenpm, w->drawable, _x.gccopy, | ||
| 0, 0, Dx(w->screenr), Dy(w->screenr), 0, 0); | ||
| } | ||
| /* * If this was a real Expose event, we still let standard handling |
dancrossnyc
reviewed
Apr 1, 2026
| case FocusIn: | ||
| case Expose: /* Handle standard Expose here too for consistency */ | ||
| /* * Force a copy from backing store (screenpm) to the window. | ||
| * We removed the (screenpm == nextscreenpm) check because |
Collaborator
There was a problem hiding this comment.
I'd remove this. LLMs like to tell you what they removed; usually it's superfluous, or belongs in the commit message, not in a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves on commit b3741e6, by repainting also when FocusIn occurs, and also by now drawing the current image once again in case devdraw happens to be busy working on the next. The problems with blank windows these improvements solve became apparent under use of one or more instances of the X server intensive winwatch, for example one per virtual desktop. (Only one instance would need to run if a rio window could be made to stick.)