Provide follow option to 9p#709
Open
rakoo wants to merge 2 commits into9fans:masterfrom
Open
Conversation
dancrossnyc
reviewed
Jul 27, 2025
| } | ||
|
|
||
| void | ||
| checkout() |
Collaborator
There was a problem hiding this comment.
It is not immediately clear to me how this is relevant to the change at hand?
dancrossnyc
reviewed
Jul 27, 2025
| if(write(1, buf, n) < 0) | ||
| sysfatal("write error: %r"); | ||
| if (n == 0 && follow) | ||
| sleep(1000); |
Collaborator
There was a problem hiding this comment.
I'd probably lower this limit substantially. Even better would be somehow poll on this; at first that's what I thought checkout was going to do, but it doesn't.
Contributor
|
I'd suggest to have a separate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is like
tail -fbut for9p readRequires #708