Fix testing errors

Fix errors in testing introduced by PR: DSpace#5106 by replacing Store mocking with mocking of the SiteService.

Author: Dawnkai

src/app/footer/footer.component.spec.ts

@@ -10,6 +10,7 @@ import { ActivatedRoute } from '@angular/router';
 import { APP_CONFIG } from '@dspace/config/app-config.interface';
 import { NotifyInfoService } from '@dspace/core/coar-notify/notify-info/notify-info.service';
 import { AuthorizationDataService } from '@dspace/core/data/feature-authorization/authorization-data.service';
+import { SiteDataService } from '@dspace/core/data/site-data.service';
 import { APP_DATA_SERVICES_MAP } from '@dspace/core/data-services-map-type';
 import { LocaleService } from '@dspace/core/locale/locale.service';
 import { ResourceType } from '@dspace/core/shared/resource-type';
@@ -25,13 +26,28 @@ import { FooterComponent } from './footer.component';
 let comp: FooterComponent;
 let fixture: ComponentFixture<FooterComponent>;
 let localeService: any;
+let mockSiteDataService: any;
 
 const TEST_MODEL = new ResourceType('testmodel');
 const languageList = ['en;q=1', 'de;q=0.8'];
 const mockLocaleService = jasmine.createSpyObj('LocaleService', {
   getCurrentLanguageCode: jasmine.createSpy('getCurrentLanguageCode'),
   getLanguageCodeList: of(languageList),
 });
+const mockSite = {
+  firstMetadataValue: (key: string, options: any) => 'Sample Footer CMS Content',
+};
+const initialState = {
+  core: {
+    auth: {
+      authenticated: false,
+      loaded: false,
+      blocking: undefined,
+      loading: false,
+      authMethods: [],
+    },
+  },
+};
 
 let notifyInfoService = {
   isCoarConfigEnabled: () => of(true),
@@ -43,22 +59,21 @@ const mockDataServiceMap: any = new Map([
 
 describe('Footer component', () => {
   beforeEach(waitForAsync(() => {
+    mockSiteDataService = jasmine.createSpyObj('SiteDataService', ['find']);
+    mockSiteDataService.find.and.returnValue(of(mockSite));
+
     return TestBed.configureTestingModule({
       imports: [
         TranslateModule.forRoot(),
       ],
       providers: [
         FooterComponent,
-        provideMockStore({
-          initialState: {
-            index: {
-            },
-          },
-        }),
+        provideMockStore({ initialState }),
         { provide: LocaleService, useValue: mockLocaleService },
         { provide: AuthorizationDataService, useClass: AuthorizationDataServiceStub },
         { provide: NotifyInfoService, useValue: notifyInfoService },
         { provide: ActivatedRoute, useValue: new ActivatedRouteStub() },
+        { provide: SiteDataService, useValue: mockSiteDataService },
         { provide: APP_CONFIG, useValue: environment },
         { provide: APP_DATA_SERVICES_MAP, useValue: mockDataServiceMap },
       ],

src/app/info/end-user-agreement/end-user-agreement-content/end-user-agreement-content.component.spec.ts

@@ -16,38 +16,45 @@ import { of } from 'rxjs';
 import { environment } from '../../../../environments/environment.test';
 import { EndUserAgreementContentComponent } from './end-user-agreement-content.component';
 
-let localeService: any;
-
 const TEST_MODEL = new ResourceType('testmodel');
-
-const mockDataServiceMap: any = new Map([
+const LANGUAGE_LIST = ['en;q=1', 'de;q=0.8'];
+const MOCK_DATA_MAP = new Map([
   [TEST_MODEL.value, () => import('../../../core/testing/test-data-service.mock').then(m => m.TestDataService)],
 ]);
+const INITIAL_STATE = {
+  core: {
+    auth: {
+      authenticated: false,
+      loaded: false,
+      blocking: undefined,
+      loading: false,
+      authMethods: [],
+    },
+  },
+};
 
-const languageList = ['en;q=1', 'de;q=0.8'];
-const mockLocaleService = jasmine.createSpyObj('LocaleService', {
-  getCurrentLanguageCode: jasmine.createSpy('getCurrentLanguageCode'),
-  getLanguageCodeList: of(languageList),
-});
 
 describe('EndUserAgreementContentComponent', () => {
   let component: EndUserAgreementContentComponent;
   let fixture: ComponentFixture<EndUserAgreementContentComponent>;
+  let localeServiceSpy: jasmine.SpyObj<LocaleService>;
 
   beforeEach(waitForAsync(() => {
+    localeServiceSpy = jasmine.createSpyObj('LocaleService', [
+      'getCurrentLanguageCode',
+      'getLanguageCodeList',
+    ]);
+
     TestBed.configureTestingModule({
-      imports: [TranslateModule.forRoot(), EndUserAgreementContentComponent],
-      providers: [
+      imports: [
+        TranslateModule.forRoot(),
         EndUserAgreementContentComponent,
-        provideMockStore({
-          initialState: {
-            index: {
-            },
-          },
-        }),
-        { provide: APP_DATA_SERVICES_MAP, useValue: mockDataServiceMap },
+      ],
+      providers: [
+        provideMockStore({ initialState: INITIAL_STATE }),
+        { provide: APP_DATA_SERVICES_MAP, useValue: MOCK_DATA_MAP },
         { provide: APP_CONFIG, useValue: environment },
-        { provide: LocaleService, useValue: mockLocaleService },
+        { provide: LocaleService, useValue: localeServiceSpy },
       ],
       schemas: [NO_ERRORS_SCHEMA],
     })
@@ -61,9 +68,9 @@ describe('EndUserAgreementContentComponent', () => {
 
   beforeEach(() => {
     fixture = TestBed.createComponent(EndUserAgreementContentComponent);
-    localeService = TestBed.inject(LocaleService);
-    localeService.getCurrentLanguageCode.and.returnValue(of('en'));
     component = fixture.componentInstance;
+    localeServiceSpy.getCurrentLanguageCode.and.returnValue(of('en'));
+    localeServiceSpy.getLanguageCodeList.and.returnValue(of(LANGUAGE_LIST));
     fixture.detectChanges();
   });