Fix lint errors

Author: Dawnkai

src/app/admin/admin-edit-cms-metadata/admin-edit-cms-metadata.component.spec.ts

@@ -6,6 +6,9 @@ import {
 } from '@angular/core/testing';
 import { FormsModule } from '@angular/forms';
 import { By } from '@angular/platform-browser';
+import { NotificationsService } from '@dspace/core/notification-system/notifications.service';
+import { NotificationsServiceStub } from '@dspace/core/testing/notifications-service.stub';
+import { TranslateLoaderMock } from '@dspace/core/testing/translate-loader.mock';
 import {
   TranslateLoader,
   TranslateModule,
@@ -16,9 +19,6 @@ import { environment } from '../../../environments/environment.test';
 import { SiteDataService } from '../../core/data/site-data.service';
 import { Site } from '../../core/shared/site.model';
 import { AdminEditCmsMetadataComponent } from './admin-edit-cms-metadata.component';
-import { TranslateLoaderMock } from '@dspace/core/testing/translate-loader.mock';
-import { NotificationsServiceStub } from '@dspace/core/testing/notifications-service.stub';
-import { NotificationsService } from '@dspace/core/notification-system/notifications.service';
 
 describe('AdminEditCmsMetadataComponent', () => {
 

src/app/admin/admin-edit-cms-metadata/admin-edit-cms-metadata.component.ts

@@ -1,14 +1,13 @@
 import {
   AsyncPipe,
-  NgForOf,
-  NgIf,
   NgTemplateOutlet,
 } from '@angular/common';
 import {
   Component,
   OnInit,
 } from '@angular/core';
 import { FormsModule } from '@angular/forms';
+import { NotificationsService } from '@dspace/core/notification-system/notifications.service';
 import {
   TranslateModule,
   TranslateService,
@@ -21,7 +20,6 @@ import { environment } from '../../../environments/environment';
 import { SiteDataService } from '../../core/data/site-data.service';
 import { getFirstCompletedRemoteData } from '../../core/shared/operators';
 import { Site } from '../../core/shared/site.model';
-import { NotificationsService } from '@dspace/core/notification-system/notifications.service';
 
 /**
  * Component representing the page to edit cms metadata for site.
@@ -31,13 +29,12 @@ import { NotificationsService } from '@dspace/core/notification-system/notificat
   templateUrl: './admin-edit-cms-metadata.component.html',
   styleUrls: ['./admin-edit-cms-metadata.component.scss'],
   imports: [
-    FormsModule,
-    TranslateModule,
     AsyncPipe,
-    NgTemplateOutlet,
     BtnDisabledDirective,
+    FormsModule,
+    NgTemplateOutlet,
+    TranslateModule,
   ],
-  standalone: true,
 })
 export class AdminEditCmsMetadataComponent implements OnInit {
   /**

src/app/admin/admin-edit-user-agreement/admin-edit-user-agreement.component.spec.ts

@@ -1,18 +1,24 @@
 import { CommonModule } from '@angular/common';
 import { NO_ERRORS_SCHEMA } from '@angular/core';
 import {
-  waitForAsync,
   ComponentFixture,
   inject,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import {
   FormsModule,
   ReactiveFormsModule,
 } from '@angular/forms';
 import { BrowserModule } from '@angular/platform-browser';
 import { RouterTestingModule } from '@angular/router/testing';
+import { APP_DATA_SERVICES_MAP } from '@dspace/core/data-services-map-type';
+import { NotificationsService } from '@dspace/core/notification-system/notifications.service';
+import { ResourceType } from '@dspace/core/shared/resource-type';
+import { NotificationsServiceStub } from '@dspace/core/testing/notifications-service.stub';
+import { TranslateLoaderMock } from '@dspace/core/testing/translate-loader.mock';
 import { NgbModule } from '@ng-bootstrap/ng-bootstrap';
+import { provideMockStore } from '@ngrx/store/testing';
 import {
   TranslateLoader,
   TranslateModule,
@@ -27,12 +33,6 @@ import { SiteDataService } from '../../core/data/site-data.service';
 import { Site } from '../../core/shared/site.model';
 import { AlertComponent } from '../../shared/alert/alert.component';
 import { AdminEditUserAgreementComponent } from './admin-edit-user-agreement.component';
-import { NotificationsServiceStub } from '@dspace/core/testing/notifications-service.stub';
-import { TranslateLoaderMock } from '@dspace/core/testing/translate-loader.mock';
-import { NotificationsService } from '@dspace/core/notification-system/notifications.service';
-import { provideMockStore } from '@ngrx/store/testing';
-import { APP_DATA_SERVICES_MAP } from '@dspace/core/data-services-map-type';
-import { ResourceType } from '@dspace/core/shared/resource-type';
 
 const TEST_MODEL = new ResourceType('testmodel');
 
@@ -84,8 +84,8 @@ describe('AdminEditUserAgreementComponent', () => {
         provideMockStore({
           initialState: {
             index: {
-            }
-          }
+            },
+          },
         }),
         { provide: APP_DATA_SERVICES_MAP, useValue: mockDataServiceMap },
         { provide: NotificationsService, useValue: notificationService },

src/app/admin/admin-edit-user-agreement/admin-edit-user-agreement.component.ts

@@ -1,13 +1,11 @@
-import {
-  KeyValuePipe,
-  NgForOf,
-} from '@angular/common';
+import { KeyValuePipe } from '@angular/common';
 import {
   Component,
   OnDestroy,
   OnInit,
 } from '@angular/core';
 import { FormsModule } from '@angular/forms';
+import { NotificationsService } from '@dspace/core/notification-system/notifications.service';
 import { NgbModal } from '@ng-bootstrap/ng-bootstrap';
 import {
   TranslateModule,
@@ -22,7 +20,6 @@ import { SiteDataService } from '../../core/data/site-data.service';
 import { getFirstCompletedRemoteData } from '../../core/shared/operators';
 import { Site } from '../../core/shared/site.model';
 import { AlertComponent } from '../../shared/alert/alert.component';
-import { NotificationsService } from '@dspace/core/notification-system/notifications.service';
 
 /**
  * Component that represents the user agreement edit page for administrators.
@@ -32,11 +29,10 @@ import { NotificationsService } from '@dspace/core/notification-system/notificat
   templateUrl: './admin-edit-user-agreement.component.html',
   imports: [
     AlertComponent,
-    TranslateModule,
-    KeyValuePipe,
     FormsModule,
+    KeyValuePipe,
+    TranslateModule,
   ],
-  standalone: true,
 })
 export class AdminEditUserAgreementComponent implements OnInit, OnDestroy {
 

src/app/admin/admin-routes.ts

@@ -2,6 +2,8 @@ import { Route } from '@angular/router';
 import { i18nBreadcrumbResolver } from '@dspace/core/breadcrumbs/i18n-breadcrumb.resolver';
 
 import { AdminCurationTasksComponent } from './admin-curation-tasks/admin-curation-tasks.component';
+import { AdminEditCmsMetadataComponent } from './admin-edit-cms-metadata/admin-edit-cms-metadata.component';
+import { AdminEditUserAgreementComponent } from './admin-edit-user-agreement/admin-edit-user-agreement.component';
 import { BatchImportPageComponent } from './admin-import-batch-page/batch-import-page.component';
 import { ThemedMetadataImportPageComponent } from './admin-import-metadata-page/themed-metadata-import-page.component';
 import {
@@ -13,8 +15,6 @@ import {
 } from './admin-routing-paths';
 import { ThemedAdminSearchPageComponent } from './admin-search-page/themed-admin-search-page.component';
 import { ThemedAdminWorkflowPageComponent } from './admin-workflow-page/themed-admin-workflow-page.component';
-import { AdminEditCmsMetadataComponent } from './admin-edit-cms-metadata/admin-edit-cms-metadata.component';
-import { AdminEditUserAgreementComponent } from './admin-edit-user-agreement/admin-edit-user-agreement.component';
 
 export const ROUTES: Route[] = [
   {

src/app/app.menus.ts

@@ -21,6 +21,8 @@ import { CurationMenuProvider } from './shared/menu/providers/curation.menu';
 import { DSpaceObjectEditMenuProvider } from './shared/menu/providers/dso-edit.menu';
 import { DsoOptionMenuProvider } from './shared/menu/providers/dso-option.menu';
 import { EditMenuProvider } from './shared/menu/providers/edit.menu';
+import { EditCMSMetadataMenuProvider } from './shared/menu/providers/edit-cms-metadata.menu';
+import { EditUserAgreementMenuProvider } from './shared/menu/providers/edit-user-agreement.menu';
 import { ExportMenuProvider } from './shared/menu/providers/export.menu';
 import { HealthMenuProvider } from './shared/menu/providers/health.menu';
 import { ImportMenuProvider } from './shared/menu/providers/import.menu';
@@ -35,8 +37,6 @@ import { StatisticsMenuProvider } from './shared/menu/providers/statistics.menu'
 import { SystemWideAlertMenuProvider } from './shared/menu/providers/system-wide-alert.menu';
 import { WithdrawnReinstateItemMenuProvider } from './shared/menu/providers/withdrawn-reinstate-item.menu';
 import { WorkflowMenuProvider } from './shared/menu/providers/workflow.menu';
-import { EditCMSMetadataMenuProvider } from './shared/menu/providers/edit-cms-metadata.menu';
-import { EditUserAgreementMenuProvider } from './shared/menu/providers/edit-user-agreement.menu';
 
 /**
  * Represents and builds the menu structure for the three available menus (public navbar, admin sidebar and the dso edit

src/app/core/data/site-data.service.spec.ts

@@ -11,10 +11,10 @@ import { Site } from '../shared/site.model';
 import { createPaginatedList } from '../testing/utils.test';
 import { createSuccessfulRemoteDataObject } from '../utilities/remote-data.utils';
 import { testFindAllDataImplementation } from './base/find-all-data.spec';
+import { DefaultChangeAnalyzer } from './default-change-analyzer.service';
 import { FindListOptions } from './find-list-options.model';
 import { RequestService } from './request.service';
 import { SiteDataService } from './site-data.service';
-import { DefaultChangeAnalyzer } from './default-change-analyzer.service';
 
 describe('SiteDataService', () => {
   let scheduler: TestScheduler;

src/app/core/data/site-data.service.ts

@@ -1,5 +1,6 @@
 import { Injectable } from '@angular/core';
 import { FollowLinkConfig } from '@dspace/core/shared/follow-link-config.model';
+import { Operation } from 'fast-json-patch/module/core';
 import { Observable } from 'rxjs';
 import { map } from 'rxjs/operators';
 
@@ -13,15 +14,16 @@ import {
   FindAllData,
   FindAllDataImpl,
 } from './base/find-all-data';
+import { constructIdEndpointDefault } from './base/identifiable-data.service';
+import {
+  PatchData,
+  PatchDataImpl,
+} from './base/patch-data';
+import { DefaultChangeAnalyzer } from './default-change-analyzer.service';
 import { FindListOptions } from './find-list-options.model';
 import { PaginatedList } from './paginated-list.model';
 import { RemoteData } from './remote-data';
 import { RequestService } from './request.service';
-import { Operation } from 'fast-json-patch/module/core';
-import { PatchData, PatchDataImpl } from './base/patch-data';
-import { DefaultChangeAnalyzer } from './default-change-analyzer.service';
-
-import { constructIdEndpointDefault } from './base/identifiable-data.service';
 
 /**
  * Service responsible for handling requests related to the Site object

src/app/footer/footer.component.spec.ts

@@ -10,17 +10,17 @@ import { ActivatedRoute } from '@angular/router';
 import { APP_CONFIG } from '@dspace/config/app-config.interface';
 import { NotifyInfoService } from '@dspace/core/coar-notify/notify-info/notify-info.service';
 import { AuthorizationDataService } from '@dspace/core/data/feature-authorization/authorization-data.service';
+import { APP_DATA_SERVICES_MAP } from '@dspace/core/data-services-map-type';
+import { LocaleService } from '@dspace/core/locale/locale.service';
+import { ResourceType } from '@dspace/core/shared/resource-type';
 import { ActivatedRouteStub } from '@dspace/core/testing/active-router.stub';
 import { AuthorizationDataServiceStub } from '@dspace/core/testing/authorization-service.stub';
+import { provideMockStore } from '@ngrx/store/testing';
 import { TranslateModule } from '@ngx-translate/core';
 import { of } from 'rxjs';
 
 import { environment } from '../../environments/environment.test';
 import { FooterComponent } from './footer.component';
-import { provideMockStore } from '@ngrx/store/testing';
-import { APP_DATA_SERVICES_MAP } from '@dspace/core/data-services-map-type';
-import { ResourceType } from '@dspace/core/shared/resource-type';
-import { LocaleService } from '@dspace/core/locale/locale.service';
 
 let comp: FooterComponent;
 let fixture: ComponentFixture<FooterComponent>;
@@ -29,8 +29,8 @@ let localeService: any;
 const TEST_MODEL = new ResourceType('testmodel');
 const languageList = ['en;q=1', 'de;q=0.8'];
 const mockLocaleService = jasmine.createSpyObj('LocaleService', {
-    getCurrentLanguageCode: jasmine.createSpy('getCurrentLanguageCode'),
-    getLanguageCodeList: of(languageList),
+  getCurrentLanguageCode: jasmine.createSpy('getCurrentLanguageCode'),
+  getLanguageCodeList: of(languageList),
 });
 
 let notifyInfoService = {
@@ -52,8 +52,8 @@ describe('Footer component', () => {
         provideMockStore({
           initialState: {
             index: {
-            }
-          }
+            },
+          },
         }),
         { provide: LocaleService, useValue: mockLocaleService },
         { provide: AuthorizationDataService, useClass: AuthorizationDataServiceStub },

src/app/footer/footer.component.ts

@@ -17,6 +17,7 @@ import { NotifyInfoService } from '@dspace/core/coar-notify/notify-info/notify-i
 import { OrejimeService } from '@dspace/core/cookies/orejime.service';
 import { AuthorizationDataService } from '@dspace/core/data/feature-authorization/authorization-data.service';
 import { FeatureID } from '@dspace/core/data/feature-authorization/feature-id';
+import { SiteDataService } from '@dspace/core/data/site-data.service';
 import { LocaleService } from '@dspace/core/locale/locale.service';
 import { hasValue } from '@dspace/shared/utils/empty.util';
 import { TranslateModule } from '@ngx-translate/core';
@@ -27,8 +28,8 @@ import {
   of,
   take,
 } from 'rxjs';
+
 import { MarkdownViewerComponent } from '../shared/markdown-viewer/markdown-viewer.component';
-import { SiteDataService } from '@dspace/core/data/site-data.service';
 
 @Component({
   selector: 'ds-base-footer',
@@ -37,9 +38,9 @@ import { SiteDataService } from '@dspace/core/data/site-data.service';
   imports: [
     AsyncPipe,
     DatePipe,
+    MarkdownViewerComponent,
     RouterLink,
     TranslateModule,
-    MarkdownViewerComponent
   ],
 })
 export class FooterComponent implements OnInit {
@@ -75,7 +76,7 @@ export class FooterComponent implements OnInit {
 
     this.footerMetadataValue$ = combineLatest({
       site$: this.siteService.find().pipe(
-        take(1)
+        take(1),
       ),
       language$: this.locale.getCurrentLanguageCode(),
     }).pipe(