[DSC-2256] fix deprecated methods in spec files

Andrea Barbasso · Andrea Barbasso · commit 24ef528efcbc · 2026-01-09T11:44:26.000+01:00
diff --git a/src/app/access-control/epeople-registry/eperson-form/eperson-form.component.spec.ts b/src/app/access-control/epeople-registry/eperson-form/eperson-form.component.spec.ts
@@ -550,7 +550,7 @@ describe('EPersonFormComponent', () => {
 
   describe('findListByHref functionality', () => {
     it('retrieves groups and object on page change', fakeAsync(() => {
-      component.activeEPerson$ = observableOf({ _links: { groups: { href: 'groups' } } } as EPerson);
+      component.activeEPerson$ = of({ _links: { groups: { href: 'groups' } } } as EPerson);
 
       const options = { currentPage: 1, elementsPerPage: 5 };
       component.onPageChange(options.currentPage);
diff --git a/src/app/admin/admin-edit-user-agreement/admin-edit-user-agreement.component.spec.ts b/src/app/admin/admin-edit-user-agreement/admin-edit-user-agreement.component.spec.ts
@@ -1,10 +1,10 @@
 import { CommonModule } from '@angular/common';
 import { NO_ERRORS_SCHEMA } from '@angular/core';
 import {
-  async,
   ComponentFixture,
   inject,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import {
   FormsModule,
@@ -53,7 +53,7 @@ describe('AdminEditUserAgreementComponent', () => {
     },
   });
 
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
 
     scriptDataService = {};
     notificationService = new NotificationsServiceStub();
@@ -89,7 +89,7 @@ describe('AdminEditUserAgreementComponent', () => {
     expect(comp).toBeDefined();
   }));
 
-  it('should fill the text areas with the dc.rights values', async(() => {
+  it('should fill the text areas with the dc.rights values', waitForAsync(() => {
     expect(component.userAgreementTexts.get('en').text).toEqual('This is the End User Agreement text for this test');
     expect(component.userAgreementTexts.get('de').text).toEqual('Dies ist der Text der Endbenutzervereinbarung für diesen Test');
   }));
diff --git a/src/app/admin/admin-notifications/admin-notifications-suggestion-targets-page/admin-notifications-suggestion-targets-page.component.spec.ts b/src/app/admin/admin-notifications/admin-notifications-suggestion-targets-page/admin-notifications-suggestion-targets-page.component.spec.ts
@@ -1,20 +1,20 @@
 import { CommonModule } from '@angular/common';
 import { NO_ERRORS_SCHEMA } from '@angular/core';
 import {
-  async,
   ComponentFixture,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import { TranslateModule } from '@ngx-translate/core';
 
-import { PublicationClaimComponent } from '../../../notifications/suggestion-targets/publication-claim/publication-claim.component';
+import { PublicationClaimComponent } from '../../../notifications/suggestions/targets/publication-claim/publication-claim.component';
 import { AdminNotificationsSuggestionTargetsPageComponent } from './admin-notifications-suggestion-targets-page.component';
 
 describe('AdminNotificationsSuggestionTargetsPageComponent', () => {
   let component: AdminNotificationsSuggestionTargetsPageComponent;
   let fixture: ComponentFixture<AdminNotificationsSuggestionTargetsPageComponent>;
 
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [
         CommonModule,
diff --git a/src/app/charts/components/chart/chart.component.spec.ts b/src/app/charts/components/chart/chart.component.spec.ts
@@ -1,8 +1,8 @@
 import { EventEmitter } from '@angular/core';
 import {
-  async,
   ComponentFixture,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
 import { NgxChartsModule } from '@swimlane/ngx-charts';
@@ -44,7 +44,7 @@ xdescribe('ChartComponent', () => {
   const currentPage = 1;
   const type = ChartType.BAR;
 
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [
         BrowserAnimationsModule,
diff --git a/src/app/charts/components/line-chart/line-chart.component.spec.ts b/src/app/charts/components/line-chart/line-chart.component.spec.ts
@@ -3,9 +3,9 @@ import {
   Injector,
 } from '@angular/core';
 import {
-  async,
   ComponentFixture,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
 import { NgxChartsModule } from '@swimlane/ngx-charts';
@@ -96,7 +96,7 @@ xdescribe('LineChartComponent', () => {
   const currentPage = false;
   const type = ChartType.BAR;
 
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [
         BrowserAnimationsModule,
diff --git a/src/app/shared/context-menu/edit-item/edit-item-menu.component.spec.ts b/src/app/shared/context-menu/edit-item/edit-item-menu.component.spec.ts
@@ -1,7 +1,7 @@
 import {
-  async,
   ComponentFixture,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import { RouterTestingModule } from '@angular/router/testing';
@@ -44,7 +44,7 @@ describe('EditItemMenuComponent', () => {
     modes: createSuccessfulRemoteDataObject$(createPaginatedList([])),
   });
 
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     dso = Object.assign(new Item(), {
       id: 'test-item',
       _links: {
diff --git a/src/app/shared/context-menu/export-item/export-item-menu.component.spec.ts b/src/app/shared/context-menu/export-item/export-item-menu.component.spec.ts
@@ -1,7 +1,7 @@
 import {
-  async,
   ComponentFixture,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import { RouterTestingModule } from '@angular/router/testing';
@@ -39,7 +39,7 @@ describe('ExportItemMenuComponent', () => {
     submitForm: jasmine.createSpy('submitForm'),
   });
 
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     itemExportService.initialItemExportFormConfiguration.and.returnValue(of(configuration));
     dso = Object.assign(new Item(), {
       id: 'test-item',
diff --git a/src/app/shared/context-menu/request-correction/request-correction-menu.component.spec.ts b/src/app/shared/context-menu/request-correction/request-correction-menu.component.spec.ts
@@ -1,7 +1,7 @@
 import {
-  async,
   ComponentFixture,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import { Router } from '@angular/router';
@@ -81,7 +81,7 @@ describe('RequestCorrectionMenuComponent', () => {
     item: createSuccessfulRemoteDataObject$(mockItem),
   });
 
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     dso = Object.assign(new Item(), {
       id: 'test-item',
       _links: {
diff --git a/src/app/shared/context-menu/statistics/statistics-menu.component.spec.ts b/src/app/shared/context-menu/statistics/statistics-menu.component.spec.ts
@@ -1,7 +1,7 @@
 import {
-  async,
   ComponentFixture,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import { RouterTestingModule } from '@angular/router/testing';
@@ -25,7 +25,7 @@ describe('StatisticsMenuComponent', () => {
   let authorizationService: AuthorizationDataService;
   let dso: DSpaceObject;
 
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     dso = Object.assign(new Item(), {
       id: 'test-item',
       _links: {
diff --git a/src/app/shared/cookies/orejime.service.stub.ts b/src/app/shared/cookies/orejime.service.stub.ts
@@ -1,9 +1,18 @@
-import { of } from 'rxjs';
+import {
+  BehaviorSubject,
+  of,
+} from 'rxjs';
 
 export class OrejimeServiceStub {
   initialize = jasmine.createSpy('initialize');
 
   showSettings = jasmine.createSpy('showSettings');
 
   getSavedPreferences = jasmine.createSpy('getSavedPreferences').and.returnValue(of({}));
+
+  watchConsentUpdates = jasmine.createSpy('watchConsentUpdates').and.returnValue(of(null));
+
+  consentsUpdates$: BehaviorSubject<any> = new BehaviorSubject<any>(null);
+
+  initialized$: BehaviorSubject<boolean> = new BehaviorSubject<boolean>(true);
 }
diff --git a/src/app/shared/explore/section-component/multi-column-top-section/multi-column-top-section.component.spec.ts b/src/app/shared/explore/section-component/multi-column-top-section/multi-column-top-section.component.spec.ts
@@ -1,7 +1,7 @@
 import {
-  async,
   ComponentFixture,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 
 import { MultiColumnTopSectionComponent } from './multi-column-top-section.component';
@@ -10,7 +10,7 @@ xdescribe('MultiColumnTopSectionComponent', () => {
   let component: MultiColumnTopSectionComponent;
   let fixture: ComponentFixture<MultiColumnTopSectionComponent>;
 
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [MultiColumnTopSectionComponent],
     })
diff --git a/src/app/shared/metadata-link-view/metadata-link-view-popover/metadata-link-view-popover.component.spec.ts b/src/app/shared/metadata-link-view/metadata-link-view-popover/metadata-link-view-popover.component.spec.ts
@@ -1,8 +1,8 @@
 import { NO_ERRORS_SCHEMA } from '@angular/core';
 import {
-  async,
   ComponentFixture,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import { ActivatedRoute } from '@angular/router';
@@ -71,7 +71,7 @@ describe('MetadataLinkViewPopoverComponent', () => {
     thumbnail: createSuccessfulRemoteDataObject$(new Bitstream()),
   });
 
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [TranslateModule.forRoot(), MetadataLinkViewPopoverComponent],
       schemas: [NO_ERRORS_SCHEMA],
diff --git a/src/app/shared/metric/metric-altmetric/metric-altmetric.component.spec.ts b/src/app/shared/metric/metric-altmetric/metric-altmetric.component.spec.ts
@@ -1,7 +1,7 @@
 import {
-  async,
   ComponentFixture,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import {
@@ -31,7 +31,7 @@ describe('MetricAltmetricComponent', () => {
     type: null,
     _links: null,
   };
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [TranslateModule.forRoot({
         loader: {
diff --git a/src/app/shared/metric/metric-default/metric-default.component.spec.ts b/src/app/shared/metric/metric-default/metric-default.component.spec.ts
@@ -1,8 +1,8 @@
 import { NO_ERRORS_SCHEMA } from '@angular/core';
 import {
-  async,
   ComponentFixture,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import {
   TranslateLoader,
@@ -17,7 +17,7 @@ describe('MetricDspacecrisComponent', () => {
   let component: MetricDefaultComponent;
   let fixture: ComponentFixture<MetricDefaultComponent>;
 
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [
         TranslateModule.forRoot({
diff --git a/src/app/shared/metric/metric-dimensions/metric-dimensions.component.spec.ts b/src/app/shared/metric/metric-dimensions/metric-dimensions.component.spec.ts
@@ -1,7 +1,7 @@
 import {
-  async,
   ComponentFixture,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import {
@@ -31,7 +31,7 @@ describe('MetricDimensionsComponent', () => {
     type: null,
     _links: null,
   };
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [TranslateModule.forRoot({
         loader: {
diff --git a/src/app/shared/metric/metric-googlescholar/metric-googlescholar.component.spec.ts b/src/app/shared/metric/metric-googlescholar/metric-googlescholar.component.spec.ts
@@ -1,7 +1,7 @@
 import {
-  async,
   ComponentFixture,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import { Router } from '@angular/router';
@@ -37,7 +37,7 @@ describe('MetricGooglescholarComponent', () => {
     type: null,
     _links: null,
   };
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [TranslateModule.forRoot({
         loader: {
diff --git a/src/app/shared/metric/metric-loader/base-embedded-metric.component.spec.ts b/src/app/shared/metric/metric-loader/base-embedded-metric.component.spec.ts
@@ -1,10 +1,10 @@
 import { Component } from '@angular/core';
 import {
-  async,
   ComponentFixture,
   fakeAsync,
   TestBed,
   tick,
+  waitForAsync,
 } from '@angular/core/testing';
 import { DomSanitizer } from '@angular/platform-browser';
 
@@ -15,7 +15,7 @@ describe('BaseEmbeddedMetricComponent', () => {
   let component: TestEmbeddedMetricComponent;
   let fixture: ComponentFixture<TestEmbeddedMetricComponent>;
 
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
 
     TestBed.configureTestingModule({
       imports: [TestEmbeddedMetricComponent],
diff --git a/src/app/shared/metric/metric-plumx/metric-plumx.component.spec.ts b/src/app/shared/metric/metric-plumx/metric-plumx.component.spec.ts
@@ -1,8 +1,8 @@
 import { Injector } from '@angular/core';
 import {
-  async,
   ComponentFixture,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import {
@@ -69,7 +69,7 @@ describe('MetricPlumxComponent', () => {
     type: null,
     _links: null,
   };
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [TranslateModule.forRoot({
         loader: {
diff --git a/src/app/shared/search/search-charts/search-chart/search-chart-bar/search-chart-bar.component.spec.ts b/src/app/shared/search/search-charts/search-chart/search-chart-bar/search-chart-bar.component.spec.ts
@@ -3,9 +3,9 @@ import {
   NO_ERRORS_SCHEMA,
 } from '@angular/core';
 import {
-  async,
   ComponentFixture,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import { FormsModule } from '@angular/forms';
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';
@@ -97,7 +97,7 @@ xdescribe('SearchChartBarComponent', () => {
   const mockValues = createSuccessfulRemoteDataObject$(
     buildPaginatedList(new PageInfo(), values),
   );
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [TranslateModule.forRoot(), NoopAnimationsModule, FormsModule, SearchChartBarComponent],
       providers: [
diff --git a/src/app/shared/vocabulary-external-source/vocabulary-external-source.component.spec.ts b/src/app/shared/vocabulary-external-source/vocabulary-external-source.component.spec.ts
@@ -1,8 +1,8 @@
 import { NO_ERRORS_SCHEMA } from '@angular/core';
 import {
-  async,
   ComponentFixture,
   TestBed,
+  waitForAsync,
 } from '@angular/core/testing';
 import {
   NgbActiveModal,
@@ -106,7 +106,7 @@ describe('VocabularyExternalSourceComponent', () => {
     name: 'Collection 1',
   });
 
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [
         TranslateModule.forRoot({
diff --git a/src/app/statistics-page/cris-statistics-page/statistics-chart/statistics-chart-bar/statistics-chart-bar.component.spec.ts b/src/app/statistics-page/cris-statistics-page/statistics-chart/statistics-chart-bar/statistics-chart-bar.component.spec.ts
diff --git a/src/app/statistics-page/cris-statistics-page/statistics-chart/statistics-chart-line/statistics-chart-line.component.spec.ts b/src/app/statistics-page/cris-statistics-page/statistics-chart/statistics-chart-line/statistics-chart-line.component.spec.ts
diff --git a/src/app/statistics-page/cris-statistics-page/statistics-chart/statistics-chart-pie/statistics-chart-pie.component.spec.ts b/src/app/statistics-page/cris-statistics-page/statistics-chart/statistics-chart-pie/statistics-chart-pie.component.spec.ts
diff --git a/src/app/statistics-page/cris-statistics-page/statistics-chart/statistics-chart-wrapper/statistics-chart-wrapper.component.spec.ts b/src/app/statistics-page/cris-statistics-page/statistics-chart/statistics-chart-wrapper/statistics-chart-wrapper.component.spec.ts
diff --git a/src/app/statistics-page/cris-statistics-page/statistics-chart/statistics-chart.component.spec.ts b/src/app/statistics-page/cris-statistics-page/statistics-chart/statistics-chart.component.spec.ts
