[DSC-2256] fix lint

Author: Andrea Barbasso

package.json

@@ -28,8 +28,8 @@
     "test:lint": "npm run build:lint && npm run test:lint:nobuild",
     "test:lint:nobuild": "jasmine --config=lint/jasmine.json",
     "lint": "npm run build:lint && npm run lint:nobuild",
-    "lint:nobuild": "ng lint",
-    "lint-fix": "npm run build:lint && ng lint --fix=true",
+    "lint:nobuild": "npm run ng-high-memory -- lint",
+    "lint-fix": "npm run build:lint && npm run ng-high-memory -- lint --fix=true",
     "docs:lint": "ts-node --project ./lint/tsconfig.json ./lint/generate-docs.ts",
     "e2e": "cross-env NODE_ENV=production ng e2e",
     "clean:dev:config": "rimraf src/assets/config.json",

src/app/collection-page/collection-page.component.ts

@@ -47,7 +47,6 @@ import { ThemedComcolPageHandleComponent } from '../shared/comcol/comcol-page-ha
 import { ComcolPageHeaderComponent } from '../shared/comcol/comcol-page-header/comcol-page-header.component';
 import { ComcolPageLogoComponent } from '../shared/comcol/comcol-page-logo/comcol-page-logo.component';
 import { ContextMenuComponent } from '../shared/context-menu/context-menu.component';
-import { DsoEditMenuComponent } from '../shared/dso-page/dso-edit-menu/dso-edit-menu.component';
 import {
   hasValue,
   isNotEmpty,

src/app/community-page/community-page.component.ts

@@ -34,7 +34,6 @@ import { ThemedComcolPageHandleComponent } from '../shared/comcol/comcol-page-ha
 import { ComcolPageHeaderComponent } from '../shared/comcol/comcol-page-header/comcol-page-header.component';
 import { ComcolPageLogoComponent } from '../shared/comcol/comcol-page-logo/comcol-page-logo.component';
 import { ContextMenuComponent } from '../shared/context-menu/context-menu.component';
-import { DsoEditMenuComponent } from '../shared/dso-page/dso-edit-menu/dso-edit-menu.component';
 import { hasValue } from '../shared/empty.util';
 import { ErrorComponent } from '../shared/error/error.component';
 import { ThemedLoadingComponent } from '../shared/loading/themed-loading.component';

src/app/core/json-patch/json-patch-operations.service.ts

@@ -112,7 +112,7 @@ export abstract class JsonPatchOperationsService<ResponseDefinitionDomain, Patch
             map((rd: RemoteData<any>) => {
               if (rd.hasFailed) {
                 this.store.dispatch(new RollbacktPatchOperationsAction(resourceType, resourceId));
-                throw rd;
+                throw rd as unknown as Error;
               } else if (hasValue(rd.payload) && isNotEmpty(rd.payload.dataDefinition)) {
                 this.store.dispatch(new CommitPatchOperationsAction(resourceType, resourceId));
                 return rd.payload.dataDefinition;

src/app/core/locale/locale.service.spec.ts

@@ -62,173 +62,173 @@ describe('LocaleService', () => {
 
   describe('with valid language', () => {
 
-  beforeEach(waitForAsync(() => {
-    return TestBed.configureTestingModule({
-      imports: [
-        TranslateModule.forRoot({
-          loader: {
-            provide: TranslateLoader,
-            useClass: TranslateLoaderMock,
-          },
-        }),
-      ],
-      providers: [
-        { provide: CookieService, useValue: new CookieServiceMock() },
-        { provide: AuthService, userValue: authService },
-        { provide: RouteService, useValue: routeServiceStub },
-        { provide: TranslateService, useValue: translateServiceStub },
-        { provide: Document, useValue: document },
+    beforeEach(waitForAsync(() => {
+      return TestBed.configureTestingModule({
+        imports: [
+          TranslateModule.forRoot({
+            loader: {
+              provide: TranslateLoader,
+              useClass: TranslateLoaderMock,
+            },
+          }),
+        ],
+        providers: [
+          { provide: CookieService, useValue: new CookieServiceMock() },
+          { provide: AuthService, userValue: authService },
+          { provide: RouteService, useValue: routeServiceStub },
+          { provide: TranslateService, useValue: translateServiceStub },
+          { provide: Document, useValue: document },
           { provide: PLATFORM_ID, useValue: platformId },
-      ],
-    });
-  }));
-
-  beforeEach(() => {
-    cookieService = TestBed.inject(CookieService);
-    translateService = TestBed.inject(TranslateService);
-    routeService = TestBed.inject(RouteService);
-    window = new NativeWindowRef();
-    document = { documentElement: { lang: 'en' } };
+        ],
+      });
+    }));
+
+    beforeEach(() => {
+      cookieService = TestBed.inject(CookieService);
+      translateService = TestBed.inject(TranslateService);
+      routeService = TestBed.inject(RouteService);
+      window = new NativeWindowRef();
+      document = { documentElement: { lang: 'en' } };
       service = new LocaleService(window, cookieService, translateService, authService, routeService, document, platformId);
-    serviceAsAny = service;
-    spyOnGet = spyOn(cookieService, 'get');
-    spyOnSet = spyOn(cookieService, 'set');
+      serviceAsAny = service;
+      spyOnGet = spyOn(cookieService, 'get');
+      spyOnSet = spyOn(cookieService, 'set');
       spyOnGetLanguage = spyOn(routeService, 'getQueryParameterValue').withArgs('lang');
-  });
+    });
 
-  describe('getCurrentLanguageCode', () => {
-    let testScheduler: TestScheduler;
+    describe('getCurrentLanguageCode', () => {
+      let testScheduler: TestScheduler;
 
-    beforeEach(() => {
-      spyOn(translateService, 'getLangs').and.returnValue(langList);
-      testScheduler = new TestScheduler((actual, expected) => {
+      beforeEach(() => {
+        spyOn(translateService, 'getLangs').and.returnValue(langList);
+        testScheduler = new TestScheduler((actual, expected) => {
         // use jasmine to test equality
-        expect(actual).toEqual(expected);
+          expect(actual).toEqual(expected);
+        });
+        authService.isAuthenticated.and.returnValue(of(false));
+        authService.isAuthenticationLoaded.and.returnValue(of(false));
       });
-      authService.isAuthenticated.and.returnValue(of(false));
-      authService.isAuthenticationLoaded.and.returnValue(of(false));
-    });
 
-    it('should return the language saved on cookie if it\'s a valid & active language', () => {
-      spyOnGet.and.returnValue('de');
-      testScheduler.run(({ expectObservable }) => {
-        expectObservable(service.getCurrentLanguageCode()).toBe('(a|)', { a: 'de' });
+      it('should return the language saved on cookie if it\'s a valid & active language', () => {
+        spyOnGet.and.returnValue('de');
+        testScheduler.run(({ expectObservable }) => {
+          expectObservable(service.getCurrentLanguageCode()).toBe('(a|)', { a: 'de' });
+        });
       });
-    });
 
-    it('should return the fallback language if the cookie language is disabled', () => {
-      spyOnGet.and.returnValue('disabled');
-      testScheduler.run(({ expectObservable }) => {
-        expectObservable(service.getCurrentLanguageCode()).toBe('(a|)', { a: 'en' });
+      it('should return the fallback language if the cookie language is disabled', () => {
+        spyOnGet.and.returnValue('disabled');
+        testScheduler.run(({ expectObservable }) => {
+          expectObservable(service.getCurrentLanguageCode()).toBe('(a|)', { a: 'en' });
+        });
       });
-    });
 
-    it('should return the fallback language if the cookie language does not exist', () => {
-      spyOnGet.and.returnValue('does-not-exist');
-      testScheduler.run(({ expectObservable }) => {
-        expectObservable(service.getCurrentLanguageCode()).toBe('(a|)', { a: 'en' });
+      it('should return the fallback language if the cookie language does not exist', () => {
+        spyOnGet.and.returnValue('does-not-exist');
+        testScheduler.run(({ expectObservable }) => {
+          expectObservable(service.getCurrentLanguageCode()).toBe('(a|)', { a: 'en' });
+        });
       });
-    });
 
-    it('should return language from browser setting', () => {
-      spyOn(service, 'getLanguageCodeList').and.returnValue(of(['xx', 'en']));
-      testScheduler.run(({ expectObservable }) => {
-        expectObservable(service.getCurrentLanguageCode()).toBe('(a|)', { a: 'xx' });
+      it('should return language from browser setting', () => {
+        spyOn(service, 'getLanguageCodeList').and.returnValue(of(['xx', 'en']));
+        testScheduler.run(({ expectObservable }) => {
+          expectObservable(service.getCurrentLanguageCode()).toBe('(a|)', { a: 'xx' });
+        });
       });
-    });
 
-    it('should match language from browser setting case insensitive', () => {
-      spyOn(service, 'getLanguageCodeList').and.returnValue(of(['DE', 'en']));
-      testScheduler.run(({ expectObservable }) => {
-        expectObservable(service.getCurrentLanguageCode()).toBe('(a|)', { a: 'DE' });
+      it('should match language from browser setting case insensitive', () => {
+        spyOn(service, 'getLanguageCodeList').and.returnValue(of(['DE', 'en']));
+        testScheduler.run(({ expectObservable }) => {
+          expectObservable(service.getCurrentLanguageCode()).toBe('(a|)', { a: 'DE' });
+        });
       });
     });
-  });
 
-  describe('getLanguageCodeList', () => {
-    let testScheduler: TestScheduler;
+    describe('getLanguageCodeList', () => {
+      let testScheduler: TestScheduler;
 
-    beforeEach(() => {
-      spyOn(translateService, 'getLangs').and.returnValue(langList);
-      testScheduler = new TestScheduler((actual, expected) => {
+      beforeEach(() => {
+        spyOn(translateService, 'getLangs').and.returnValue(langList);
+        testScheduler = new TestScheduler((actual, expected) => {
         // use jasmine to test equality
-        expect(actual).toEqual(expected);
+          expect(actual).toEqual(expected);
+        });
       });
-    });
 
-    it('should return default language list without user preferred language when no logged in user', () => {
-      authService.isAuthenticated.and.returnValue(of(false));
-      authService.isAuthenticationLoaded.and.returnValue(of(false));
-      testScheduler.run(({ expectObservable }) => {
-        expectObservable(service.getLanguageCodeList()).toBe('(a|)', { a: ['en-US;q=1', 'en;q=0.9'] });
+      it('should return default language list without user preferred language when no logged in user', () => {
+        authService.isAuthenticated.and.returnValue(of(false));
+        authService.isAuthenticationLoaded.and.returnValue(of(false));
+        testScheduler.run(({ expectObservable }) => {
+          expectObservable(service.getLanguageCodeList()).toBe('(a|)', { a: ['en-US;q=1', 'en;q=0.9'] });
+        });
       });
-    });
 
-    it('should return default language list with user preferred language when user is logged in', () => {
-      authService.isAuthenticated.and.returnValue(of(true));
-      authService.isAuthenticationLoaded.and.returnValue(of(true));
-      authService.getAuthenticatedUserFromStore.and.returnValue(of(EPersonMock2));
-      testScheduler.run(({ expectObservable }) => {
-        expectObservable(service.getLanguageCodeList()).toBe('(a|)', { a: ['fr;q=0.5', 'en-US;q=1', 'en;q=0.9'] });
+      it('should return default language list with user preferred language when user is logged in', () => {
+        authService.isAuthenticated.and.returnValue(of(true));
+        authService.isAuthenticationLoaded.and.returnValue(of(true));
+        authService.getAuthenticatedUserFromStore.and.returnValue(of(EPersonMock2));
+        testScheduler.run(({ expectObservable }) => {
+          expectObservable(service.getLanguageCodeList()).toBe('(a|)', { a: ['fr;q=0.5', 'en-US;q=1', 'en;q=0.9'] });
+        });
       });
-    });
 
-    describe('', () => {
-      beforeEach(() => {
-        spyOn(translateService, 'getLangs').and.returnValue(langList);
-      });
+      describe('', () => {
+        beforeEach(() => {
+          spyOn(translateService, 'getLangs').and.returnValue(langList);
+        });
 
-      it('should return language from browser setting', () => {
-        spyOn(translateService, 'getBrowserLang').and.returnValue('xx');
-        expect(service.getCurrentLanguageCode()).toBe(of('xx'));
-      });
+        it('should return language from browser setting', () => {
+          spyOn(translateService, 'getBrowserLang').and.returnValue('xx');
+          expect(service.getCurrentLanguageCode()).toBe(of('xx'));
+        });
 
-      it('should return default language from config', () => {
-        spyOn(translateService, 'getBrowserLang').and.returnValue('fr');
-        expect(service.getCurrentLanguageCode()).toBe(of('en'));
+        it('should return default language from config', () => {
+          spyOn(translateService, 'getBrowserLang').and.returnValue('fr');
+          expect(service.getCurrentLanguageCode()).toBe(of('en'));
+        });
       });
     });
-  });
-
-  describe('getLanguageCodeFromCookie', () => {
-    it('should return language from cookie', () => {
-      spyOnGet.and.returnValue('de');
-      expect(service.getLanguageCodeFromCookie()).toBe('de');
-    });
 
-  });
+    describe('getLanguageCodeFromCookie', () => {
+      it('should return language from cookie', () => {
+        spyOnGet.and.returnValue('de');
+        expect(service.getLanguageCodeFromCookie()).toBe('de');
+      });
 
-  describe('saveLanguageCodeToCookie', () => {
-    it('should save language to cookie', () => {
-      service.saveLanguageCodeToCookie('en');
-      expect(spyOnSet).toHaveBeenCalledWith(LANG_COOKIE, 'en');
     });
-  });
 
-  describe('setCurrentLanguageCode', () => {
-    beforeEach(() => {
-      spyOn(service, 'saveLanguageCodeToCookie');
-      spyOn(translateService, 'use');
+    describe('saveLanguageCodeToCookie', () => {
+      it('should save language to cookie', () => {
+        service.saveLanguageCodeToCookie('en');
+        expect(spyOnSet).toHaveBeenCalledWith(LANG_COOKIE, 'en');
+      });
     });
 
-    it('should set the given language', () => {
+    describe('setCurrentLanguageCode', () => {
+      beforeEach(() => {
+        spyOn(service, 'saveLanguageCodeToCookie');
+        spyOn(translateService, 'use');
+      });
+
+      it('should set the given language', () => {
         service.setCurrentLanguageCode('it');
         expect(translateService.use).toHaveBeenCalledWith('it');
         expect(service.saveLanguageCodeToCookie).toHaveBeenCalledWith('it');
-    });
+      });
 
-    it('should set the current language', () => {
-      spyOn(service, 'getCurrentLanguageCode').and.returnValue(of('es'));
-      service.setCurrentLanguageCode();
-      expect(translateService.use).toHaveBeenCalledWith('es');
+      it('should set the current language', () => {
+        spyOn(service, 'getCurrentLanguageCode').and.returnValue(of('es'));
+        service.setCurrentLanguageCode();
+        expect(translateService.use).toHaveBeenCalledWith('es');
         expect(service.saveLanguageCodeToCookie).toHaveBeenCalledWith('es');
-    });
+      });
 
-    it('should set the current language on the html tag', () => {
-      spyOn(service, 'getCurrentLanguageCode').and.returnValue(of('es'));
-      service.setCurrentLanguageCode();
-      expect((service as any).document.documentElement.lang).toEqual('es');
-    });
+      it('should set the current language on the html tag', () => {
+        spyOn(service, 'getCurrentLanguageCode').and.returnValue(of('es'));
+        service.setCurrentLanguageCode();
+        expect((service as any).document.documentElement.lang).toEqual('es');
+      });
 
       describe('should set language on init', () => {
         beforeEach(() => {
@@ -254,21 +254,21 @@ describe('LocaleService', () => {
           });
         });
       });
-  });
+    });
 
-  describe('', () => {
-    it('should set quality to current language list', () => {
+    describe('', () => {
+      it('should set quality to current language list', () => {
         const langListWithQuality = ['en;q=1', 'it;q=0.9', 'de;q=0.8'];
-      spyOn(service, 'setQuality').and.returnValue(langListWithQuality);
-      service.setQuality(langList, LANG_ORIGIN.BROWSER, false);
-      expect(service.setQuality).toHaveBeenCalledWith(langList, LANG_ORIGIN.BROWSER, false);
-    });
+        spyOn(service, 'setQuality').and.returnValue(langListWithQuality);
+        service.setQuality(langList, LANG_ORIGIN.BROWSER, false);
+        expect(service.setQuality).toHaveBeenCalledWith(langList, LANG_ORIGIN.BROWSER, false);
+      });
 
-    it('should return the list of language with quality factor', () => {
-      spyOn(service, 'getLanguageCodeList');
-      service.getLanguageCodeList();
-      expect(service.getLanguageCodeList).toHaveBeenCalled();
+      it('should return the list of language with quality factor', () => {
+        spyOn(service, 'getLanguageCodeList');
+        service.getLanguageCodeList();
+        expect(service.getLanguageCodeList).toHaveBeenCalled();
+      });
     });
   });
 });
-});

src/app/core/metadata/head-tag.service.ts

@@ -783,8 +783,11 @@ export class HeadTagService {
     if (content) {
       const tag = isProperty ? { name, property: name, content } as MetaDefinition
         : { name, content } as MetaDefinition;
-      isMultiple ? this.meta.addTag(tag) : this.meta.updateTag(tag);
-      this.storeTag(name);
+      if (isMultiple) {
+        this.meta.addTag(tag);
+      } else {
+        this.meta.updateTag(tag);
+      } this.storeTag(name);
     }
   }
 

src/app/cris-layout/cris-layout-matrix/cris-layout-box-container/boxes/metadata/rendering-types/cc-license-large/cc-license-large.component.ts

@@ -12,7 +12,9 @@ import { MetadataGroupComponent } from '../metadataGroup/metadata-group.componen
 
 @Component({
   selector: 'ds-cc-license-large',
-  imports: [ItemPageCcLicenseFieldComponent],
+  imports: [
+    ItemPageCcLicenseFieldComponent,
+  ],
   templateUrl: './cc-license-large.component.html',
   styleUrl: './cc-license-large.component.scss',
 })