refactor(rpc): gRPC codegen should pass request metadata to handle()#2312
Open
kkovaacs wants to merge 5 commits into
Open
refactor(rpc): gRPC codegen should pass request metadata to handle()#2312kkovaacs wants to merge 5 commits into
handle()#2312kkovaacs wants to merge 5 commits into
Conversation
For handlers where the only member was the protobuf message.
Mirko-von-Leipzig
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As described in issue #2302 we now have quite a few gRPC method implementations where we're overriding the generated
full()method just so that we have access to request metadata (client IP address, header values, etc.).This PR changes the gRPC codegen so that the
handle()method gets passed the gRPC request metadata (in addition to the decoded request).Please note that we're passing a lightweight
tonic::Request<()>instead of the original request because that'd require cloning the payload.Closes #2302
Changelog