refactor(ntx-builder): replace dataless Notify with per-account watch#2301
Open
SantiagoPittella wants to merge 3 commits into
Open
refactor(ntx-builder): replace dataless Notify with per-account watch#2301SantiagoPittella wants to merge 3 commits into
SantiagoPittella wants to merge 3 commits into
Conversation
1976ec1 to
70a3d2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2259
Summary
Replaces the dataless
Notifythe ntx-builder coordinator used to wake account actors with a per-accountwatch::channel<AccountView>that carries the committed-block state to each actor directly.Why:
How:
AccountView { chain_tip, last_committed_tx, notes_seen }per account via a watch channel. Fields are cumulative, so an actor that slept through several blocks reads one summarised view and answers everything in memory.account_last_txquery.available_notesnow also returns next_retry_block. Actors schedule a single re-check instead of polling each block.biasedselect! + an authoritative account_has_pending_notes recheck on reap, replacing the old Notify-permit trick.Changelog