Skip to content
This repository was archived by the owner on Jan 2, 2026. It is now read-only.

Commit 39c13b5

Browse files
zircoteclaude
andcommitted
fix: address review findings for unused variables and redundant import
- Remove redundant logging import in test_hook_utils.py - Use types_found variable in assertion (test_session_analyzer.py) - Add assertion for result variable (test_session_analyzer.py) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent d0df5e5 commit 39c13b5

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

tests/test_hook_utils.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ def reset_hook_loggers() -> Iterator[None]:
4848
Also clears handlers from the underlying Python loggers to prevent
4949
cross-test pollution from the global logging.Logger cache.
5050
"""
51-
import logging
52-
5351
from git_notes_memory.hooks import hook_utils
5452

5553
def _clear_hook_loggers() -> None:

tests/test_session_analyzer.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -784,6 +784,7 @@ def test_analyzes_raw_string_content(
784784

785785
result = analyzer.analyze_content("I decided to use PostgreSQL for storage")
786786
assert mock_signal_detector.detect.called
787+
assert isinstance(result, list) # Verify result type
787788

788789
def test_returns_empty_for_empty_content(self, analyzer: SessionAnalyzer) -> None:
789790
"""Test returns empty list for empty content."""
@@ -1047,8 +1048,9 @@ def test_full_analysis_workflow_jsonl(self, tmp_path: Path) -> None:
10471048
result = analyzer.analyze(str(transcript), check_novelty=False)
10481049

10491050
# Should detect decision and learning signals
1050-
types_found = {s.type for s in result}
10511051
assert len(result) >= 1
1052+
types_found = {s.type for s in result}
1053+
assert types_found # Verify types were extracted
10521054

10531055
def test_full_analysis_workflow_plain_text(self, tmp_path: Path) -> None:
10541056
"""Test full analysis workflow with plain text transcript."""

0 commit comments

Comments
 (0)