remove some lint ignores

- fix deflate feature flag in test

Author: cosmicexplorer

benches/read_metadata.rs

@@ -124,7 +124,7 @@ fn parse_large_non_zip(bench: &mut Bencher) {
     let dir = TempDir::with_prefix("large-non-zip-bench").unwrap();
     let file = dir.path().join("zeros");
     let buf = vec![0u8; FILE_SIZE];
-    fs::write(&file, &buf).unwrap();
+    fs::write(&file, buf).unwrap();
 
     bench.iter(|| {
         assert!(zip::ZipArchive::new(std::fs::File::open(&file).unwrap()).is_err());

src/read/pipelining.rs

@@ -1,8 +1,5 @@
 //! Pipelined extraction into a filesystem directory.
 
-#![allow(clippy::needless_lifetimes)]
-#![allow(unknown_lints)]
-#![allow(non_local_definitions)]
 #![cfg_attr(not(unix), allow(dead_code))]
 
 pub mod path_splitting {
@@ -83,7 +80,7 @@ pub mod path_splitting {
         pub children: BTreeMap<&'a str, Box<FSEntry<'a, Data>>>,
     }
 
-    impl<'a, Data> Default for DirEntry<'a, Data> {
+    impl<Data> Default for DirEntry<'_, Data> {
         fn default() -> Self {
             Self {
                 properties: None,
@@ -404,16 +401,16 @@ pub mod handle_creation {
         }
     }
 
-    impl<'a> cmp::PartialEq for ZipDataHandle<'a> {
+    impl cmp::PartialEq for ZipDataHandle<'_> {
         #[inline(always)]
         fn eq(&self, other: &Self) -> bool {
             self.ptr() == other.ptr()
         }
     }
 
-    impl<'a> cmp::Eq for ZipDataHandle<'a> {}
+    impl cmp::Eq for ZipDataHandle<'_> {}
 
-    impl<'a> hash::Hash for ZipDataHandle<'a> {
+    impl hash::Hash for ZipDataHandle<'_> {
         #[inline(always)]
         fn hash<H: hash::Hasher>(&self, state: &mut H) {
             self.ptr().hash(state);
@@ -1159,12 +1156,9 @@ pub mod split_extraction {
             zip.add_directory("a/b", opts.unix_permissions(0o500))
                 .unwrap();
 
-            zip.start_file(
-                "d/e",
-                opts.compression_method(CompressionMethod::Deflated)
-                    .unix_permissions(0o755),
-            )
-            .unwrap();
+            #[cfg(feature = "_deflate-any")]
+            let opts = opts.compression_method(CompressionMethod::Deflated);
+            zip.start_file("d/e", opts.unix_permissions(0o755)).unwrap();
             zip.write_all(b"ffasedfasjkef").unwrap();
 
             /* Create readable archive and extraction dir. */

src/read/split.rs

@@ -1,6 +1,5 @@
 //! Traits for splitting and teeing file contents into multiple parallel streams.
 
-#![allow(clippy::needless_lifetimes)]
 #![cfg_attr(not(unix), allow(dead_code))]
 
 macro_rules! interruptible_buffered_io_op {
@@ -230,13 +229,13 @@ pub mod file {
             }
         }
 
-        impl<'fd> FixedFile for FileInput<'fd> {
+        impl FixedFile for FileInput<'_> {
             fn extent(&self) -> u64 {
                 self.extent
             }
         }
 
-        impl<'fd> InputFile for FileInput<'fd> {
+        impl InputFile for FileInput<'_> {
             fn pread(&self, start: u64, buf: &mut [MaybeUninit<u8>]) -> io::Result<usize> {
                 let count = self.range_len(start, buf.len())?;
 
@@ -300,7 +299,7 @@ pub mod file {
             _ph: PhantomData<&'infd u8>,
         }
 
-        impl<'infd, 'buf> FileBufferCopy<'infd, 'buf> {
+        impl<'buf> FileBufferCopy<'_, 'buf> {
             pub fn new(buf: &'buf mut [u8]) -> Self {
                 assert!(!buf.is_empty());
                 Self {
@@ -369,7 +368,6 @@ pub mod file {
                 Ok(i)
             }
 
-            #[allow(clippy::missing_transmute_annotations)]
             #[test]
             fn pread() {
                 let i = readable_file(b"asdf").unwrap();
@@ -379,12 +377,12 @@ pub mod file {
                 let mut buf: [MaybeUninit<u8>; 10] = unsafe { mem::transmute(buf) };
                 assert_eq!(2, ii.pread(0, &mut buf[..2]).unwrap());
                 assert_eq!(
-                    unsafe { mem::transmute::<_, &[u8]>(&buf[..2]) },
+                    unsafe { mem::transmute::<&[mem::MaybeUninit<u8>], &[u8]>(&buf[..2]) },
                     b"as".as_ref()
                 );
                 assert_eq!(3, ii.pread(1, &mut buf[4..]).unwrap());
                 assert_eq!(
-                    unsafe { mem::transmute::<_, &[u8]>(&buf[..]) },
+                    unsafe { mem::transmute::<&[mem::MaybeUninit<u8>], &[u8]>(&buf[..]) },
                     &[b'a', b's', 0, 0, b's', b'd', b'f', 0, 0, 0]
                 );
             }
@@ -445,7 +443,7 @@ pub mod file {
 
         pub struct FileCopy<'infd>(PhantomData<&'infd u8>);
 
-        impl<'infd> FileCopy<'infd> {
+        impl FileCopy<'_> {
             pub const fn new() -> Self {
                 Self(PhantomData)
             }
@@ -729,7 +727,7 @@ pub mod pipe {
             _ph: PhantomData<&'infd u8>,
         }
 
-        impl<'infd, 'buf> PipeWriteBufferSplicer<'infd, 'buf> {
+        impl<'buf> PipeWriteBufferSplicer<'_, 'buf> {
             #[allow(dead_code)]
             pub fn new(buf: &'buf mut [u8]) -> Self {
                 assert!(!buf.is_empty());
@@ -931,7 +929,7 @@ pub mod pipe {
 
         pub struct PipeWriteSplicer<'infd>(PhantomData<&'infd u8>);
 
-        impl<'infd> PipeWriteSplicer<'infd> {
+        impl PipeWriteSplicer<'_> {
             pub const fn new() -> Self {
                 Self(PhantomData)
             }

tests/extract_symlink.rs

@@ -14,7 +14,7 @@ fn extract_should_respect_links() {
     let symlink_path = temp_dir.path().join("pandoc-3.2-arm64/bin/pandoc-lua");
 
     // Read the target of the symbolic link
-    let target_path = fs::read_link(&symlink_path).unwrap();
+    let target_path = fs::read_link(symlink_path).unwrap();
 
     assert_eq!(target_path, PathBuf::from_str("pandoc").unwrap());
 }