test: Potential fixes for 3 code quality findings in benches/read-metadata.rs (#610)

* Apply suggested fix to benches/read_metadata.rs from Copilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>

* Apply suggested fix to benches/read_metadata.rs from Copilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>

* Apply suggested fix to benches/read_metadata.rs from Copilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>

* [skip ci] chore: run cargo fmt --all to apply standard formatting

* cargo fmt --all

---------

Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: amazon-q-developer[bot] <208079219+amazon-q-developer[bot]@users.noreply.github.com>

Author: 3 people

benches/read_metadata.rs

@@ -18,8 +18,9 @@ fn generate_random_archive(count_files: usize, file_size: usize) -> ZipResult<Ve
 
     let mut bytes = vec![0u8; file_size];
 
-    for i in 0..count_files {
-        let name = format!("file_deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef_{i}.dat");
+    for file_index in 0..count_files {
+        let name =
+            format!("file_deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef_{file_index}.dat");
         writer.start_file(name, options)?;
         getrandom::fill(&mut bytes)
             .map_err(|e| std::io::Error::other(format!("getrandom error: {}", e)))?;
@@ -79,9 +80,7 @@ fn generate_zip64_archive_with_random_comment(comment_length: usize) -> ZipResul
     let mut bytes = vec![0u8; comment_length];
     getrandom::fill(&mut bytes)
         .map_err(|e| std::io::Error::other(format!("getrandom error: {}", e)))?;
-    // should use the line below but still works
-    // writer.set_raw_zip64_comment(Some(comment));
-    writer.set_raw_comment(bytes.into_boxed_slice());
+    writer.set_raw_zip64_comment(Some(bytes.into_boxed_slice()));
 
     writer.start_file("asdf.txt", options)?;
     writer.write_all(b"asdf")?;
@@ -105,7 +104,7 @@ fn parse_stream_archive(bench: &mut Bencher) {
 
     let bytes = generate_random_archive(STREAM_ZIP_ENTRIES, STREAM_FILE_SIZE).unwrap();
 
-    /* Write to a temporary file path to incur some filesystem overhead from repeated reads */
+    // Write to a temporary file path to incur some filesystem overhead from repeated reads
     let dir = TempDir::with_prefix("stream-bench").unwrap();
     let out = dir.path().join("bench-out.zip");
     fs::write(&out, &bytes).unwrap();
@@ -121,13 +120,13 @@ fn parse_stream_archive(bench: &mut Bencher) {
 }
 
 fn parse_large_non_zip(bench: &mut Bencher) {
-    const FILE_SIZE: usize = 17_000_000;
+    const LARGE_FILE_SIZE: usize = 17_000_000;
 
     // Create a large file that doesn't have a zip header (generating random data _might_ make a zip magic
     // number somewhere which is _not_ what we're trying to test).
     let dir = TempDir::with_prefix("large-non-zip-bench").unwrap();
     let file = dir.path().join("zeros");
-    let buf = vec![0u8; FILE_SIZE];
+    let buf = vec![0u8; LARGE_FILE_SIZE];
     fs::write(&file, &buf).unwrap();
 
     bench.iter(|| {