ui: warn before bounded string search

Author: yhs0602

app/src/main/java/com/kyhsgeekcode/disassembler/ui/MainPage.kt

@@ -77,8 +77,9 @@ fun MainScreen(viewModel: MainViewModel) {
 
                     val showSearchForStringsDialog =
                         viewModel.showSearchForStringsDialog.collectAsState()
-                    if (showSearchForStringsDialog.value == ShowSearchForStringsDialog.Shown) {
-                        SearchForStringsDialog(viewModel)
+                    val dialogState = showSearchForStringsDialog.value
+                    if (dialogState is ShowSearchForStringsDialog.Shown) {
+                        SearchForStringsDialog(viewModel, dialogState.notice)
                     }
                 }
             }

app/src/main/java/com/kyhsgeekcode/disassembler/ui/tabs/StringTab.kt

@@ -67,6 +67,16 @@ internal fun buildStringSearchNotice(
     }
 }
 
+internal fun buildStringSearchDialogNotice(
+    originalSize: Long,
+    maxBytes: Int = MAX_SEARCHED_STRING_BYTES
+): String? {
+    if (originalSize <= maxBytes) {
+        return null
+    }
+    return "Large file detected. String search will only scan the first $maxBytes bytes of $originalSize bytes."
+}
+
 internal fun clipFoundStringForRendering(
     result: FoundString,
     maxChars: Int = MAX_RENDERED_STRING_CHARS
@@ -187,7 +197,7 @@ fun StringTab(data: TabData, viewModel: MainViewModel) {
 }
 
 @Composable
-fun SearchForStringsDialog(viewModel: MainViewModel) {
+fun SearchForStringsDialog(viewModel: MainViewModel, notice: String?) {
     var from by remember { mutableStateOf("0") }
     var to by remember { mutableStateOf("0") }
     AlertDialog(
@@ -198,10 +208,18 @@ fun SearchForStringsDialog(viewModel: MainViewModel) {
             Text(text = "Search for strings with length ? to ?")
         },
         text = {
-            Row {
-                NumberTextField(from, { from = it }, modifier = Modifier.weight(1f))
-                Text(text = "to..")
-                NumberTextField(to, { to = it }, modifier = Modifier.weight(1f))
+            Column {
+                notice?.let {
+                    Text(
+                        text = it,
+                        modifier = Modifier.padding(bottom = 8.dp)
+                    )
+                }
+                Row {
+                    NumberTextField(from, { from = it }, modifier = Modifier.weight(1f))
+                    Text(text = "to..")
+                    NumberTextField(to, { to = it }, modifier = Modifier.weight(1f))
+                }
             }
         },
         confirmButton = {

app/src/main/java/com/kyhsgeekcode/disassembler/viewmodel/MainViewModel.kt

@@ -72,7 +72,7 @@ internal fun openedProjectWorkspaceState(
 
 sealed class ShowSearchForStringsDialog {
     object NotShown : ShowSearchForStringsDialog()
-    object Shown : ShowSearchForStringsDialog()
+    data class Shown(val notice: String?) : ShowSearchForStringsDialog()
 }
 
 class MainViewModel(application: Application) : AndroidViewModel(application) {
@@ -359,7 +359,10 @@ class MainViewModel(application: Application) : AndroidViewModel(application) {
 
     fun searchForStrings() {
         Timber.d("Will be shown strings dialog")
-        _showSearchForStrings.value = ShowSearchForStringsDialog.Shown
+        val notice = getCurrentRelPath()
+            ?.let { ProjectDataStorage.resolveToRead(it)?.length() }
+            ?.let { buildStringSearchDialogNotice(it) }
+        _showSearchForStrings.value = ShowSearchForStringsDialog.Shown(notice)
     }
 
     fun analyze() {

app/src/test/java/com/kyhsgeekcode/disassembler/ui/tabs/StringSearchInputPolicyTest.kt

@@ -53,4 +53,26 @@ class StringSearchInputPolicyTest {
             )
         )
     }
+
+    @Test
+    fun `buildStringSearchDialogNotice is null for files within the search limit`() {
+        assertEquals(
+            null,
+            buildStringSearchDialogNotice(
+                originalSize = MAX_SEARCHED_STRING_BYTES.toLong(),
+                maxBytes = MAX_SEARCHED_STRING_BYTES
+            )
+        )
+    }
+
+    @Test
+    fun `buildStringSearchDialogNotice warns when only a prefix will be searched`() {
+        assertEquals(
+            "Large file detected. String search will only scan the first 4 bytes of 10 bytes.",
+            buildStringSearchDialogNotice(
+                originalSize = 10,
+                maxBytes = 4
+            )
+        )
+    }
 }