review: address PR feedback

Author: yhs0602

app/build.gradle

@@ -81,6 +81,7 @@ android {
             filters {
                 engines {
                     include 'spek2'
+                    include 'junit-jupiter'
                 }
             }
             jacocoOptions {

app/src/main/java/com/kyhsgeekcode/disassembler/ui/components/HexView.kt

@@ -38,11 +38,12 @@ data class HexRow(
 
 fun buildHexRows(bytes: ByteArray): List<HexRow> {
     return bytes.toList().chunked(BYTES_PER_ROW).mapIndexed { index, chunk ->
-        val paddedHex = chunk.map { "%02X".format(it) } + List(BYTES_PER_ROW - chunk.size) { "" }
+        val paddedHex = chunk.map { "%02X".format(it.toInt() and 0xFF) } +
+            List(BYTES_PER_ROW - chunk.size) { "" }
         val ascii = chunk.map { byte ->
             val charValue = byte.toInt().toChar()
             if (isPrintableChar(charValue)) charValue.toString() else "."
-        }
+        } + List(BYTES_PER_ROW - chunk.size) { "" }
         HexRow(
             offset = index * BYTES_PER_ROW,
             bytes = chunk,

app/src/main/java/com/kyhsgeekcode/disassembler/ui/tabs/BinaryDisasmTab.kt

@@ -209,7 +209,7 @@ fun BinaryDisasmTabContent(
         InfiniteList(onLoadMore = { firstVisibleItemIndex, lastVisibleItemIndex ->
             disasmData.setCurrentAddressByFirstItemIndex(firstVisibleItemIndex)
             disasmData.loadMore(lastVisibleItemIndex)
-        }, modifier = Modifier.fillMaxWidth(), listState = listState) {
+        }, modifier = Modifier.wrapContentWidth(), listState = listState) {
 
             stickyHeader {
                 BinaryDisasmHeader(disasmData)

app/src/main/java/com/kyhsgeekcode/disassembler/viewmodel/MainViewModel.kt

@@ -145,11 +145,12 @@ class MainViewModel(application: Application) : AndroidViewModel(application) {
             try {
                 val app = getApplication<Application>()
                 app.contentResolver.openInputStream(uri).use { inStream ->
+                    requireNotNull(inStream) { "Failed to open content URI: $uri" }
                     val fileName = resolveImportedFileName(app, uri, displayName)
                     val file = app.filesDir.resolve("imports").resolve(fileName)
                     file.parentFile?.mkdirs()
                     file.outputStream().use { fileOut ->
-                        inStream?.copyTo(fileOut)
+                        inStream.copyTo(fileOut)
                     }
                     val project = ProjectManager.newProject(
                         file,

app/src/test/java/com/kyhsgeekcode/disassembler/ui/components/HexViewLayoutTest.kt

@@ -25,15 +25,25 @@ class HexViewLayoutTest {
 
         assertEquals(1, rows.size)
         assertEquals(16, rows[0].paddedHexValues.size)
+        assertEquals(16, rows[0].asciiValues.size)
         assertEquals(listOf("41", "42", "43"), rows[0].paddedHexValues.take(3))
         assertTrue(rows[0].paddedHexValues.drop(3).all { it == "" })
+        assertEquals(listOf("A", "B", "C"), rows[0].asciiValues.take(3))
+        assertTrue(rows[0].asciiValues.drop(3).all { it == "" })
     }
 
     @Test
     fun `ascii cells convert printable bytes and replace control bytes`() {
         val rows = buildHexRows(byteArrayOf(0x41, 0x20, 0x0A, 0x7F))
 
-        assertEquals(listOf("A", " ", ".", "."), rows.single().asciiValues)
+        assertEquals(listOf("A", " ", ".", "."), rows.single().asciiValues.take(4))
+    }
+
+    @Test
+    fun `buildHexRows formats high-bit bytes as two-digit hex`() {
+        val rows = buildHexRows(byteArrayOf(0xEE.toByte(), 0xFF.toByte(), 0x80.toByte()))
+
+        assertEquals(listOf("EE", "FF", "80"), rows.single().paddedHexValues.take(3))
     }
 
     @Test