Avoid signed/unsigned comparison

serge-sans-paille · serge-sans-paille · commit 6846c1568253 · 2020-11-14T10:37:51.000+01:00
diff --git a/include/xtensor/xview.hpp b/include/xtensor/xview.hpp
@@ -230,7 +230,7 @@ namespace xt
         struct is_contiguous_view
             : std::integral_constant<bool,
                 has_data_interface<E>::value &&
-                !(E::static_layout == layout_type::column_major && static_dimension<typename E::shape_type>::value != sizeof...(S)) &&
+                !(E::static_layout == layout_type::column_major && static_cast<std::size_t>(static_dimension<typename E::shape_type>::value) != sizeof...(S)) &&
                 is_contiguous_view_impl<E::static_layout, true, false, false, xtl::mpl::vector<S...>>::value
               >
         {

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,7 @@ namespace xt`
`230`	`230`	`struct is_contiguous_view`
`231`	`231`	`: std::integral_constant<bool,`
`232`	`232`	`has_data_interface<E>::value &&`
`233`		`- !(E::static_layout == layout_type::column_major && static_dimension<typename E::shape_type>::value != sizeof...(S)) &&`
	`233`	`+ !(E::static_layout == layout_type::column_major && static_cast<std::size_t>(static_dimension<typename E::shape_type>::value) != sizeof...(S)) &&`
`234`	`234`	`is_contiguous_view_impl<E::static_layout, true, false, false, xtl::mpl::vector<S...>>::value`
`235`	`235`	`>`
`236`	`236`	`{`