Clean up stale references and unnecessary compatibility code

- Update benchmark scripts to require 'libxml-ruby'
- Remove defined?(::Encoding) guard (always true on Ruby 3.2+)
- Remove stale rdoc excludes for deleted files in Rakefile and docs CI
- Remove ruby_xml_cbg.c references from Xcode project
- Ship Xcode project in gem alongside VC project

Author: cfis

.github/workflows/docs.yml

@@ -47,7 +47,7 @@ jobs:
         run: zensical build --clean
 
       - name: Build API reference
-        run: rdoc --format aliki --output site/reference --title 'LibXML Ruby API' --line-numbers --charset=utf-8 --exclude lib/xml.rb --exclude lib/xml/libxml.rb --main README.md ext/**/libxml.c ext/**/ruby_xml.c ext/**/*.c lib/**/*.rb README.md
+        run: rdoc --format aliki --output site/reference --title 'LibXML Ruby API' --line-numbers --charset=utf-8 --main README.md ext/**/libxml.c ext/**/ruby_xml.c ext/**/*.c lib/**/*.rb README.md
 
       - name: Upload artifact
         uses: actions/upload-pages-artifact@v3

Rakefile

@@ -68,7 +68,6 @@ RDoc::Task.new("rdoc") do |rdoc|
                           'README.md',
                           'CHANGELOG.md',
                           'LICENSE')
-  rdoc.rdoc_files.exclude('lib/xml.rb', 'lib/xml/libxml.rb')
 end
 
 # Test Task

ext/xcode/libxml-ruby.xcodeproj/project.pbxproj

@@ -50,7 +50,6 @@
 		C7F2B5CD2B4B636C004E0A86 /* ruby_xml_attr_decl.c in Sources */ = {isa = PBXBuildFile; fileRef = C7F2B54A2B4B5AED004E0A86 /* ruby_xml_attr_decl.c */; };
 		C7F2B5CE2B4B636C004E0A86 /* ruby_xml_attr.c in Sources */ = {isa = PBXBuildFile; fileRef = C7F2B5212B4B5AEC004E0A86 /* ruby_xml_attr.c */; };
 		C7F2B5CF2B4B636C004E0A86 /* ruby_xml_attributes.c in Sources */ = {isa = PBXBuildFile; fileRef = C7F2B5482B4B5AED004E0A86 /* ruby_xml_attributes.c */; };
-		C7F2B5D02B4B636C004E0A86 /* ruby_xml_cbg.c in Sources */ = {isa = PBXBuildFile; fileRef = C7F2B5382B4B5AED004E0A86 /* ruby_xml_cbg.c */; };
 		C7F2B5D12B4B636C004E0A86 /* ruby_xml_document.c in Sources */ = {isa = PBXBuildFile; fileRef = C7F2B5522B4B5AED004E0A86 /* ruby_xml_document.c */; };
 		C7F2B5D22B4B636C004E0A86 /* ruby_xml_dtd.c in Sources */ = {isa = PBXBuildFile; fileRef = C7F2B5622B4B5AEE004E0A86 /* ruby_xml_dtd.c */; };
 		C7F2B5D32B4B636C004E0A86 /* ruby_xml_encoding.c in Sources */ = {isa = PBXBuildFile; fileRef = C7F2B5362B4B5AED004E0A86 /* ruby_xml_encoding.c */; };
@@ -124,7 +123,6 @@
 		C7F2B5352B4B5AED004E0A86 /* ruby_xml_encoding.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = ruby_xml_encoding.h; path = ../libxml/ruby_xml_encoding.h; sourceTree = "<group>"; };
 		C7F2B5362B4B5AED004E0A86 /* ruby_xml_encoding.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; name = ruby_xml_encoding.c; path = ../libxml/ruby_xml_encoding.c; sourceTree = "<group>"; };
 		C7F2B5372B4B5AED004E0A86 /* ruby_xml_writer.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; name = ruby_xml_writer.c; path = ../libxml/ruby_xml_writer.c; sourceTree = "<group>"; };
-		C7F2B5382B4B5AED004E0A86 /* ruby_xml_cbg.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; name = ruby_xml_cbg.c; path = ../libxml/ruby_xml_cbg.c; sourceTree = "<group>"; };
 		C7F2B5392B4B5AED004E0A86 /* ruby_xml_schema_attribute.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = ruby_xml_schema_attribute.h; path = ../libxml/ruby_xml_schema_attribute.h; sourceTree = "<group>"; };
 		C7F2B53A2B4B5AED004E0A86 /* ruby_xml.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; name = ruby_xml.c; path = ../libxml/ruby_xml.c; sourceTree = "<group>"; };
 		C7F2B53B2B4B5AED004E0A86 /* ruby_xml_namespace.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; name = ruby_xml_namespace.c; path = ../libxml/ruby_xml_namespace.c; sourceTree = "<group>"; };
@@ -203,7 +201,6 @@
 				C7F2B54F2B4B5AED004E0A86 /* ruby_xml_attr.h */,
 				C7F2B5482B4B5AED004E0A86 /* ruby_xml_attributes.c */,
 				C7F2B52E2B4B5AED004E0A86 /* ruby_xml_attributes.h */,
-				C7F2B5382B4B5AED004E0A86 /* ruby_xml_cbg.c */,
 				C7F2B5522B4B5AED004E0A86 /* ruby_xml_document.c */,
 				C7F2B5602B4B5AEE004E0A86 /* ruby_xml_document.h */,
 				C7F2B5622B4B5AEE004E0A86 /* ruby_xml_dtd.c */,
@@ -409,7 +406,6 @@
 				C7F2B5CD2B4B636C004E0A86 /* ruby_xml_attr_decl.c in Sources */,
 				C7F2B5CE2B4B636C004E0A86 /* ruby_xml_attr.c in Sources */,
 				C7F2B5CF2B4B636C004E0A86 /* ruby_xml_attributes.c in Sources */,
-				C7F2B5D02B4B636C004E0A86 /* ruby_xml_cbg.c in Sources */,
 				C7F2B5D12B4B636C004E0A86 /* ruby_xml_document.c in Sources */,
 				C7F2B5D22B4B636C004E0A86 /* ruby_xml_dtd.c in Sources */,
 				C7F2B5D32B4B636C004E0A86 /* ruby_xml_encoding.c in Sources */,

lib/libxml/node.rb

@@ -313,9 +313,7 @@ def xinclude_start?
 
       def create_string_io(xml)
         result = StringIO.new("")
-        if defined?(::Encoding)
-          result.set_encoding(xml.encoding)
-        end
+        result.set_encoding(xml.encoding)
         result
       end
     end

libxml-ruby.gemspec

@@ -31,6 +31,7 @@ Gem::Specification.new do |spec|
                          'ext/libxml/*.rb',
                          'ext/vc/*.sln',
                          'ext/vc/*.vcprojx',
+                         'ext/xcode/**/*',
                          'lib/**/*.rb',
                          'script/**/*',
                          'test/**/*'])

script/benchmark/depixelate

@@ -4,7 +4,7 @@ require 'rubygems'
 require 'benchmark'
 require 'hpricot'
 require 'rexml/document'
-require 'xml'
+require 'libxml-ruby'
 
 
 # Taken from http://depixelate.com/2008/4/23/ruby-xml-parsing-benchmarks

script/benchmark/parsecount

@@ -87,7 +87,7 @@ if RUBY_PLATFORM =~ /java/
     require 'nokogiri'
 
     gem 'libxml-ruby', '>= 0.9.2'
-    require 'libxml'
+    require 'libxml-ruby'
     @xml_parser = LibXML::XML::Parser.new
 end
 

script/benchmark/throughput

@@ -2,7 +2,7 @@
 
 require 'rubygems'
 require 'hpricot'
-require 'xml'
+require 'libxml-ruby'
 require 'rexml/document'
 
 ITERATIONS = 3