Fix some newly reported PHPStan issues

Author: swissspidy

phpcs.xml.dist

@@ -18,7 +18,7 @@
 	<exclude-pattern>*/src/WP_CLI/JsonManipulator\.php$</exclude-pattern>
 	<exclude-pattern>*/src/WP_CLI/Package/Compat/Min_Composer_1_10/NullIOMethodsTrait\.php$</exclude-pattern>
 	<exclude-pattern>*/src/WP_CLI/Package/Compat/Min_Composer_2_3/NullIOMethodsTrait\.php$</exclude-pattern>
-	<exclude-pattern>*/tests/JsonManipulatorTest\.php$</exclude-pattern>
+	<exclude-pattern>*/tests/phpunit/JsonManipulatorTest\.php$</exclude-pattern>
 
 	<!-- Show progress. -->
 	<arg value="p"/>
@@ -63,4 +63,5 @@
 		<exclude-pattern>*/src/Package_Command\.php$</exclude-pattern>
 	</rule>
 
+	<exclude-pattern>/tests/phpstan/scan-files</exclude-pattern>
 </ruleset>

phpstan.neon.dist

@@ -7,6 +7,7 @@ parameters:
     - vendor/wp-cli/wp-cli/php
   scanFiles:
     - vendor/php-stubs/wordpress-stubs/wordpress-stubs.php
+    - tests/phpstan/scan-files.php
   treatPhpDocTypesAsCertain: false
   ignoreErrors:
     # WP_CLI_VERSION is defined in wp-cli core at runtime

phpunit.xml.dist

@@ -13,7 +13,7 @@
 		 colors="true"
 		 verbose="true">
 	<testsuite name="wp-cli/package-command tests">
-		<directory suffix="Test.php">tests</directory>
+		<directory suffix="Test.php">tests/phpunit</directory>
 	</testsuite>
 
 	<filter>

src/Package_Command.php

@@ -822,8 +822,8 @@ private function package_index() {
 	 * Displays a set of packages
 	 *
 	 * @param string $context
-	 * @param array
-	 * @param array
+	 * @param array $packages
+	 * @param array $assoc_args
 	 */
 	private function show_packages( $context, $packages, $assoc_args ) {
 		$default_fields = [];
@@ -1130,8 +1130,8 @@ private function create_default_composer_json( $composer_path ) {
 	 *
 	 * @param  PackageInterface $package
 	 * @param  Composer         $composer
-	 * @param  string           $phpVersion
-	 * @param  bool             $minorOnly
+	 * @param  string           $php_version
+	 * @param  bool             $minor_only
 	 *
 	 * @return PackageInterface|null
 	 */

tests/phpstan/scan-files.php

@@ -0,0 +1,101 @@
+<?php
+
+namespace {
+	class Requests_Exception extends WpOrg\Requests\Exception {
+	}
+
+	class Requests_Response extends WpOrg\Requests\Response {
+	}
+}
+
+namespace WpOrg\Requests {
+	class Exception extends \Exception {
+		/**
+		 * Like {@see \Exception::getCode()}, but a string code.
+		 *
+		 * @return string
+		 */
+		public function getType() {
+		}
+
+		/**
+		 * Gives any relevant data
+		 *
+		 * @return mixed
+		 */
+		public function getData() {
+		}
+	}
+
+	class Response {
+		/**
+		 * Response body
+		 *
+		 * @var string
+		 */
+		public $body = '';
+
+		/**
+		 * Raw HTTP data from the transport
+		 *
+		 * @var string
+		 */
+		public $raw = '';
+
+		/**
+		 * Headers, as an associative array
+		 *
+		 * @var \WpOrg\Requests\Response\Headers Array-like object representing headers
+		 */
+		public $headers = [];
+
+		/**
+		 * Status code, false if non-blocking
+		 *
+		 * @var integer|boolean
+		 */
+		public $status_code = false;
+
+		/**
+		 * Protocol version, false if non-blocking
+		 *
+		 * @var float|boolean
+		 */
+		public $protocol_version = false;
+
+		/**
+		 * Whether the request succeeded or not
+		 *
+		 * @var boolean
+		 */
+		public $success = false;
+
+		/**
+		 * Number of redirects the request used
+		 *
+		 * @var integer
+		 */
+		public $redirects = 0;
+
+		/**
+		 * URL requested
+		 *
+		 * @var string
+		 */
+		public $url = '';
+
+		/**
+		 * Previous requests (from redirects)
+		 *
+		 * @var array Array of \WpOrg\Requests\Response objects
+		 */
+		public $history = [];
+
+		/**
+		 * Cookies from the request
+		 *
+		 * @var array Array-like object representing a cookie jar
+		 */
+		public $cookies = [];
+	}
+}