Skip to content

Commit c17217c

Browse files
committed
add null check in test_wolfSSL_X509_CRL_sign_large()
init revoked
1 parent 00c773e commit c17217c

1 file changed

Lines changed: 11 additions & 7 deletions

File tree

tests/api.c

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21141,7 +21141,7 @@ static int test_wolfSSL_X509_CRL_sign_large(void)
2114121141
WOLFSSL_X509_CRL* crl = NULL;
2114221142
WOLFSSL_EVP_PKEY* pkey = NULL;
2114321143
WOLFSSL_ASN1_TIME asnTime;
21144-
WOLFSSL_X509_REVOKED revoked;
21144+
WOLFSSL_X509_REVOKED revoked = {0};
2114521145
XFILE fp = XBADFILE;
2114621146
int i;
2114721147
byte serial[4];
@@ -21166,9 +21166,11 @@ static int test_wolfSSL_X509_CRL_sign_large(void)
2116621166
ExpectIntEQ(wolfSSL_X509_CRL_set_nextUpdate(crl, &asnTime),
2116721167
WOLFSSL_SUCCESS);
2116821168

21169-
revoked.serialNumber = wolfSSL_ASN1_INTEGER_new();
21170-
revoked.serialNumber->data = serial;
21171-
revoked.serialNumber->length = (int)sizeof(serial);
21169+
ExpectNotNull(revoked.serialNumber = wolfSSL_ASN1_INTEGER_new());
21170+
if (revoked.serialNumber != NULL) {
21171+
revoked.serialNumber->data = serial;
21172+
revoked.serialNumber->length = (int)sizeof(serial);
21173+
}
2117221174

2117321175
for (i = 1; i <= 1024; i++) {
2117421176
serial[0] = (byte)(i & 0xff);
@@ -21189,9 +21191,11 @@ static int test_wolfSSL_X509_CRL_sign_large(void)
2118921191
ExpectIntEQ(wolfSSL_X509_CRL_sign(crl, pkey, wolfSSL_EVP_sha256()),
2119021192
WOLFSSL_SUCCESS);
2119121193

21192-
revoked.serialNumber->data = NULL;
21193-
wolfSSL_ASN1_INTEGER_free(revoked.serialNumber);
21194-
revoked.serialNumber = NULL;
21194+
if (revoked.serialNumber != NULL) {
21195+
revoked.serialNumber->data = NULL;
21196+
wolfSSL_ASN1_INTEGER_free(revoked.serialNumber);
21197+
revoked.serialNumber = NULL;
21198+
}
2119521199

2119621200
wolfSSL_EVP_PKEY_free(pkey);
2119721201
wolfSSL_X509_CRL_free(crl);

0 commit comments

Comments
 (0)