Skip to content

Commit 9b2f7a3

Browse files
committed
remove duplicate keylen check (deadcode)
wrap if statement in macro guard
1 parent 78f2e65 commit 9b2f7a3

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

wolfcrypt/src/aes.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4777,18 +4777,17 @@ static void AesSetKey_C(Aes* aes, const byte* key, word32 keySz, int dir)
47774777
}
47784778
#endif
47794779

4780+
#if defined(AES_MAX_KEY_SIZE) && AES_MAX_KEY_SIZE < 256
47804781
if (checkKeyLen) {
4781-
if (keylen != 16 && keylen != 24 && keylen != 32) {
4782-
return BAD_FUNC_ARG;
4783-
}
4784-
#if defined(AES_MAX_KEY_SIZE) && AES_MAX_KEY_SIZE < 256
47854782
/* Check key length only when AES_MAX_KEY_SIZE doesn't allow
47864783
* all key sizes. Otherwise this condition is never true. */
47874784
if (keylen > (AES_MAX_KEY_SIZE / 8)) {
47884785
return BAD_FUNC_ARG;
47894786
}
4790-
#endif
47914787
}
4788+
#else
4789+
(void) checkKeyLen;
4790+
#endif
47924791

47934792
#if defined(WOLFSSL_AES_COUNTER) || defined(WOLFSSL_AES_CFB) || \
47944793
defined(WOLFSSL_AES_OFB) || defined(WOLFSSL_AES_XTS) || \

0 commit comments

Comments
 (0)