Skip to content

Commit 8d1b825

Browse files
committed
configure.ac:
* add --enable-wolfentropy as a synonym for --enable-wolfEntropy; * avoid -Wno-deprecated-enum-enum-conversion when KERNEL_MODE_DEFAULTS, to work around old gcc with broken results from AX_CHECK_COMPILE_FLAG(); * rework help messages for several synonym options to refer to the canonical option (--enable-linuxkm-pie, --enable-kyber, --enable-dilithium, --enable-amdrand, --enable-entropy-memues).
1 parent 4a51ed4 commit 8d1b825

1 file changed

Lines changed: 19 additions & 12 deletions

File tree

configure.ac

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -754,14 +754,14 @@ AC_ARG_ENABLE([benchmark],
754754

755755
ENABLED_LINUXKM_PIE=$ENABLED_FIPS
756756

757-
AC_ARG_ENABLE([linuxkm-pie],
758-
[AS_HELP_STRING([--enable-linuxkm-pie],[Enable relocatable object build of Linux kernel module (default: disabled)])],
759-
[ENABLED_LINUXKM_PIE=$enableval])
760-
761757
AC_ARG_ENABLE([kernel-reloc-tables],
762758
[AS_HELP_STRING([--enable-kernel-reloc-tables],[Enable containerized object build of wolfCrypt module in kernel build (default: disabled)])],
763759
[ENABLED_LINUXKM_PIE=$enableval])
764760

761+
AC_ARG_ENABLE([linuxkm-pie],
762+
[AS_HELP_STRING([--enable-linuxkm-pie],[Alias for --enable-kernel-reloc-tables])],
763+
[ENABLED_LINUXKM_PIE=$enableval])
764+
765765
if test "$ENABLED_LINUXKM" = "yes" && test "$ENABLED_LINUXKM_PIE" = "yes"
766766
then
767767
AM_CFLAGS="$AM_CFLAGS -DWC_SYM_RELOC_TABLES"
@@ -1701,13 +1701,13 @@ AC_ARG_WITH([liboqs],
17011701
# Used:
17021702
# - SHA3, Shake128 and Shake256
17031703
AC_ARG_ENABLE([mlkem],
1704-
[AS_HELP_STRING([--enable-mlkem],[Enable MLKEM (default: disabled)])],
1704+
[AS_HELP_STRING([--enable-mlkem],[Enable ML-KEM/Kyber (default: disabled)])],
17051705
[ ENABLED_MLKEM=$enableval ],
17061706
[ ENABLED_MLKEM=no ]
17071707
)
17081708
# note, inherits default from "mlkem" clause above.
17091709
AC_ARG_ENABLE([kyber],
1710-
[AS_HELP_STRING([--enable-kyber],[Enable Kyber/MLKEM (default: disabled)])],
1710+
[AS_HELP_STRING([--enable-kyber],[Alias for --enable-mlkem])],
17111711
[ ENABLED_MLKEM=$enableval ]
17121712
)
17131713

@@ -1837,13 +1837,13 @@ fi
18371837
# Dilithium
18381838
# - SHA3, Shake128, Shake256 and AES-CTR
18391839
AC_ARG_ENABLE([mldsa],
1840-
[AS_HELP_STRING([--enable-mldsa],[Enable MLDSA (default: disabled)])],
1840+
[AS_HELP_STRING([--enable-mldsa],[Enable ML-DSA/Dilithium (default: disabled)])],
18411841
[ ENABLED_DILITHIUM=$enableval ],
18421842
[ ENABLED_DILITHIUM=no ]
18431843
)
18441844
# note, inherits default from "mldsa" clause above.
18451845
AC_ARG_ENABLE([dilithium],
1846-
[AS_HELP_STRING([--enable-dilithium],[Enable Dilithium/MLDSA (default: disabled)])],
1846+
[AS_HELP_STRING([--enable-dilithium],[Alias for --enable-mldsa])],
18471847
[ ENABLED_DILITHIUM=$enableval ]
18481848
)
18491849

@@ -4107,7 +4107,7 @@ AC_ARG_ENABLE([amdrdseed],
41074107
)
41084108

41094109
AC_ARG_ENABLE([amdrand],
4110-
[AS_HELP_STRING([--enable-amdrand],[Enable AMD rdseed as preferred RNG seeding source (default: disabled)])],
4110+
[AS_HELP_STRING([--enable-amdrand],[Alias for --enable-amdrdseed])],
41114111
[ ENABLED_AMDRDSEED=$enableval ]
41124112
)
41134113

@@ -6016,8 +6016,12 @@ AC_ARG_ENABLE([wolfEntropy],
60166016
[ ENABLED_ENTROPY_MEMUSE=$enableval ],
60176017
[ ENABLED_ENTROPY_MEMUSE=$ENABLED_ENTROPY_MEMUSE_DEFAULT ]
60186018
)
6019+
AC_ARG_ENABLE([wolfentropy],
6020+
[AS_HELP_STRING([--enable-wolfentropy],[Alias for --enable-wolfEntropy])],
6021+
[ ENABLED_ENTROPY_MEMUSE=$enableval ],
6022+
)
60196023
AC_ARG_ENABLE([entropy-memuse],
6020-
[AS_HELP_STRING([--enable-entropy-memuse],[Enable memuse entropy support (default: disabled)])],
6024+
[AS_HELP_STRING([--enable-entropy-memuse],[Alias for --enable-wolfEntropy])],
60216025
[ ENABLED_ENTROPY_MEMUSE=$enableval ]
60226026
)
60236027

@@ -11046,8 +11050,11 @@ AX_HARDEN_CC_COMPILER_FLAGS
1104611050
1104711051
# -Wdeprecated-enum-enum-conversion is on by default in C++20, but conflicts with
1104811052
# our use of enum constructs to define fungible constants.
11049-
AX_CHECK_COMPILE_FLAG([-Werror -Wno-deprecated-enum-enum-conversion],
11050-
[AX_APPEND_FLAG([-Wno-deprecated-enum-enum-conversion], [AM_CFLAGS])])
11053+
if test "$KERNEL_MODE_DEFAULTS" != "yes"
11054+
then
11055+
AX_CHECK_COMPILE_FLAG([-Werror -Wno-deprecated-enum-enum-conversion],
11056+
[AX_APPEND_FLAG([-Wno-deprecated-enum-enum-conversion], [AM_CFLAGS])])
11057+
fi
1105111058
1105211059
case $host_os in
1105311060
mingw*)

0 commit comments

Comments
 (0)