Fix null check in ECDSA encode

padelsbach · padelsbach · commit 70fa2c4e2a35 · 2026-02-13T12:07:19.000-08:00
diff --git a/src/pk_ec.c b/src/pk_ec.c
@@ -5019,7 +5019,7 @@ int wolfSSL_i2d_ECDSA_SIG(const WOLFSSL_ECDSA_SIG *sig, unsigned char **pp)
         #ifdef WOLFSSL_I2D_ECDSA_SIG_ALLOC
         if ((pp != NULL) && (*pp == NULL)) {
             *pp = (unsigned char *)XMALLOC(len, NULL, DYNAMIC_TYPE_OPENSSL);
-            if (*pp != NULL) {
+            if (*pp == NULL) {
                 WOLFSSL_MSG("malloc error");
                 return 0;
             }

Original file line number	Diff line number	Diff line change
`@@ -5019,7 +5019,7 @@ int wolfSSL_i2d_ECDSA_SIG(const WOLFSSL_ECDSA_SIG sig, unsigned char *pp)`
`5019`	`5019`	`#ifdef WOLFSSL_I2D_ECDSA_SIG_ALLOC`
`5020`	`5020`	`if ((pp != NULL) && (*pp == NULL)) {`
`5021`	`5021`	`pp = (unsigned char )XMALLOC(len, NULL, DYNAMIC_TYPE_OPENSSL);`
`5022`		`- if (*pp != NULL) {`
	`5022`	`+ if (*pp == NULL) {`
`5023`	`5023`	`WOLFSSL_MSG("malloc error");`
`5024`	`5024`	`return 0;`
`5025`	`5025`	`}`