fix DH privkey leak and zero buffer

JeremiahM37 · JeremiahM37 · commit 6f710aa8f709 · 2026-03-26T17:30:14.000Z
diff --git a/wolfcrypt/src/port/kcapi/kcapi_dh.c b/wolfcrypt/src/port/kcapi/kcapi_dh.c
@@ -127,7 +127,10 @@ static int KcapiDh_SetPrivKey(DhKey* key)
         }
     }
 
-    XFREE(priv, key->heap, DYNAMIC_TYPE_TMP_BUFFER);
+    if (priv != NULL) {
+        ForceZero(priv, len);
+        XFREE(priv, key->heap, DYNAMIC_TYPE_TMP_BUFFER);
+    }
     return ret;
 }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,10 @@ static int KcapiDh_SetPrivKey(DhKey* key)`
`127`	`127`	`}`
`128`	`128`	`}`
`129`	`129`
`130`		`- XFREE(priv, key->heap, DYNAMIC_TYPE_TMP_BUFFER);`
	`130`	`+ if (priv != NULL) {`
	`131`	`+ ForceZero(priv, len);`
	`132`	`+ XFREE(priv, key->heap, DYNAMIC_TYPE_TMP_BUFFER);`
	`133`	`+ }`
`131`	`134`	`return ret;`
`132`	`135`	`}`
`133`	`136`	`#endif`