Skip to content

Commit 6090ddb

Browse files
committed
initialize hmac_copy
add WC_CALLOC_VAR_EX function, replace WC_ALLOC_VAR_EX in tests
1 parent eab58ae commit 6090ddb

2 files changed

Lines changed: 16 additions & 7 deletions

File tree

wolfcrypt/test/test.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7442,7 +7442,7 @@ WOLFSSL_TEST_SUBROUTINE wc_test_ret_t hmac_md5_test(void)
74427442

74437443
XMEMSET(&hmac, 0, sizeof(hmac));
74447444
#if !defined(HAVE_SELFTEST) && (!defined(HAVE_FIPS) || FIPS_VERSION3_GT(7,0,0))
7445-
WC_ALLOC_VAR_EX(hmac_copy, Hmac, 1, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER,
7445+
WC_CALLOC_VAR_EX(hmac_copy, Hmac, 1, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER,
74467446
return WC_TEST_RET_ENC_EC(MEMORY_E));
74477447
#endif
74487448

@@ -7587,7 +7587,7 @@ WOLFSSL_TEST_SUBROUTINE wc_test_ret_t hmac_sha_test(void)
75877587

75887588
XMEMSET(&hmac, 0, sizeof(hmac));
75897589
#if !defined(HAVE_SELFTEST) && (!defined(HAVE_FIPS) || FIPS_VERSION3_GT(7,0,0))
7590-
WC_ALLOC_VAR_EX(hmac_copy, Hmac, 1, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER,
7590+
WC_CALLOC_VAR_EX(hmac_copy, Hmac, 1, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER,
75917591
return WC_TEST_RET_ENC_EC(MEMORY_E));
75927592
#endif
75937593

@@ -7738,7 +7738,7 @@ WOLFSSL_TEST_SUBROUTINE wc_test_ret_t hmac_sha224_test(void)
77387738

77397739
XMEMSET(&hmac, 0, sizeof(hmac));
77407740
#if !defined(HAVE_SELFTEST) && (!defined(HAVE_FIPS) || FIPS_VERSION3_GT(7,0,0))
7741-
WC_ALLOC_VAR_EX(hmac_copy, Hmac, 1, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER,
7741+
WC_CALLOC_VAR_EX(hmac_copy, Hmac, 1, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER,
77427742
return WC_TEST_RET_ENC_EC(MEMORY_E));
77437743
#endif
77447744

@@ -7895,7 +7895,7 @@ WOLFSSL_TEST_SUBROUTINE wc_test_ret_t hmac_sha256_test(void)
78957895

78967896
XMEMSET(&hmac, 0, sizeof(hmac));
78977897
#if !defined(HAVE_SELFTEST) && (!defined(HAVE_FIPS) || FIPS_VERSION3_GT(7,0,0))
7898-
WC_ALLOC_VAR_EX(hmac_copy, Hmac, 1, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER,
7898+
WC_CALLOC_VAR_EX(hmac_copy, Hmac, 1, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER,
78997899
return WC_TEST_RET_ENC_EC(MEMORY_E));
79007900
#endif
79017901

@@ -8061,7 +8061,7 @@ WOLFSSL_TEST_SUBROUTINE wc_test_ret_t hmac_sha384_test(void)
80618061

80628062
XMEMSET(&hmac, 0, sizeof(hmac));
80638063
#if !defined(HAVE_SELFTEST) && (!defined(HAVE_FIPS) || FIPS_VERSION3_GT(7,0,0))
8064-
WC_ALLOC_VAR_EX(hmac_copy, Hmac, 1, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER,
8064+
WC_CALLOC_VAR_EX(hmac_copy, Hmac, 1, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER,
80658065
return WC_TEST_RET_ENC_EC(MEMORY_E));
80668066
#endif
80678067

@@ -8216,7 +8216,7 @@ WOLFSSL_TEST_SUBROUTINE wc_test_ret_t hmac_sha512_test(void)
82168216

82178217
XMEMSET(&hmac, 0, sizeof(hmac));
82188218
#if !defined(HAVE_SELFTEST) && (!defined(HAVE_FIPS) || FIPS_VERSION3_GT(7,0,0))
8219-
WC_ALLOC_VAR_EX(hmac_copy, Hmac, 1, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER,
8219+
WC_CALLOC_VAR_EX(hmac_copy, Hmac, 1, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER,
82208220
return WC_TEST_RET_ENC_EC(MEMORY_E));
82218221
#endif
82228222

@@ -8428,7 +8428,7 @@ WOLFSSL_TEST_SUBROUTINE wc_test_ret_t hmac_sha3_test(void)
84288428

84298429
XMEMSET(&hmac, 0, sizeof(hmac));
84308430
#if !defined(HAVE_SELFTEST) && (!defined(HAVE_FIPS) || FIPS_VERSION3_GT(7,0,0))
8431-
WC_ALLOC_VAR_EX(hmac_copy, Hmac, 1, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER,
8431+
WC_CALLOC_VAR_EX(hmac_copy, Hmac, 1, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER,
84328432
return WC_TEST_RET_ENC_EC(MEMORY_E));
84338433
#endif
84348434

wolfssl/wolfcrypt/types.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -876,6 +876,13 @@ enum {
876876
ONFAIL; \
877877
} \
878878
} while (0)
879+
#define WC_CALLOC_VAR_EX(VAR_NAME, VAR_TYPE, VAR_SIZE, HEAP, TY, ONFAIL)\
880+
do { \
881+
WC_ALLOC_VAR_EX(VAR_NAME, VAR_TYPE, VAR_SIZE, HEAP, TY, ONFAIL);\
882+
if ((VAR_NAME) != NULL) { \
883+
XMEMSET(VAR_NAME, 0, sizeof(VAR_TYPE) * (VAR_SIZE)); \
884+
} \
885+
} while (0)
879886
#define WC_CALLOC_VAR(VAR_NAME, VAR_TYPE, VAR_SIZE, HEAP) \
880887
do { \
881888
WC_ALLOC_VAR(VAR_NAME, VAR_TYPE, VAR_SIZE, HEAP); \
@@ -906,6 +913,8 @@ enum {
906913
#define WC_VAR_OK(VAR_NAME) 1
907914
#define WC_CALLOC_VAR(VAR_NAME, VAR_TYPE, VAR_SIZE, HEAP) \
908915
XMEMSET(VAR_NAME, 0, sizeof(var))
916+
#define WC_CALLOC_VAR_EX(VAR_NAME, VAR_TYPE, VAR_SIZE, HEAP, TY, ONFAIL)\
917+
WC_DO_NOTHING
909918
#define WC_FREE_VAR(VAR_NAME, HEAP) WC_DO_NOTHING \
910919
/* nothing to free, its stack */
911920
#define WC_FREE_VAR_EX(VAR_NAME, HEAP, TYPE) WC_DO_NOTHING

0 commit comments

Comments
 (0)