Make sure only free'd on error

julek-wolfssl · julek-wolfssl · commit 3c06c2231429 · 2026-03-06T18:01:02.000+01:00
diff --git a/src/ssl_asn1.c b/src/ssl_asn1.c
@@ -428,7 +428,7 @@ int wolfSSL_ASN1_item_i2d(const void* obj, byte** dest,
             else
                 *dest += len;
         }
-        if (*dest == NULL)
+        if (ret == 0 && *dest == NULL)
             XFREE(buf, NULL, DYNAMIC_TYPE_ASN1);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -428,7 +428,7 @@ int wolfSSL_ASN1_item_i2d(const void* obj, byte** dest,`
`428`	`428`	`else`
`429`	`429`	`*dest += len;`
`430`	`430`	`}`
`431`		`- if (*dest == NULL)`
	`431`	`+ if (ret == 0 && *dest == NULL)`
`432`	`432`	`XFREE(buf, NULL, DYNAMIC_TYPE_ASN1);`
`433`	`433`	`}`
`434`	`434`