Skip to content

Commit 3893fd3

Browse files
committed
Fix feedback from review
1 parent 772cda3 commit 3893fd3

1 file changed

Lines changed: 15 additions & 1 deletion

File tree

tests/api/test_x509.c

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -643,16 +643,27 @@ int test_x509_CertFromX509_akid_overflow(void)
643643
{
644644
EXPECT_DECLS;
645645
#if defined(WOLFSSL_AKID_NAME) && defined(WOLFSSL_CERT_GEN) && \
646-
defined(WOLFSSL_CERT_EXT) && \
646+
defined(WOLFSSL_CERT_EXT) && !defined(NO_BIO) && \
647647
(defined(OPENSSL_EXTRA) || defined(OPENSSL_ALL))
648648
/* DER builder helpers -- write into a flat buffer */
649+
#ifdef WOLFSSL_SMALL_STACK
650+
unsigned char* buf = NULL;
651+
#else
649652
unsigned char buf[16384];
653+
#endif
650654
size_t pos = 0;
651655
size_t akid_val_len;
652656
unsigned char* akid_val = NULL;
653657
WOLFSSL_X509* x = NULL;
654658
WOLFSSL_BIO* bio = NULL;
655659

660+
#ifdef WOLFSSL_SMALL_STACK
661+
buf = (unsigned char*)XMALLOC(16384, NULL, DYNAMIC_TYPE_TMP_BUFFER);
662+
ExpectNotNull(buf);
663+
if (buf == NULL)
664+
return EXPECT_RESULT();
665+
#endif
666+
656667
#define PUT1(b) do { buf[pos++] = (b); } while(0)
657668
#define PUTN(p, n) do { XMEMCPY(buf + pos, (p), (n)); pos += (n); } while(0)
658669

@@ -840,6 +851,9 @@ int test_x509_CertFromX509_akid_overflow(void)
840851
wolfSSL_BIO_free(bio);
841852
wolfSSL_X509_free(x);
842853
XFREE(akid_val, NULL, DYNAMIC_TYPE_TMP_BUFFER);
854+
#ifdef WOLFSSL_SMALL_STACK
855+
XFREE(buf, NULL, DYNAMIC_TYPE_TMP_BUFFER);
856+
#endif
843857

844858
#undef PUT1
845859
#undef PUTN

0 commit comments

Comments
 (0)