Fix leak in PKCS7 RSA-OAEP

LinuxJedi · LinuxJedi · commit 17680a235937 · 2026-02-19T11:42:21.000Z
diff --git a/wolfcrypt/src/pkcs7.c b/wolfcrypt/src/pkcs7.c
@@ -10494,7 +10494,7 @@ static int wc_PKCS7_DecryptKtri(wc_PKCS7* pkcs7, byte* in, word32 inSz,
                     DYNAMIC_TYPE_TMP_BUFFER);
         #ifndef WC_NO_RSA_OAEP
                 if (encOID == RSAESOAEPk) {
-                    if (!outKey) {
+                    if (outKey) {
                         XFREE(outKey, pkcs7->heap, DYNAMIC_TYPE_TMP_BUFFER);
                     }
                 }
@@ -10510,7 +10510,7 @@ static int wc_PKCS7_DecryptKtri(wc_PKCS7* pkcs7, byte* in, word32 inSz,
             WC_FREE_VAR_EX(privKey, pkcs7->heap, DYNAMIC_TYPE_TMP_BUFFER);
         #ifndef WC_NO_RSA_OAEP
             if (encOID == RSAESOAEPk) {
-                if (!outKey) {
+                if (outKey) {
                     XFREE(outKey, pkcs7->heap, DYNAMIC_TYPE_TMP_BUFFER);
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -10494,7 +10494,7 @@ static int wc_PKCS7_DecryptKtri(wc_PKCS7* pkcs7, byte* in, word32 inSz,`
`10494`	`10494`	`DYNAMIC_TYPE_TMP_BUFFER);`
`10495`	`10495`	`#ifndef WC_NO_RSA_OAEP`
`10496`	`10496`	`if (encOID == RSAESOAEPk) {`
`10497`		`- if (!outKey) {`
	`10497`	`+ if (outKey) {`
`10498`	`10498`	`XFREE(outKey, pkcs7->heap, DYNAMIC_TYPE_TMP_BUFFER);`
`10499`	`10499`	`}`
`10500`	`10500`	`}`
`@@ -10510,7 +10510,7 @@ static int wc_PKCS7_DecryptKtri(wc_PKCS7* pkcs7, byte* in, word32 inSz,`
`10510`	`10510`	`WC_FREE_VAR_EX(privKey, pkcs7->heap, DYNAMIC_TYPE_TMP_BUFFER);`
`10511`	`10511`	`#ifndef WC_NO_RSA_OAEP`
`10512`	`10512`	`if (encOID == RSAESOAEPk) {`
`10513`		`- if (!outKey) {`
	`10513`	`+ if (outKey) {`
`10514`	`10514`	`XFREE(outKey, pkcs7->heap, DYNAMIC_TYPE_TMP_BUFFER);`
`10515`	`10515`	`}`
`10516`	`10516`	`}`