Skip to content

Commit 15dbd61

Browse files
committed
Remove dead code
`ticket->lifetime` is never set to 0xfffffff anywhere F-430
1 parent 7a26416 commit 15dbd61

1 file changed

Lines changed: 0 additions & 21 deletions

File tree

src/tls.c

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -6173,24 +6173,6 @@ int TLSX_AddEmptyRenegotiationInfo(TLSX** extensions, void* heap)
61736173

61746174
#ifdef HAVE_SESSION_TICKET
61756175

6176-
#if defined(WOLFSSL_TLS13) || !defined(NO_WOLFSSL_CLIENT)
6177-
static void TLSX_SessionTicket_ValidateRequest(WOLFSSL* ssl)
6178-
{
6179-
TLSX* extension = TLSX_Find(ssl->extensions, TLSX_SESSION_TICKET);
6180-
SessionTicket* ticket = extension ?
6181-
(SessionTicket*)extension->data : NULL;
6182-
6183-
if (ticket) {
6184-
/* TODO validate ticket timeout here! */
6185-
if (ticket->lifetime == 0xfffffff) {
6186-
/* send empty ticket on timeout */
6187-
TLSX_UseSessionTicket(&ssl->extensions, NULL, ssl->heap);
6188-
}
6189-
}
6190-
}
6191-
#endif /* WOLFSSL_TLS13 || !NO_WOLFSSL_CLIENT */
6192-
6193-
61946176
static word16 TLSX_SessionTicket_GetSize(SessionTicket* ticket, int isRequest)
61956177
{
61966178
(void)isRequest;
@@ -6369,7 +6351,6 @@ int TLSX_UseSessionTicket(TLSX** extensions, SessionTicket* ticket, void* heap)
63696351
return WOLFSSL_SUCCESS;
63706352
}
63716353

6372-
#define WOLF_STK_VALIDATE_REQUEST TLSX_SessionTicket_ValidateRequest
63736354
#define WOLF_STK_GET_SIZE TLSX_SessionTicket_GetSize
63746355
#define WOLF_STK_WRITE TLSX_SessionTicket_Write
63756356
#define WOLF_STK_PARSE TLSX_SessionTicket_Parse
@@ -15402,7 +15383,6 @@ int TLSX_GetRequestSize(WOLFSSL* ssl, byte msgType, word32* pLength)
1540215383
if (msgType == client_hello) {
1540315384
EC_VALIDATE_REQUEST(ssl, semaphore);
1540415385
PF_VALIDATE_REQUEST(ssl, semaphore);
15405-
WOLF_STK_VALIDATE_REQUEST(ssl);
1540615386
#if !defined(NO_CERTS) && !defined(WOLFSSL_NO_SIGALG)
1540715387
if (WOLFSSL_SUITES(ssl)->hashSigAlgoSz == 0)
1540815388
TURN_ON(semaphore, TLSX_ToSemaphore(TLSX_SIGNATURE_ALGORITHMS));
@@ -15579,7 +15559,6 @@ int TLSX_WriteRequest(WOLFSSL* ssl, byte* output, byte msgType, word32* pOffset)
1557915559
if (msgType == client_hello) {
1558015560
EC_VALIDATE_REQUEST(ssl, semaphore);
1558115561
PF_VALIDATE_REQUEST(ssl, semaphore);
15582-
WOLF_STK_VALIDATE_REQUEST(ssl);
1558315562
#if !defined(NO_CERTS) && !defined(WOLFSSL_NO_SIGALG)
1558415563
if (WOLFSSL_SUITES(ssl)->hashSigAlgoSz == 0)
1558515564
TURN_ON(semaphore, TLSX_ToSemaphore(TLSX_SIGNATURE_ALGORITHMS));

0 commit comments

Comments
 (0)