Code review feedback

kareem-wolfssl · kareem-wolfssl · commit 0b2679116848 · 2026-03-13T15:57:18.000-07:00
diff --git a/wolfcrypt/src/port/ti/ti-hash.c b/wolfcrypt/src/port/ti/ti-hash.c
@@ -87,7 +87,8 @@ static int hashUpdate(wolfssl_TI_Hash *hash, const byte* data, word32 len)
         } else {
             p = XREALLOC(hash->msg, usedSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);
         }
-        if (p == 0)return 1;
+        if (p == 0)
+            return MEMORY_E;
         hash->msg = p;
         hash->len = usedSz;
     }

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,8 @@ static int hashUpdate(wolfssl_TI_Hash hash, const byte data, word32 len)`
`87`	`87`	`} else {`
`88`	`88`	`p = XREALLOC(hash->msg, usedSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);`
`89`	`89`	`}`
`90`		`- if (p == 0)return 1;`
	`90`	`+ if (p == 0)`
	`91`	`+ return MEMORY_E;`
`91`	`92`	`hash->msg = p;`
`92`	`93`	`hash->len = usedSz;`
`93`	`94`	`}`