Add the regress test for SendUserAuthKeyboardResponse

Author: yosuke-wolfssl

tests/regress.c

@@ -557,6 +557,114 @@ static void TestSftpBufferSendPendingOutput(void)
 #endif /* WOLFSSH_SFTP */
 
 
+#ifdef WOLFSSH_KEYBOARD_INTERACTIVE
+static int KbPreparePacketFailUserAuth(byte authType, WS_UserAuthData* authData,
+        void* ctx)
+{
+    static byte* responses[1];
+    static word32 responseLens[1];
+    static byte response[] = "regress";
+
+    (void)ctx;
+
+    if (authType != WOLFSSH_USERAUTH_KEYBOARD || authData == NULL) {
+        return WOLFSSH_USERAUTH_INVALID_AUTHTYPE;
+    }
+
+    if (authData->sf.keyboard.promptCount != 1 ||
+            authData->sf.keyboard.prompts == NULL) {
+        return WOLFSSH_USERAUTH_INVALID_PASSWORD;
+    }
+
+    responses[0] = response;
+    responseLens[0] = (word32)sizeof(response) - 1;
+    authData->sf.keyboard.responseCount = 1;
+    authData->sf.keyboard.responseLengths = responseLens;
+    authData->sf.keyboard.responses = responses;
+
+    return WOLFSSH_USERAUTH_SUCCESS;
+}
+
+static void TestKeyboardResponsePreparePacketFailure(WOLFSSH* ssh,
+        WOLFSSH_CTX* ctx)
+{
+    byte* prompt;
+    byte** prompts;
+    byte* promptEcho;
+    int ret;
+    byte* savedBuffer;
+
+    AssertNotNull(ssh);
+    AssertNotNull(ctx);
+
+    ResetSession(ssh);
+    wolfSSH_SetUserAuth(ctx, KbPreparePacketFailUserAuth);
+
+    prompt = (byte*)WMALLOC(9, ctx->heap, DYNTYPE_STRING); /* "Password" */
+    prompts = (byte**)WMALLOC(sizeof(byte*), ctx->heap, DYNTYPE_STRING);
+    promptEcho = (byte*)WMALLOC(1, ctx->heap, DYNTYPE_STRING);
+    AssertNotNull(prompt);
+    AssertNotNull(prompts);
+    AssertNotNull(promptEcho);
+
+    WMEMCPY(prompt, "Password", 8);
+    prompt[8] = '\0';
+    prompts[0] = prompt;
+    promptEcho[0] = 0;
+
+    ssh->kbAuth.promptCount = 1;
+    ssh->kbAuth.prompts = prompts;
+    ssh->kbAuth.promptEcho = promptEcho;
+    ssh->kbAuth.promptName = NULL;
+    ssh->kbAuth.promptInstruction = NULL;
+    ssh->kbAuth.promptLanguage = NULL;
+
+    /* Force PreparePacket() to fail with WS_OVERFLOW_E. */
+    ssh->outputBuffer.length = 0;
+    ssh->outputBuffer.idx = 1;
+
+    savedBuffer = ssh->outputBuffer.buffer;
+    ssh->outputBuffer.buffer = NULL;
+
+    ret = SendUserAuthKeyboardResponse(ssh);
+    AssertIntEQ(ret, WS_OVERFLOW_E);
+
+    /* Ensure packet purge/reset happened cleanly. */
+    AssertIntEQ(ssh->outputBuffer.idx, 0);
+    AssertIntEQ(ssh->outputBuffer.length, 0);
+
+    /* Restore known-good buffer pointer for subsequent tests. */
+    if (ssh->outputBuffer.buffer == NULL) {
+        ssh->outputBuffer.buffer = savedBuffer;
+    }
+
+    /* Ownership was transferred and freed by SendUserAuthKeyboardResponse(). */
+    ssh->kbAuth.promptCount = 0;
+    ssh->kbAuth.prompts = NULL;
+    ssh->kbAuth.promptEcho = NULL;
+}
+
+static void TestKeyboardResponseNoUserAuthCallback(WOLFSSH* ssh,
+        WOLFSSH_CTX* ctx)
+{
+    int ret;
+
+    AssertNotNull(ssh);
+    AssertNotNull(ctx);
+
+    ResetSession(ssh);
+    wolfSSH_SetUserAuth(ctx, NULL);
+
+    ret = SendUserAuthKeyboardResponse(ssh);
+    AssertIntEQ(ret, WS_INVALID_STATE_E);
+
+    /* No packet should have been started. */
+    AssertIntEQ(ssh->outputBuffer.length, 0);
+    AssertIntEQ(ssh->outputBuffer.idx, 0);
+}
+#endif /* WOLFSSH_KEYBOARD_INTERACTIVE */
+
+
 int main(int argc, char** argv)
 {
     WOLFSSH_CTX* ctx;
@@ -594,6 +702,11 @@ int main(int argc, char** argv)
     TestSftpBufferSendPendingOutput();
 #endif
 
+#ifdef WOLFSSH_KEYBOARD_INTERACTIVE
+    TestKeyboardResponsePreparePacketFailure(ssh, ctx);
+    TestKeyboardResponseNoUserAuthCallback(ssh, ctx);
+#endif
+
     /* TODO: add app-level regressions that simulate stdin EOF/password
      * prompts and mid-session socket closes once the test harness can
      * drive the wolfssh client without real sockets/tty. */