Fix RSA encrypt/decrypt buffer size check logic.

dgarske · dgarske · commit c29b9394d553 · 2025-07-17T07:09:27.000-07:00
diff --git a/src/tpm2_wrap.c b/src/tpm2_wrap.c
@@ -4364,7 +4364,7 @@ int wolfTPM2_RsaEncrypt(WOLFTPM2_DEV* dev, WOLFTPM2_KEY* key,
         return rc;
     }
 
-    if (*outSz > rsaEncOut.outData.size) {
+    if (*outSz < rsaEncOut.outData.size) {
         return BUFFER_E;
     }
     *outSz = rsaEncOut.outData.size;
@@ -4419,7 +4419,7 @@ int wolfTPM2_RsaDecrypt(WOLFTPM2_DEV* dev, WOLFTPM2_KEY* key,
         return rc;
     }
 
-    if (*msgSz > rsaDecOut.message.size) {
+    if (*msgSz < rsaDecOut.message.size) {
         return BUFFER_E;
     }
     *msgSz = rsaDecOut.message.size;

Original file line number	Diff line number	Diff line change
`@@ -4364,7 +4364,7 @@ int wolfTPM2_RsaEncrypt(WOLFTPM2_DEV* dev, WOLFTPM2_KEY* key,`
`4364`	`4364`	`return rc;`
`4365`	`4365`	`}`
`4366`	`4366`
`4367`		`- if (*outSz > rsaEncOut.outData.size) {`
	`4367`	`+ if (*outSz < rsaEncOut.outData.size) {`
`4368`	`4368`	`return BUFFER_E;`
`4369`	`4369`	`}`
`4370`	`4370`	`*outSz = rsaEncOut.outData.size;`
`@@ -4419,7 +4419,7 @@ int wolfTPM2_RsaDecrypt(WOLFTPM2_DEV* dev, WOLFTPM2_KEY* key,`
`4419`	`4419`	`return rc;`
`4420`	`4420`	`}`
`4421`	`4421`
`4422`		`- if (*msgSz > rsaDecOut.message.size) {`
	`4422`	`+ if (*msgSz < rsaDecOut.message.size) {`
`4423`	`4423`	`return BUFFER_E;`
`4424`	`4424`	`}`
`4425`	`4425`	`*msgSz = rsaDecOut.message.size;`