Proper migration of renode tests

Author: danielinux

.github/workflows/test-renode-fastmath-smallstack.yml

@@ -6,6 +6,10 @@ on:
   pull_request:
     branches: [ '*' ]
 
+permissions:
+  contents: read
+  packages: read
+
 jobs:
   renode_automated_fastmath_smallstack:
     runs-on: ubuntu-22.04
@@ -15,6 +19,13 @@ jobs:
         with:
           submodules: true
 
+      - name: Log in to GHCR
+        uses: docker/login-action@v3
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
       - name: Select config
         run: |
           cp config/examples/nrf52840.config .config && make include/target.h
@@ -70,4 +81,3 @@ jobs:
         with:
           name: Renode Test Results
           path: test_results/
-

.github/workflows/test-renode-fastmath.yml

@@ -6,6 +6,10 @@ on:
   pull_request:
     branches: [ '*' ]
 
+permissions:
+  contents: read
+  packages: read
+
 jobs:
   renode_automated_fastmath:
     runs-on: ubuntu-22.04
@@ -16,6 +20,13 @@ jobs:
         with:
           submodules: true
 
+      - name: Log in to GHCR
+        uses: docker/login-action@v3
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
       - name: Select config
         run: |
           cp config/examples/nrf52840.config .config && make include/target.h

.github/workflows/test-renode-noasm-smallstack.yml

@@ -6,6 +6,10 @@ on:
   pull_request:
     branches: [ '*' ]
 
+permissions:
+  contents: read
+  packages: read
+
 jobs:
   renode_automated_noasm_smallstack:
     runs-on: ubuntu-22.04
@@ -16,6 +20,13 @@ jobs:
         with:
           submodules: true
 
+      - name: Log in to GHCR
+        uses: docker/login-action@v3
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
       - name: Select config
         run: |
           cp config/examples/nrf52840.config .config && make include/target.h
@@ -71,4 +82,3 @@ jobs:
         with:
           name: Renode Test Results
           path: test_results/
-

.github/workflows/test-renode-noasm.yml

@@ -6,6 +6,10 @@ on:
   pull_request:
     branches: [ '*' ]
 
+permissions:
+  contents: read
+  packages: read
+
 jobs:
   renode_automated_noasm:
     runs-on: ubuntu-22.04
@@ -16,6 +20,13 @@ jobs:
         with:
           submodules: true
 
+      - name: Log in to GHCR
+        uses: docker/login-action@v3
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
       - name: Select config
         run: |
           cp config/examples/nrf52840.config .config && make include/target.h
@@ -80,4 +91,3 @@ jobs:
         with:
           name: Renode Test Results
           path: test_results/
-

.github/workflows/test-renode-nrf52.yml

@@ -6,6 +6,10 @@ on:
   pull_request:
     branches: [ '*' ]
 
+permissions:
+  contents: read
+  packages: read
+
 jobs:
   renode_automated_base:
     runs-on: ubuntu-22.04
@@ -16,6 +20,13 @@ jobs:
         with:
           submodules: true
 
+      - name: Log in to GHCR
+        uses: docker/login-action@v3
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
       - name: Select config
         run: |
           cp config/examples/nrf52840.config .config && make include/target.h SIGN=NONE
@@ -84,4 +95,3 @@ jobs:
         with:
           name: Renode Test Results
           path: test_results/
-

.github/workflows/test-renode-sha3.yml

@@ -6,6 +6,10 @@ on:
   pull_request:
     branches: [ '*' ]
 
+permissions:
+  contents: read
+  packages: read
+
 jobs:
   renode_automated_multi_sha:
     runs-on: ubuntu-22.04
@@ -16,6 +20,13 @@ jobs:
         with:
           submodules: true
 
+      - name: Log in to GHCR
+        uses: docker/login-action@v3
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
       - name: Select config
         run: |
           cp config/examples/nrf52840.config .config && make include/target.h

.github/workflows/test-renode-sha384.yml

@@ -6,6 +6,10 @@ on:
   pull_request:
     branches: [ '*' ]
 
+permissions:
+  contents: read
+  packages: read
+
 jobs:
   renode_automated_multi_sha:
     runs-on: ubuntu-22.04
@@ -16,6 +20,13 @@ jobs:
         with:
           submodules: true
 
+      - name: Log in to GHCR
+        uses: docker/login-action@v3
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
       - name: Select config
         run: |
           cp config/examples/nrf52840.config .config && make include/target.h
@@ -68,4 +79,3 @@ jobs:
         with:
           name: Renode Test Results
           path: test_results/
-

.github/workflows/test-renode-smallstack.yml

@@ -6,6 +6,10 @@ on:
   pull_request:
     branches: [ '*' ]
 
+permissions:
+  contents: read
+  packages: read
+
 jobs:
   renode_automated_smallstack:
     runs-on: ubuntu-22.04
@@ -16,6 +20,13 @@ jobs:
         with:
           submodules: true
 
+      - name: Log in to GHCR
+        uses: docker/login-action@v3
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
       - name: Select config
         run: |
           cp config/examples/nrf52840.config .config && make include/target.h
@@ -86,4 +97,3 @@ jobs:
         with:
           name: Renode Test Results
           path: test_results/
-

tools/renode/docker-test.sh

@@ -12,8 +12,6 @@ mkdir -p ${HOST_LOG_PATH}
 
 docker pull ${DOCKER_IMAGE} >/dev/null 2>&1 || true
 
-# running in `if` to avoid setting +e
-
 exit_code=0
 if ! docker run \
   --log-driver=none -a stdout -a stderr \