Skip to content

Commit 64134de

Browse files
committed
Minor fixes from code review
1 parent 629a0eb commit 64134de

4 files changed

Lines changed: 16 additions & 4 deletions

File tree

src/libwolfboot.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,10 @@
4646

4747
#define NVM_CACHE_SIZE WOLFBOOT_SECTOR_SIZE
4848

49+
#ifdef EXT_FLASH
4950
static uint32_t ext_cache;
51+
#endif
52+
5053
static const uint32_t wolfboot_magic_trail = WOLFBOOT_MAGIC_TRAIL;
5154

5255

tools/test-enc.mk

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,20 @@
11
ENC_TEST_UPDATE_VERSION?=2
22
KEYGEN_TOOL=python3 ./tools/keytools/keygen.py
3-
SIGN_TOOL=python3 ./tools/keytools/sign.py
43
SIGN_ARGS+=--ecc256 --encrypt /tmp/enc_key.der
54
SIGN_ENC_ARGS+=--ecc256 --encrypt /tmp/enc_key.der
65
USBTTY?=/dev/ttyACM0
76
TIMEOUT?=60
87

8+
ifneq ("$(wildcard ./tools/keytools/sign)","")
9+
SIGN_TOOL=./tools/keytools/sign
10+
else
11+
ifneq ("$(wildcard ./tools/keytools/sign.exe)","")
12+
SIGN_TOOL=./tools/keytools/sign.exe
13+
else
14+
SIGN_TOOL=python3 ./tools/keytools/sign.py
15+
endif
16+
endif
17+
918
.config:
1019
@rm -f $@
1120
@echo [CONFIG]

tools/uart-flash-server/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
CC=$(CROSS_COMPILE)gcc
2-
CFLAGS=-Wall -DWOLFSSL_DTLS -DWOLFSSL_DEBUG -DTFM_TIMING_RESISTANT -DWOLFBOOT_SIGN_ECC256 -DWOLFBOOT_HASH_SHA256 -g -ggdb -I../../include -I../../hal -Wextra
2+
CFLAGS=-Wall -DWOLFSSL_DEBUG -DTFM_TIMING_RESISTANT -DWOLFBOOT_SIGN_ECC256 -DWOLFBOOT_HASH_SHA256 -g -ggdb -I../../include -I../../hal -Wextra
33

44
EXE=ufserver
55

tools/uart-flash-server/ufserver.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,8 @@ static int serial_open(const char *device, int rate)
161161

162162
fcntl(fd, F_SETFL, 0);
163163
tcgetattr(fd, &options);
164-
cfsetispeed(&options, speed ?: B460800);
165-
cfsetospeed(&options, speed ?: B460800);
164+
cfsetispeed(&options, speed ?: 460800);
165+
cfsetospeed(&options, speed ?: 460800);
166166
cfmakeraw(&options);
167167
options.c_cflag |= (CLOCAL | CREAD);
168168
options.c_cflag &= ~CRTSCTS;

0 commit comments

Comments
 (0)