Skip to content

Commit 56be972

Browse files
committed
Spelling and add TODO's for testing new keytool features.
1 parent eba3f65 commit 56be972

3 files changed

Lines changed: 9 additions & 4 deletions

File tree

.github/workflows/test-keytools.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,3 +144,9 @@ jobs:
144144
- name: Generate final signed binary
145145
run: |
146146
./tools/keytools/sign --rsa2048 --sha256 --manual-sign test-app/image.elf public-key.der 1 test-app/image_v1.sig
147+
148+
149+
# TODO: Test WOLFBOOT_UNIVERSAL_KEYSTORE
150+
# TODO: Test sign "--no-ts"
151+
# TODO: Test keygen with --id "keygen --ecc256 -g generic.key --id 1,2,3 -g restricted.key"
152+
# TODO: Test keygen with -i "keygen --ecc256 -g a.key --ecc384 -g b.key --rsa2048 -i rsa-pub.der"

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ tools/tpm/pcr_read
105105
tools/tpm/pcr_reset
106106
tools/tpm/pcr_extend
107107
tools/tpm/policy_create
108+
tools/tpm/policy_sign
108109
config/*.ld
109110

110111
# Generated confiuguration file

docs/keystore.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ partition with `--id 3` would require turning on bit '3' in the mask, i.e. addin
124124

125125
To restrict the permissions for single keys, it would be sufficient to change the value
126126
of each key `part_id_mask`. This is done via the `--id` command line option for keygen.
127-
Each generated or imported key can be associatd with a number of partition by passing the
127+
Each generated or imported key can be associated with a number of partition by passing the
128128
partition IDs in a comma-separated list, e.g.:
129129

130130
```
@@ -176,7 +176,7 @@ The API consists of a few functions described below.
176176

177177
Returns the number of slots in the keystore. At least one slot
178178
should be populated if you want to authenticate your firmware today.
179-
The interface assumes that the slots are numbered sequentially, from zero to
179+
The interface assumes that the slots are numbered sequentially, from zero to
180180
`keystore_num_pubkeys() - 1`. Accessing those slots through this API should always
181181
return a valid public key.
182182

@@ -198,5 +198,3 @@ public key associated to the slot `id`.
198198
`uint32_t keystore_get_mask(int id)`
199199

200200
Returns the permissions mask, as a 32-bit word, for the public key stored in the slot `id`.
201-
202-

0 commit comments

Comments
 (0)