fix: Node.js v24+ changed permission access error codes

Author: xiaoxiaojx

lib/DirectoryWatcher.js

@@ -15,6 +15,8 @@ const EXISTANCE_ONLY_TIME_ENTRY = Object.freeze({});
 let FS_ACCURACY = 2000;
 
 const IS_OSX = require("os").platform() === "darwin";
+const IS_WIN = require("os").platform() === "win32";
+
 const WATCHPACK_POLLING = process.env.WATCHPACK_POLLING;
 const FORCE_POLLING =
 	`${+WATCHPACK_POLLING}` === WATCHPACK_POLLING
@@ -633,7 +635,9 @@ class DirectoryWatcher extends EventEmitter {
 								err2.code === "ENOENT" ||
 								err2.code === "EPERM" ||
 								err2.code === "EACCES" ||
-								err2.code === "EBUSY"
+								err2.code === "EBUSY" ||
+								// TODO https://github.com/libuv/libuv/pull/4566
+								(err2.code === "EINVAL" && IS_WIN)
 							) {
 								this.setMissing(itemPath, initial, "scan (" + err2.code + ")");
 							} else {

test/Assumption.js

@@ -15,6 +15,17 @@ const IS_WIN = require("os").platform() === "win32";
 const SUPPORTS_RECURSIVE_WATCHING = IS_OSX || IS_WIN;
 
 
+function getNodeVersion() {
+	try {
+		return parseInt(process.version.split('.')[0].replace('v', ''), 10)
+	} catch (e) {
+		return 0;
+	}
+}
+
+const IS_NODE_VERSION_GT_24 = getNodeVersion() >= 24;
+
+
 describe("Assumption", function() {
 	this.timeout(10000);
 	var watcherToClose = null;
@@ -341,6 +352,15 @@ describe("Assumption", function() {
 		});
 	}
 
+	if (IS_WIN) {
+		it("should return EINVAL when lstat a directory on Windows", function(done) {
+			fs.lstat('D:\\System Volume Information', (err) => {
+				err.code.should.be.equal(IS_NODE_VERSION_GT_24 ? 'EINVAL' : 'EPERM');
+				done();
+			});
+		});
+	}
+
 	[100, 200, 300, 500, 700, 1000].reverse().forEach(function(delay) {
 		it("should fire events not after start and " + delay + "ms delay", function(
 			done