avoid RegexpLike in favor of a function

move path normalization to option normalization

Author: sokra

README.md

@@ -50,6 +50,7 @@ var wp = new Watchpack({
 	// ignored: ["string", "string"] - multiple glob patterns that should be ignored
 	// ignored: /regexp/ - a regular expression for files or folders that should not be watched
 	// ignored: (entry) => boolean - an arbirary function which must return truthy to ignore an entry
+	// For all cases expect the arbirary function the path will have path separator normalized to '/'.
 	// All subdirectories are ignored too
 });
 

lib/DirectoryWatcher.js

@@ -71,7 +71,7 @@ class DirectoryWatcher extends EventEmitter {
 		this.directories = new Map();
 		this.lastWatchEvent = 0;
 		this.initialScan = true;
-		this.ignored = options.ignored;
+		this.ignored = options.ignored || (() => false);
 		this.nestedWatching = false;
 		this.polledWatching =
 			typeof options.poll === "number"
@@ -96,12 +96,6 @@ class DirectoryWatcher extends EventEmitter {
 		this.doScan(true);
 	}
 
-	checkIgnore(path) {
-		if (!this.ignored) return false;
-		path = path.replace(/\\/g, "/");
-		return this.ignored.test(path);
-	}
-
 	createWatcher() {
 		try {
 			if (this.polledWatching) {
@@ -178,7 +172,7 @@ class DirectoryWatcher extends EventEmitter {
 	setFileTime(filePath, mtime, initial, ignoreWhenEqual, type) {
 		const now = Date.now();
 
-		if (this.checkIgnore(filePath)) return;
+		if (this.ignored(filePath)) return;
 
 		const old = this.files.get(filePath);
 
@@ -237,7 +231,7 @@ class DirectoryWatcher extends EventEmitter {
 	}
 
 	setDirectory(directoryPath, birthtime, initial, type) {
-		if (this.checkIgnore(directoryPath)) return;
+		if (this.ignored(directoryPath)) return;
 		if (directoryPath === this.path) {
 			if (!initial) {
 				this.forEachWatcher(this.path, w =>
@@ -398,7 +392,7 @@ class DirectoryWatcher extends EventEmitter {
 		}
 
 		const filePath = path.join(this.path, filename);
-		if (this.checkIgnore(filePath)) return;
+		if (this.ignored(filePath)) return;
 
 		if (this._activeEvents.get(filename) === undefined) {
 			this._activeEvents.set(filename, false);

lib/watchpack.js

@@ -31,26 +31,28 @@ const stringToRegexp = ignored => {
 	return matchingStart;
 };
 
-const ignoredToRegexpLike = ignored => {
+const ignoredToFunction = ignored => {
 	if (Array.isArray(ignored)) {
-		return new RegExp(ignored.map(i => stringToRegexp(i)).join("|"));
+		const regexp = new RegExp(ignored.map(i => stringToRegexp(i)).join("|"));
+		return x => regexp.test(x.replace(/\\/g, "/"));
 	} else if (typeof ignored === "string") {
-		return new RegExp(stringToRegexp(ignored));
+		const regexp = new RegExp(stringToRegexp(ignored));
+		return x => regexp.test(x.replace(/\\/g, "/"));
 	} else if (ignored instanceof RegExp) {
-		return ignored;
+		return x => ignored.test(x.replace(/\\/g, "/"));
 	} else if (ignored instanceof Function) {
-		return { test: ignored };
+		return ignored;
 	} else if (ignored) {
 		throw new Error(`Invalid option for 'ignored': ${ignored}`);
 	} else {
-		return undefined;
+		return () => false;
 	}
 };
 
 const normalizeOptions = options => {
 	return {
 		followSymlinks: !!options.followSymlinks,
-		ignored: ignoredToRegexpLike(options.ignored),
+		ignored: ignoredToFunction(options.ignored),
 		poll: options.poll
 	};
 };
@@ -104,9 +106,7 @@ class Watchpack extends EventEmitter {
 		const oldFileWatchers = this.fileWatchers;
 		const oldDirectoryWatchers = this.directoryWatchers;
 		const ignored = this.watcherOptions.ignored;
-		const filter = ignored
-			? path => !ignored.test(path.replace(/\\/g, "/"))
-			: () => true;
+		const filter = path => !ignored(path);
 		const addToMap = (map, key, item) => {
 			const list = map.get(key);
 			if (list === undefined) {