Skip to content
This repository was archived by the owner on Jan 29, 2019. It is now read-only.

Commit 0b559c1

Browse files
author
Laurent MINGUET
committed
better unit test
1 parent bfcbd4a commit 0b559c1

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

tests/Webcreate/Vcs/GitTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,12 +111,12 @@ public function logProvider()
111111
array('/dir1', null, 10, xsprintf('%s log -n %xs --pretty=%s %xs',
112112
$this->bin,
113113
'10',
114-
ProcessUtils::escapeArgument(Git::PRETTY_FORMAT),
114+
escapeshellarg(Git::PRETTY_FORMAT),
115115
'/dir1'
116116
)),
117117
array('/dir1', null, null, xsprintf('%s log --pretty=%s %xs',
118118
$this->bin,
119-
ProcessUtils::escapeArgument(Git::PRETTY_FORMAT),
119+
escapeshellarg(Git::PRETTY_FORMAT),
120120
'/dir1'
121121
)),
122122
);

tests/Webcreate/Vcs/Test/Functional/AbstractTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public function testLs()
5858
}
5959

6060
/**
61-
* @expectedException Webcreate\Vcs\Exception\NotFoundException
61+
* @expectedException \Webcreate\Vcs\Exception\NotFoundException
6262
*/
6363
public function testLsForNonExistingPathThrowsException()
6464
{
@@ -139,7 +139,7 @@ public function testCat($path)
139139
}
140140

141141
/**
142-
* @expectedException Webcreate\Vcs\Exception\NotFoundException
142+
* @expectedException \Webcreate\Vcs\Exception\NotFoundException
143143
*/
144144
public function testCatForNonExistingPathThrowsException()
145145
{
@@ -184,7 +184,7 @@ public function testStatusAddedFile()
184184

185185
$this->client->add(basename($tmpfile));
186186

187-
$result = $this->client->status('');
187+
$result = $this->client->status();
188188

189189
$file = new VcsFileInfo(basename($tmpfile), $this->client->getHead());
190190
$file->setStatus(Status::ADDED);

0 commit comments

Comments
 (0)