Skip to content

Commit a2fa145

Browse files
committed
Minor fixes
1 parent 8b93770 commit a2fa145

4 files changed

Lines changed: 6 additions & 21 deletions

File tree

src/framework/components/PageComposer/utilities.js

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@ export function offset(el) {
22
return getPosition2(el);
33
}
44

5-
export function offsetInViewPort(el) {
6-
return getPosition(el);
7-
}
8-
95
export function isVisible(el) {
106
if (el) {
117
let styleDisplay = el.style.display;
@@ -56,16 +52,6 @@ function getPosition1(el) {
5652
};
5753
}
5854

59-
function getPosition(el) {
60-
const rect = el.getBoundingClientRect();
61-
return {
62-
top: (rect.top + scrollTop),
63-
left: (rect.left + scrollLeft),
64-
right: rect.right + scrollLeft,
65-
bottom: rect.bottom + scrollTop
66-
};
67-
}
68-
6955
function getPosition2(el) {
7056
const rect = el.getBoundingClientRect();
7157
const scrollLeft = window.pageXOffset || document.documentElement.scrollLeft;

src/framework/index.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,13 @@ import { resetStoreItems } from './store/functions';
99
import PageRouter from './components/PageRouter';
1010
import StartWrapper from './components/StartWrapper';
1111
import WarningComponent from './components/WarningComponent';
12-
import ComponentComposer from './components/ComponentComposer';
1312

1413
let constants;
15-
let ComponentView;
14+
let ComponentComposer;
1615
let PageComposer;
1716
if (process.env.NODE_ENV !== 'production') {
1817
constants = require('./commons/constants');
19-
ComponentView = require('./components/ComponentComposer/ComponentComposer').default;
18+
ComponentComposer = require('./components/ComponentComposer/ComponentComposer').default;
2019
PageComposer = require('./components/PageComposer/PageComposer').default;
2120
}
2221

src/framework/store/actions.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ function transformFirstArgument (elementKey, transformScript, firstArgument) {
3030
console.error(`[Framework] The transformation script should return a JavaScript function: ${transformScript}`);
3131
}
3232
} catch (error) {
33-
console.error(`[Framework] In input transformation function "${transformScript.substr(0, 200)}${transformInput.length > 200 ? '...' : ''}" has error: "${error.message}".`);
33+
console.error(`[Framework] In input transformation function "${transformScript.substr(0, 200)}${transformScript.length > 200 ? '...' : ''}" has error: "${error.message}".`);
3434
}
3535
}
3636
try {

src/framework/store/sequences.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,21 +92,21 @@ function eventTargetComparator (destTarget, sourceTarget) {
9292
if (sourceProps.functionName && destProps.functionName) {
9393
// if there is only function test inputs
9494
result = sourceProps.functionName === destProps.functionName
95-
&& sourceProps.transformScript === sourceProps.transformScript;
95+
&& sourceProps.transformScript === destProps.transformScript;
9696
} else if (sourceProps.componentName && destProps.componentName) {
9797
if (sourceProps.forwardPath && destProps.forwardPath) {
9898
// if there is forwarding test all attributes
9999
result = sourceProps.componentName === destProps.componentName
100100
&& sourceProps.componentInstance === destProps.componentInstance
101101
&& sourceProps.propertyName === destProps.propertyName
102102
&& sourceProps.forwardPath === destProps.forwardPath
103-
&& sourceProps.transformScript === sourceProps.transformScript;
103+
&& sourceProps.transformScript === destProps.transformScript;
104104
} else {
105105
// if there is no forwarding test only component attributes
106106
result = sourceProps.componentName === destProps.componentName
107107
&& sourceProps.componentInstance === destProps.componentInstance
108108
&& sourceProps.propertyName === destProps.propertyName
109-
&& sourceProps.transformScript === sourceProps.transformScript;
109+
&& sourceProps.transformScript === destProps.transformScript;
110110
}
111111
} else if (sourceProps.forwardPath && destProps.forwardPath) {
112112
// it is possible to set only forward path without component property target

0 commit comments

Comments
 (0)