refactor: towards PHP 8.4 and PHP 8.5

Signed-off-by: otengkwame <developerkwame@gmail.com>

Author: otengkwame

CodeIgniter/Framework/libraries/Email.php

@@ -301,7 +301,7 @@ class CI_Email
 	/**
 	 * Recipients
 	 *
-	 * @var	string[]
+	 * @var	string|array
 	 */
 	protected $_recipients		= [];
 
@@ -397,9 +397,6 @@ public function __construct(array $config = [])
 	{
 		$this->charset = config_item('charset');
 		$this->initialize($config);
-		$this->_safe_mode = (! is_php('5.4') && ini_get('safe_mode'));
-
-		isset(self::$func_overload) or self::$func_overload = (! is_php('8.0') && extension_loaded('mbstring') && @ini_get('mbstring.func_overload'));
 
 		log_message('info', 'Email Class Initialized');
 	}
@@ -2000,9 +1997,8 @@ protected function _smtp_connect()
 			 *
 			 * We want the negotiation, so we'll force it below ...
 			 */
-			$method = is_php('5.6')
-				? STREAM_CRYPTO_METHOD_TLSv1_0_CLIENT | STREAM_CRYPTO_METHOD_TLSv1_1_CLIENT | STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT
-				: STREAM_CRYPTO_METHOD_TLS_CLIENT;
+			$method = STREAM_CRYPTO_METHOD_TLSv1_0_CLIENT | STREAM_CRYPTO_METHOD_TLSv1_1_CLIENT | STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT;
+				
 			$crypto = stream_socket_enable_crypto($this->_smtp_connect, true, $method);
 
 			if ($crypto !== true) {

CodeIgniter/Framework/libraries/Form_validation.php

@@ -2219,17 +2219,10 @@ public function valid_url($str)
 
 		// Apparently, FILTER_VALIDATE_URL doesn't reject digit-only names for some reason ...
 		// See https://github.com/bcit-ci/CodeIgniter/issues/5755
-		if (ctype_digit($str)) {
+		if (ctype_digit((string) $str)) {
 			return false;
 		}
 
-		// PHP 7 accepts IPv6 addresses within square brackets as hostnames,
-		// but it appears that the PR that came in with https://bugs.php.net/bug.php?id=68039
-		// was never merged into a PHP 5 branch ... https://3v4l.org/8PsSN
-		if (preg_match('/^\[([^\]]+)\]/', $str, $matches) && !is_php('7') && filter_var($matches[1], FILTER_VALIDATE_IP, FILTER_FLAG_IPV6) !== false) {
-			$str = 'ipv6.host' . substr($str, strlen($matches[1]) + 2);
-		}
-
 		return (filter_var('http://' . $str, FILTER_VALIDATE_URL) !== false);
 	}
 

CodeIgniter/Framework/libraries/Image_lib.php

@@ -1308,7 +1308,7 @@ public function text_watermark()
 	 *
 	 * @param	string
 	 * @param	string
-	 * @return	resource
+	 * @return	resource|bool
 	 */
 	public function image_create_gd($path = '', $image_type = '')
 	{
@@ -1403,6 +1403,10 @@ public function image_save_gd($resource)
 
 					return false;
 				}
+				if (! @imagewebp($resource, $this->full_dst_path)) {
+					$this->set_error('imglib_save_failed');
+					return false;
+				}
 				break;
 			case IMAGETYPE_AVIF:
 				if (! function_exists('imageavif')) {
@@ -1670,7 +1674,7 @@ public function gd_version()
 	/**
 	 * Set error message
 	 *
-	 * @param	string
+	 * @param	string|array
 	 * @return	void
 	 */
 	public function set_error($msg)

CodeIgniter/Framework/libraries/Pagination.php

@@ -498,7 +498,7 @@ public function create_links()
 				$this->uri_segment = count($this->CI->uri->segment_array());
 			}
 
-			$this->cur_page = $this->CI->uri->segment($this->uri_segment);
+			$this->cur_page = $this->CI->uri->segment($this->uri_segment, '');
 
 			// Remove any specified prefix/suffix from the segment.
 			if ($this->prefix !== '' or $this->suffix !== '') {