lib: remove useless xbps_pkg_has_rundeps function

In the only place where this was required it doesn't have any effect and
results in going through the package directory twice to receive and use
the array after checking separately if it exists.

Author: Duncaen

bin/xbps-pkgdb/check_pkg_rundeps.c

@@ -52,9 +52,6 @@ check_pkg_rundeps(struct xbps_handle *xhp, const char *pkgname, void *arg)
 	const char *reqpkg = NULL;
 	int rv = 0;
 
-	if (!xbps_pkg_has_rundeps(pkg_propsd))
-		return 0;
-
 	array = xbps_dictionary_get(pkg_propsd, "run_depends");
 	for (unsigned int i = 0; i < xbps_array_count(array); i++) {
 		xbps_array_get_cstring_nocopy(array, i, &reqpkg);

include/xbps.h.in

@@ -2155,15 +2155,6 @@ int xbps_pkgpattern_match(const char *pkgver, const char *pattern);
  */
 const char *xbps_pkg_revision(const char *pkg);
 
-/**
- * Checks if a package has run dependencies.
- *
- * @param[in] dict Package dictionary.
- *
- * @return True if package has run dependencies, false otherwise.
- */
-bool xbps_pkg_has_rundeps(xbps_dictionary_t dict);
-
 /**
  * Returns true if provided string is valid for target architecture.
  *

lib/util.c

@@ -418,20 +418,6 @@ xbps_remote_binpkg_exists(struct xbps_handle *xhp, xbps_dictionary_t pkgd)
 	return access(path, R_OK) == 0;
 }
 
-bool
-xbps_pkg_has_rundeps(xbps_dictionary_t pkgd)
-{
-	xbps_array_t array;
-
-	assert(xbps_object_type(pkgd) == XBPS_TYPE_DICTIONARY);
-
-	array = xbps_dictionary_get(pkgd, "run_depends");
-	if (xbps_array_count(array))
-		return true;
-
-	return false;
-}
-
 bool
 xbps_pkg_arch_match(struct xbps_handle *xhp, const char *orig,
 		const char *target)