follow, walker: replace core module routines with "is-core-module"

Author: jesec

lib/follow.ts

@@ -1,20 +1,10 @@
-import { core, sync, SyncOpts } from 'resolve';
-import assert from 'assert';
+import { sync, SyncOpts } from 'resolve';
 import fs from 'fs';
 import path from 'path';
 import { toNormalizedRealPath } from './common';
 
 import type { PackageJson } from './types';
 
-Object.keys(core).forEach((key) => {
-  // 'resolve' hardcodes the list to host's one, but i need
-  // to be able to allow 'worker_threads' (target 12) on host 8
-  assert(typeof core[key] === 'boolean');
-  core[key] = true;
-});
-
-export const natives = core;
-
 const PROOF = 'a-proof-that-main-is-captured.js';
 
 function parentDirectoriesContain(parent: string, directory: string) {

lib/walker.ts

@@ -2,6 +2,7 @@
 
 import assert from 'assert';
 import fs from 'fs-extra';
+import isCore from 'is-core-module';
 import globby from 'globby';
 import path from 'path';
 import chalk from 'chalk';
@@ -21,7 +22,7 @@ import {
   toNormalizedRealPath,
 } from './common';
 
-import { follow, natives } from './follow';
+import { follow } from './follow';
 import { log, wasReported } from './log';
 import * as detector from './detector';
 import {
@@ -845,11 +846,9 @@ class Walker {
     derivatives: Derivative[]
   ) {
     for (const derivative of derivatives) {
-      if (natives[derivative.alias]) continue;
-      if (derivative.alias.startsWith('node:')) {
-        if (natives[derivative.alias.slice(5)]) continue;
-      }
-      
+      // TODO: actually use the target node version
+      if (isCore(derivative.alias, '99.0.0')) continue;
+
       switch (derivative.aliasType) {
         case ALIAS_AS_RELATIVE:
           await this.stepDerivatives_ALIAS_AS_RELATIVE(

package.json

@@ -26,6 +26,7 @@
     "fs-extra": "^9.1.0",
     "globby": "^11.1.0",
     "into-stream": "^6.0.0",
+    "is-core-module": "2.9.0",
     "minimist": "^1.2.6",
     "multistream": "^4.1.0",
     "pkg-fetch": "3.3.0",
@@ -39,6 +40,7 @@
     "@babel/core": "7.17.10",
     "@types/escodegen": "0.0.7",
     "@types/fs-extra": "9.0.13",
+    "@types/is-core-module": "2.2.0",
     "@types/minimist": "1.2.2",
     "@types/multistream": "2.1.2",
     "@types/node": "14.18.16",

yarn.lock

@@ -306,6 +306,11 @@
   dependencies:
     "@types/node" "*"
 
+"@types/is-core-module@2.2.0":
+  version "2.2.0"
+  resolved "https://registry.yarnpkg.com/@types/is-core-module/-/is-core-module-2.2.0.tgz#a6f01308db449fb9200cc8b8b05aa26f404f0ddb"
+  integrity sha512-4jdbEoadP1B6v5/6YoVFPKUr2NC+knEWMSllpX3cL4FAZktVmveeWTcUHQY7bU6Vx8TEt/ARbQyQapkZvGgFog==
+
 "@types/json-schema@^7.0.7":
   version "7.0.9"
   resolved "https://registry.yarnpkg.com/@types/json-schema/-/json-schema-7.0.9.tgz#97edc9037ea0c38585320b28964dde3b39e4660d"
@@ -1540,20 +1545,20 @@ is-callable@^1.1.4, is-callable@^1.2.4:
   resolved "https://registry.yarnpkg.com/is-callable/-/is-callable-1.2.4.tgz#47301d58dd0259407865547853df6d61fe471945"
   integrity sha512-nsuwtxZfMX67Oryl9LCQ+upnC0Z0BgpwntpS89m1H/TLF0zNfzfLMV/9Wa/6MZsj0acpEjAO0KF1xT6ZdLl95w==
 
+is-core-module@2.9.0, is-core-module@^2.8.1:
+  version "2.9.0"
+  resolved "https://registry.yarnpkg.com/is-core-module/-/is-core-module-2.9.0.tgz#e1c34429cd51c6dd9e09e0799e396e27b19a9c69"
+  integrity sha512-+5FPy5PnwmO3lvfMb0AsoPaBG+5KHUI0wYFXOtYPnVVVspTFUuMZNfNaNVRt3FZadstu2c8x23vykRW/NBoU6A==
+  dependencies:
+    has "^1.0.3"
+
 is-core-module@^2.2.0:
   version "2.8.0"
   resolved "https://registry.yarnpkg.com/is-core-module/-/is-core-module-2.8.0.tgz#0321336c3d0925e497fd97f5d95cb114a5ccd548"
   integrity sha512-vd15qHsaqrRL7dtH6QNuy0ndJmRDrS9HAM1CAiSifNUFv4x1a0CCVsj18hJ1mShxIG6T2i1sO78MkP56r0nYRw==
   dependencies:
     has "^1.0.3"
 
-is-core-module@^2.8.1:
-  version "2.9.0"
-  resolved "https://registry.yarnpkg.com/is-core-module/-/is-core-module-2.9.0.tgz#e1c34429cd51c6dd9e09e0799e396e27b19a9c69"
-  integrity sha512-+5FPy5PnwmO3lvfMb0AsoPaBG+5KHUI0wYFXOtYPnVVVspTFUuMZNfNaNVRt3FZadstu2c8x23vykRW/NBoU6A==
-  dependencies:
-    has "^1.0.3"
-
 is-date-object@^1.0.1:
   version "1.0.5"
   resolved "https://registry.yarnpkg.com/is-date-object/-/is-date-object-1.0.5.tgz#0841d5536e724c25597bf6ea62e1bd38298df31f"