Skip to content

Commit 26af9e8

Browse files
committed
docs(config_reader[ConfigReader._from_file]) update TODO: vcspull add landed
why: The trigger condition in the TODO ("once the new vcspull add flow lands") was already satisfied — vcspull add now uses DuplicateAwareConfigReader for reading. The stale "Revisit once" sentence misled readers into thinking the integration was still pending. what: - Replace the stale "Revisit once the new vcspull add flow lands" sentence with a note reflecting the current state - Note that this basic loader remains for simpler read contexts - Identify Option 1 (shared utility) as the cleanest long-term path
1 parent bf9ee94 commit 26af9e8

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

src/vcspull/_internal/config_reader.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,9 @@ def _from_file(cls, path: pathlib.Path) -> dict[str, t.Any]:
164164
# the formatter helpers directly;
165165
# 3) Keep this basic loader but add an opt-in path for duplicate-aware
166166
# parsing so commands like ``vcspull add`` can avoid data loss.
167-
# Revisit once the new ``vcspull add`` flow lands so both commands share
168-
# the same duplication safeguards.
167+
# ``vcspull add`` now uses ``DuplicateAwareConfigReader`` for reading
168+
# (see ``cli/add.py``). This basic loader remains for simpler read
169+
# contexts. Option 1 (shared utility) is the cleanest long-term path.
169170

170171
fmt = config_format_from_path(path)
171172
if fmt is None:

0 commit comments

Comments
 (0)