Commit 26999e0
committed
docs(import[provenance]) Explain why metadata None guard excludes type(None)
why: The isinstance guard was changed from (dict, type(None)) to dict
to fix a TypeError, but lacks context on why None is unsafe. Without
the comment a future developer might re-introduce type(None) thinking
setdefault handles it.
what:
- Add inline comment above the UPDATE_URL metadata guard explaining
that setdefault returns existing None instead of replacing it
- Add same comment above the SKIP_UNCHANGED metadata guard1 parent 039db68 commit 26999e0
1 file changed
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
955 | 955 | | |
956 | 956 | | |
957 | 957 | | |
| 958 | + | |
| 959 | + | |
958 | 960 | | |
959 | 961 | | |
960 | 962 | | |
| |||
975 | 977 | | |
976 | 978 | | |
977 | 979 | | |
| 980 | + | |
| 981 | + | |
978 | 982 | | |
979 | 983 | | |
980 | 984 | | |
| |||
0 commit comments