feat: add dynamic connection management to multiserver.Manager (#54)

* feat: add dynamic connection management to multiserver.Manager

Add AddConnection and RemoveConnection methods to support runtime
addition and removal of Trino clients from downstream projects.
Also add RLock to read-path methods for thread safety with mutations.

* refactor: remove deprecation support and fix lint issues

Remove Deprecation struct, IncludeDeprecated filter, formatDeprecation,
mapDeprecation, matchesDeprecation, and all related tests/docs. The
project is too new for deprecation machinery.

Also fix pre-existing lint issues: gosec G706 in server.go (nolint for
operator-controlled env var), staticcheck QF1012 in schema.go
(fmt.Fprintf instead of WriteString+Sprintf), and update multi-server
docs with dynamic connection management API.

* ci: bump golangci-lint to v2.11.4 for Go 1.25 support

Author: cjimti

.github/workflows/ci.yml

@@ -27,7 +27,7 @@ jobs:
       - name: Run golangci-lint
         uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
         with:
-          version: v2.1.6
+          version: v2.11.4
           args: --timeout=5m
 
   test:

README.md

@@ -30,7 +30,7 @@ mcp-trino is part of a broader suite of open-source MCP servers designed to work
 
 **Semantic Context**
 - Surface business descriptions, ownership, and data quality from metadata catalogs
-- Mark sensitive columns and deprecation warnings for AI assistants
+- Mark sensitive columns for AI assistants
 - Connect to DataHub, static files, or build custom metadata providers
 
 **Multi-Cluster Connectivity**
@@ -204,7 +204,6 @@ mcp-trino's semantic layer integrates with metadata catalogs to surface this con
 | **Glossary Terms** | Links to formal business definitions |
 | **Data Quality** | Freshness scores and quality metrics |
 | **Sensitivity** | PII and sensitive data markers at column level |
-| **Deprecation** | Warnings with replacement guidance |
 | **Lineage** | Upstream and downstream data dependencies |
 
 ### Providers

docs/library/extensibility.md

@@ -402,7 +402,6 @@ When configured, `trino_describe_table` enriches output with:
 - Ownership information
 - Tags and domain classifications
 - Sensitivity markers (PII, sensitive data)
-- Deprecation warnings
 
 See the [Semantic Layer documentation](../semantic/index.md) for provider setup, caching, and building custom providers.
 

docs/library/quickstart.md

@@ -275,22 +275,31 @@ func main() {
 Connect to multiple Trino clusters:
 
 ```go
-// Create connection manager
-manager := tools.NewManager()
+import "github.com/txn2/mcp-trino/pkg/multiserver"
 
-// Add connections
-prodClient, _ := client.New(client.Config{Host: "prod.trino.example.com", ...})
-stagingClient, _ := client.New(client.Config{Host: "staging.trino.example.com", ...})
-
-manager.Add("production", prodClient)
-manager.Add("staging", stagingClient)
-manager.SetDefault("production")
+// Create manager from environment (TRINO_* + TRINO_ADDITIONAL_SERVERS)
+mgr, _ := multiserver.NewManagerFromEnv()
 
 // Create toolkit with manager
-toolkit := tools.NewToolkitWithManager(manager, tools.DefaultConfig())
+toolkit := tools.NewToolkitWithManager(mgr, tools.DefaultConfig())
+```
+
+### Dynamic Connections
+
+Add and remove connections at runtime:
+
+```go
+// Add a connection dynamically
+mgr.AddConnection("analytics", multiserver.ConnectionConfig{
+    Host:    "analytics.trino.example.com",
+    Catalog: "iceberg",
+})
+
+// Remove a connection (closes any cached client)
+mgr.RemoveConnection("analytics")
 ```
 
-Users can now specify which connection to use:
+Users can specify which connection to use:
 
 ```json
 {"tool": "trino_query", "arguments": {"sql": "SELECT * FROM users", "connection": "staging"}}

docs/semantic/custom.md

@@ -203,10 +203,6 @@ overrides := semantic.ProviderFunc{
             return &semantic.TableContext{
                 Identifier:  t,
                 Description: "OVERRIDE: Use v2_customers instead",
-                Deprecation: &semantic.Deprecation{
-                    Deprecated: true,
-                    ReplacedBy: "v2_customers",
-                },
             }, nil
         }
         return nil, nil  // Fall through to next provider

docs/semantic/datahub.md

@@ -66,7 +66,6 @@ The provider retrieves the following metadata from DataHub:
 | Tags | Global tags with descriptions |
 | Glossary Terms | Glossary term associations |
 | Domain | Domain assignment |
-| Deprecation | Deprecation aspect |
 
 ### Column-Level
 

docs/semantic/index.md

@@ -39,7 +39,6 @@ and their subscription status.
 | **Glossary Terms** | Links to formal business term definitions |
 | **Data Quality** | Freshness scores and quality metrics |
 | **Sensitivity** | PII and sensitive data markers at column level |
-| **Deprecation** | Warnings with replacement guidance |
 | **Lineage** | Upstream and downstream data dependencies |
 
 ## Providers

docs/semantic/static.md

@@ -61,14 +61,6 @@ tables:
         glossary_terms:
           - urn:glossary:subscription-tier
 
-  - catalog: analytics
-    schema: public
-    table: orders_legacy
-    description: Legacy orders table
-    deprecated: true
-    deprecation_note: Migrated to iceberg.sales.orders
-    replaced_by: iceberg.sales.orders
-
 glossary:
   - urn: urn:glossary:customer
     name: Customer
@@ -120,9 +112,6 @@ glossary:
 | `tags` | array | List of tags |
 | `domain` | object | Domain assignment |
 | `glossary_terms` | array | URNs of associated terms |
-| `deprecated` | boolean | Deprecation flag |
-| `deprecation_note` | string | Deprecation explanation |
-| `replaced_by` | string | Replacement table identifier |
 | `columns` | object | Column metadata (keyed by name) |
 | `custom_properties` | object | Additional key-value metadata |
 

docs/server/multi-server.md

@@ -81,6 +81,31 @@ export TRINO_ADDITIONAL_SERVERS='{
 }'
 ```
 
+## Dynamic Connections (Library Use)
+
+When using mcp-trino as a library, connections can be added and removed at runtime via the `multiserver.Manager`:
+
+```go
+import "github.com/txn2/mcp-trino/pkg/multiserver"
+
+mgr, _ := multiserver.NewManagerFromEnv()
+toolkit := tools.NewToolkitWithManager(mgr, tools.DefaultConfig())
+
+// Add a connection at runtime
+mgr.AddConnection("analytics", multiserver.ConnectionConfig{
+    Host:    "analytics.trino.example.com",
+    Catalog: "iceberg",
+})
+
+// Remove a connection (closes any cached client)
+mgr.RemoveConnection("analytics")
+```
+
+- `AddConnection` replaces an existing connection if one with the same name exists
+- Cached clients are automatically closed and recreated on next access
+- The primary/default connection cannot be added or removed via these methods
+- All operations are thread-safe
+
 ## Usage
 
 ### Connection Parameter

docs/server/tools.md

@@ -153,7 +153,6 @@ When a [semantic provider](../semantic/index.md) is configured, this tool enrich
 - **Ownership**: Data stewards and technical owners
 - **Tags & Domain**: Classification labels and business domain
 - **Sensitivity**: Columns marked as containing PII or sensitive data
-- **Deprecation**: Warnings if the table is deprecated
 
 ### Parameters