Rename ByteReader.isAtTheEnd to isFinished

Author: tsolomko

Sources/ByteReader.swift

@@ -11,8 +11,7 @@ public class ByteReader {
     public let data: Data
     public var offset: Int
 
-    // TODO: Rename?
-    public var isAtTheEnd: Bool {
+    public var isFinished: Bool {
         return self.data.endIndex == self.offset
     }
 

Tests/BitByteDataTests/ByteReaderTests.swift

@@ -15,13 +15,13 @@ class ByteReaderTests: XCTestCase {
 
         let byte = byteReader.byte()
         XCTAssertEqual(byte, 0)
-        XCTAssertFalse(byteReader.isAtTheEnd)
+        XCTAssertFalse(byteReader.isFinished)
     }
 
-    func testAtTheEnd() {
+    func testIsFinished() {
         let byteReader = ByteReader(data: ByteReaderTests.data)
         byteReader.offset = 9
-        XCTAssertTrue(byteReader.isAtTheEnd)
+        XCTAssertTrue(byteReader.isFinished)
     }
 
     func testBytes() {

Tests/BitByteDataTests/LsbBitReaderTests.swift

@@ -83,12 +83,12 @@ class LsbBitReaderTests: XCTestCase {
         var byte = bitReader.byte()
         XCTAssertEqual(byte, 0x5A)
         XCTAssertTrue(bitReader.isAligned)
-        XCTAssertFalse(bitReader.isAtTheEnd)
+        XCTAssertFalse(bitReader.isFinished)
 
         byte = bitReader.byte()
         XCTAssertEqual(byte, 0xD6)
         XCTAssertTrue(bitReader.isAligned)
-        XCTAssertTrue(bitReader.isAtTheEnd)
+        XCTAssertTrue(bitReader.isFinished)
     }
 
     func testBitReaderBytes() {
@@ -97,7 +97,7 @@ class LsbBitReaderTests: XCTestCase {
         let bytes = bitReader.bytes(count: 2)
         XCTAssertEqual(bytes, [0x5A, 0xD6])
         XCTAssertTrue(bitReader.isAligned)
-        XCTAssertTrue(bitReader.isAtTheEnd)
+        XCTAssertTrue(bitReader.isFinished)
     }
 
     func testBitReaderUint16() {
@@ -106,7 +106,7 @@ class LsbBitReaderTests: XCTestCase {
         let num = bitReader.uint16()
         XCTAssertEqual(num, 54874)
         XCTAssertTrue(bitReader.isAligned)
-        XCTAssertTrue(bitReader.isAtTheEnd)
+        XCTAssertTrue(bitReader.isFinished)
     }
 
 }

Tests/BitByteDataTests/MsbBitReaderTests.swift

@@ -83,12 +83,12 @@ class MsbBitReaderTests: XCTestCase {
         var byte = bitReader.byte()
         XCTAssertEqual(byte, 0x5A)
         XCTAssertTrue(bitReader.isAligned)
-        XCTAssertFalse(bitReader.isAtTheEnd)
+        XCTAssertFalse(bitReader.isFinished)
 
         byte = bitReader.byte()
         XCTAssertEqual(byte, 0xD6)
         XCTAssertTrue(bitReader.isAligned)
-        XCTAssertTrue(bitReader.isAtTheEnd)
+        XCTAssertTrue(bitReader.isFinished)
     }
 
     func testBitReaderBytes() {
@@ -97,7 +97,7 @@ class MsbBitReaderTests: XCTestCase {
         let bytes = bitReader.bytes(count: 2)
         XCTAssertEqual(bytes, [0x5A, 0xD6])
         XCTAssertTrue(bitReader.isAligned)
-        XCTAssertTrue(bitReader.isAtTheEnd)
+        XCTAssertTrue(bitReader.isFinished)
     }
 
     func testBitReaderUint16() {
@@ -106,7 +106,7 @@ class MsbBitReaderTests: XCTestCase {
         let num = bitReader.uint16()
         XCTAssertEqual(num, 54874)
         XCTAssertTrue(bitReader.isAligned)
-        XCTAssertTrue(bitReader.isAtTheEnd)
+        XCTAssertTrue(bitReader.isFinished)
     }
 
 }