Migrate (somewhat) to Swift 5.0

I am unable to perform automatic migration using Xcode 10.2, since my macbook doesn't support that version of Xcode, so I installed Swift 5.0 toolchain and performed all the steps manually.

Author: tsolomko

.swift-version

@@ -1 +1 @@
-4.2
+5.0

BitByteData.podspec

@@ -20,7 +20,7 @@ Pod::Spec.new do |s|
   s.tvos.deployment_target = "9.0"
   s.watchos.deployment_target = "2.0"
 
-  s.swift_version = "4.2"
+  s.swift_version = "5.0"
 
   s.source_files = "Sources/*.swift"
 

BitByteData.xcodeproj/project.pbxproj

@@ -334,7 +334,6 @@
 				);
 				PRODUCT_BUNDLE_IDENTIFIER = me.tsolomko.BitByteDataBenchmarks;
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				SWIFT_VERSION = 4.2;
 			};
 			name = Debug;
 		};
@@ -352,7 +351,6 @@
 				);
 				PRODUCT_BUNDLE_IDENTIFIER = me.tsolomko.BitByteDataBenchmarks;
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				SWIFT_VERSION = 4.2;
 			};
 			name = Release;
 		};
@@ -396,6 +394,7 @@
 				SDKROOT = macosx;
 				SUPPORTED_PLATFORMS = "macosx watchsimulator iphonesimulator appletvsimulator watchos appletvos iphoneos";
 				SWIFT_OPTIMIZATION_LEVEL = "-Onone";
+				SWIFT_VERSION = 5.0;
 				TVOS_DEPLOYMENT_TARGET = 9.0;
 				VERSIONING_SYSTEM = "apple-generic";
 				WATCHOS_DEPLOYMENT_TARGET = 2.0;
@@ -440,6 +439,7 @@
 				SDKROOT = macosx;
 				SUPPORTED_PLATFORMS = "macosx watchsimulator iphonesimulator appletvsimulator watchos appletvos iphoneos";
 				SWIFT_COMPILATION_MODE = wholemodule;
+				SWIFT_VERSION = 5.0;
 				TVOS_DEPLOYMENT_TARGET = 9.0;
 				VERSIONING_SYSTEM = "apple-generic";
 				WATCHOS_DEPLOYMENT_TARGET = 2.0;
@@ -466,7 +466,6 @@
 				PRODUCT_BUNDLE_IDENTIFIER = me.tsolomko.BitByteData;
 				PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
 				SKIP_INSTALL = YES;
-				SWIFT_VERSION = 4.2;
 				VERSION_INFO_PREFIX = "";
 			};
 			name = Debug;
@@ -491,7 +490,6 @@
 				PRODUCT_BUNDLE_IDENTIFIER = me.tsolomko.BitByteData;
 				PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
 				SKIP_INSTALL = YES;
-				SWIFT_VERSION = 4.2;
 				VERSION_INFO_PREFIX = "";
 			};
 			name = Release;
@@ -510,7 +508,6 @@
 				);
 				PRODUCT_BUNDLE_IDENTIFIER = me.tsolomko.TestBitByteData;
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				SWIFT_VERSION = 4.2;
 			};
 			name = Debug;
 		};
@@ -528,7 +525,6 @@
 				);
 				PRODUCT_BUNDLE_IDENTIFIER = me.tsolomko.TestBitByteData;
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				SWIFT_VERSION = 4.2;
 			};
 			name = Release;
 		};

Package.swift

@@ -1,4 +1,4 @@
-// swift-tools-version:4.0
+// swift-tools-version:5.0
 import PackageDescription
 
 let package = Package(
@@ -13,5 +13,5 @@ let package = Package(
         .testTarget(name: "BitByteDataTests", dependencies: ["BitByteData"]),
         .testTarget(name: "BitByteDataBenchmarks", dependencies: ["BitByteData"])
     ],
-    swiftLanguageVersions: [4]
+    swiftLanguageVersions: [.v5]
 )

benchmarks.py

@@ -198,7 +198,7 @@ def action_run(args):
     elif args.use_413:
         swift_command = ["xcrun", "-toolchain", "org.swift.41320180727a"]
     elif args.use_5:
-        swift_command = ["xcrun", "-toolchain", "org.swift.5020190310a"]
+        swift_command = ["xcrun", "-toolchain", "org.swift.5020190325a"]
     swift_command.append("swift")
     command = swift_command + ["test", "-c", "release", "--filter", args.filter]
     # macOS version of 'swift test' outputs to stderr instead of stdout.