implement integration tests for settings page

Author: tschortsch

cypress/index.d.ts

@@ -3,6 +3,7 @@
 declare namespace Cypress {
 	interface Chainable<Subject> {
 
+		getByCy(cyKey: string): Chainable<Element>;
 		postContentMatchesSnapshot(): Chainable<void>
 		insertRowBlock(): Chainable<void>
 		selectRowBlock( index?: number ): Chainable<void>

cypress/integration/settings/settings.spec.js

@@ -0,0 +1,41 @@
+/// <reference types="Cypress" />
+
+describe( 'Settings page', () => {
+	beforeEach( () => {
+		cy.loginUser();
+	} );
+
+	it( 'Default values should be selected', () => {
+		cy.visitAdminPage(
+			'options-general.php?page=wp-bootstrap-blocks_settings'
+		);
+
+		cy.get(
+			'#wp-bootstrap-blocks_bootstrap_version option:selected'
+		).should( 'have.value', '4' );
+
+		cy.get( '#wp-bootstrap-blocks_enable_css_grid' )
+			.should( 'not.be.checked' )
+			.and( 'be.disabled' );
+	} );
+
+	it( 'Should respect constants', () => {
+		cy.activatePlugin( 'wp-bootstrap-blocks-test-css-grid' );
+		cy.visitAdminPage(
+			'options-general.php?page=wp-bootstrap-blocks_settings'
+		);
+
+		cy.get( '#wp-bootstrap-blocks_bootstrap_version' ).should(
+			'be.disabled'
+		);
+		cy.get(
+			'#wp-bootstrap-blocks_bootstrap_version option:selected'
+		).should( 'have.value', '5' );
+
+		cy.get( '#wp-bootstrap-blocks_enable_css_grid' )
+			.should( 'be.checked' )
+			.and( 'be.disabled' );
+
+		cy.deactivatePlugin( 'wp-bootstrap-blocks-test-css-grid' );
+	} );
+} );

cypress/support/commands/get-by-cy.js

@@ -0,0 +1,3 @@
+Cypress.Commands.add( 'getByCy', ( cyKey ) =>
+	cy.get( `[data-cy="${ cyKey }"]` )
+);

cypress/support/commands/index.js

@@ -1,3 +1,4 @@
+import './get-by-cy';
 import './insert-row-block';
 import './select-row-block';
 import './row-template-is-selected';

readme.txt

@@ -148,6 +148,7 @@ Please create a new GitHub issue and let us know: [https://github.com/liip/boots
 * [FEATURE] Reflect noGutters and horizontalGutters options visually in editor  (WordPress >= 5.4).
 * [FIX] Add missing "Medium" size to vertical gutter options.
 * [FIX] Fix label of default css grid gutter option ("Medium" instead of "None").
+* [FIX] Allow enabling CSS grid option only if Bootstrap version is >= 5.
 
 = 4.1.0 =
 

src/settings/class-settings.php

@@ -266,7 +266,7 @@ public static function settings_page() {
 			<div class="wrap" id="<?php echo esc_attr( self::MENU_SLUG ); ?>">
 				<h1><?php esc_html_e( 'Bootstrap Blocks Settings', 'wp-bootstrap-blocks' ); ?></h1>
 
-				<form method="post" action="options.php" enctype="multipart/form-data" data-cy="wp-bootstrap-blocks-settings-form">
+				<form method="post" action="options.php" enctype="multipart/form-data">
 					<?php
 					// Get settings fields
 					settings_fields( self::MENU_SLUG );