Skip to content

Commit bd152be

Browse files
committed
ci: don't block releases on attestation step + grant scope on release path
- release.yml's publish-docker job now grants attestations:write so the reusable-workflow chain (release.yml -> publish.yml -> publish-webapp.yml) carries the scope all the way to actions/attest-build-provenance. - continue-on-error on the attestation step itself: image is already pushed by the time this runs, so a Sigstore outage or GHCR referrer hiccup shouldn't fail the workflow and block the downstream publish-helm job. Real config errors still surface as a step warning.
1 parent 93eb75c commit bd152be

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

.github/workflows/publish-webapp.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,10 @@ jobs:
115115
sentry_auth_token=${{ secrets.SENTRY_AUTH_TOKEN }}
116116
117117
- name: 🪪 Attest build provenance
118+
# Image is already pushed by this point — don't fail releases (and the
119+
# downstream publish-helm job) on a Sigstore/GHCR-referrer hiccup. Real
120+
# config errors still surface as a step warning in the workflow run.
121+
continue-on-error: true
118122
uses: actions/attest-build-provenance@a2bbfa25375fe432b6a289bc6b6cd05ecd0c4c32 # v4.1.0
119123
with:
120124
subject-name: ghcr.io/triggerdotdev/trigger.dev

.github/workflows/release.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@ jobs:
169169
contents: read
170170
packages: write
171171
id-token: write
172+
attestations: write
172173
uses: ./.github/workflows/publish.yml
173174
secrets:
174175
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}

0 commit comments

Comments
 (0)