Merge #1007: Remove default configuration values for secrets

6a707b9 fix: linter errors (Jose Celano)
f5e38bb feat!: [#1006] remove config  deafults for secrets (Jose Celano)

Pull request description:

  Remove default configuration values for secrets. To avoid running the tracker unintentionally with known values.

ACKs for top commit:
  josecelano:
    ACK 6a707b9

Tree-SHA512: 4360ad36f97afcc21307d2f945ca73dc40ef08a96406c40ac4b9e856756e1b3ca0464b99e34b6843013bfb393d46ede618d49c000fdb386829a450b61d6e44f0

Author: josecelano

packages/configuration/src/v2_0_0/tracker_api.rs

@@ -52,14 +52,11 @@ impl HttpApi {
     }
 
     fn default_access_tokens() -> AccessTokens {
-        [(String::from("admin"), String::from("MyAccessToken"))]
-            .iter()
-            .cloned()
-            .collect()
+        [].iter().cloned().collect()
     }
 
-    pub fn override_admin_token(&mut self, api_admin_token: &str) {
-        self.access_tokens.insert("admin".to_string(), api_admin_token.to_string());
+    pub fn add_token(&mut self, key: &str, token: &str) {
+        self.access_tokens.insert(key.to_string(), token.to_string());
     }
 
     pub fn mask_secrets(&mut self) {
@@ -74,10 +71,18 @@ mod tests {
     use crate::v2_0_0::tracker_api::HttpApi;
 
     #[test]
-    fn http_api_configuration_should_check_if_it_contains_a_token() {
+    fn default_http_api_configuration_should_not_contains_any_token() {
         let configuration = HttpApi::default();
 
+        assert_eq!(configuration.access_tokens.values().len(), 0);
+    }
+
+    #[test]
+    fn http_api_configuration_should_allow_adding_tokens() {
+        let mut configuration = HttpApi::default();
+
+        configuration.add_token("admin", "MyAccessToken");
+
         assert!(configuration.access_tokens.values().any(|t| t == "MyAccessToken"));
-        assert!(!configuration.access_tokens.values().any(|t| t == "NonExistingToken"));
     }
 }

packages/test-helpers/src/configuration.rs

@@ -32,10 +32,12 @@ pub fn ephemeral() -> Configuration {
 
     // Ephemeral socket address for API
     let api_port = 0u16;
-    config.http_api = Some(HttpApi {
+    let mut http_api = HttpApi {
         bind_address: SocketAddr::new(IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1)), api_port),
         ..Default::default()
-    });
+    };
+    http_api.add_token("admin", "MyAccessToken");
+    config.http_api = Some(http_api);
 
     // Ephemeral socket address for Health Check API
     let health_check_api_port = 0u16;

src/app.rs

@@ -66,56 +66,53 @@ pub async fn start(config: &Configuration, tracker: Arc<core::Tracker>) -> Vec<J
     }
 
     // Start the UDP blocks
-    match &config.udp_trackers {
-        Some(udp_trackers) => {
-            for udp_tracker_config in udp_trackers {
-                if tracker.is_private() {
-                    warn!(
-                        "Could not start UDP tracker on: {} while in private mode. UDP is not safe for private trackers!",
-                        udp_tracker_config.bind_address
-                    );
-                } else {
-                    jobs.push(udp_tracker::start_job(udp_tracker_config, tracker.clone(), registar.give_form()).await);
-                }
+    if let Some(udp_trackers) = &config.udp_trackers {
+        for udp_tracker_config in udp_trackers {
+            if tracker.is_private() {
+                warn!(
+                    "Could not start UDP tracker on: {} while in private mode. UDP is not safe for private trackers!",
+                    udp_tracker_config.bind_address
+                );
+            } else {
+                jobs.push(udp_tracker::start_job(udp_tracker_config, tracker.clone(), registar.give_form()).await);
             }
         }
-        None => info!("No UDP blocks in configuration"),
+    } else {
+        info!("No UDP blocks in configuration");
     }
 
     // Start the HTTP blocks
-    match &config.http_trackers {
-        Some(http_trackers) => {
-            for http_tracker_config in http_trackers {
-                if let Some(job) = http_tracker::start_job(
-                    http_tracker_config,
-                    tracker.clone(),
-                    registar.give_form(),
-                    servers::http::Version::V1,
-                )
-                .await
-                {
-                    jobs.push(job);
-                };
-            }
-        }
-        None => info!("No HTTP blocks in configuration"),
-    }
-
-    // Start HTTP API
-    match &config.http_api {
-        Some(http_api_config) => {
-            if let Some(job) = tracker_apis::start_job(
-                http_api_config,
+    if let Some(http_trackers) = &config.http_trackers {
+        for http_tracker_config in http_trackers {
+            if let Some(job) = http_tracker::start_job(
+                http_tracker_config,
                 tracker.clone(),
                 registar.give_form(),
-                servers::apis::Version::V1,
+                servers::http::Version::V1,
             )
             .await
             {
                 jobs.push(job);
             };
         }
-        None => info!("No API block in configuration"),
+    } else {
+        info!("No HTTP blocks in configuration");
+    }
+
+    // Start HTTP API
+    if let Some(http_api_config) = &config.http_api {
+        if let Some(job) = tracker_apis::start_job(
+            http_api_config,
+            tracker.clone(),
+            registar.give_form(),
+            servers::apis::Version::V1,
+        )
+        .await
+        {
+            jobs.push(job);
+        };
+    } else {
+        info!("No API block in configuration");
     }
 
     // Start runners to remove torrents without peers, every interval

src/console/ci/e2e/tracker_container.rs

@@ -105,14 +105,11 @@ impl TrackerContainer {
     ///
     /// Will panic if it can't remove the container.
     pub fn remove(&self) {
-        match &self.running {
-            Some(_running_container) => {
-                error!("Can't remove running container: {} ...", self.name);
-            }
-            None => {
-                info!("Removing docker tracker container: {} ...", self.name);
-                Docker::remove(&self.name).expect("Container should be removed");
-            }
+        if let Some(_running_container) = &self.running {
+            error!("Can't remove running container: {} ...", self.name);
+        } else {
+            info!("Removing docker tracker container: {} ...", self.name);
+            Docker::remove(&self.name).expect("Container should be removed");
         }
     }