fix(lint/clippy): resolve pedantic duration and style violations

Author: josecelano

packages/axum-rest-tracker-api-server/src/server.rs

@@ -220,9 +220,9 @@ pub struct Launcher {
 impl std::fmt::Display for Launcher {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         if self.tls.is_some() {
-            write!(f, "(with socket): {}, using TLS", self.bind_to,)
+            write!(f, "(with socket): {}, using TLS", self.bind_to)
         } else {
-            write!(f, "(with socket): {}, without TLS", self.bind_to,)
+            write!(f, "(with socket): {}, without TLS", self.bind_to)
         }
     }
 }

packages/http-tracker-core/benches/http_tracker_core_benchmark.rs

@@ -12,7 +12,7 @@ fn announce_once(c: &mut Criterion) {
     let mut group = c.benchmark_group("http_tracker_handle_announce_once");
 
     group.warm_up_time(Duration::from_millis(500));
-    group.measurement_time(Duration::from_millis(1000));
+    group.measurement_time(Duration::from_secs(1));
 
     group.bench_function("handle_announce_data", |b| {
         b.iter(|| sync::return_announce_data_once(100));

packages/torrent-repository-benchmarking/benches/repository_benchmark.rs

@@ -17,7 +17,7 @@ fn add_one_torrent(c: &mut Criterion) {
     let mut group = c.benchmark_group("add_one_torrent");
 
     group.warm_up_time(Duration::from_millis(500));
-    group.measurement_time(Duration::from_millis(1000));
+    group.measurement_time(Duration::from_secs(1));
 
     group.bench_function("RwLockStd", |b| {
         b.iter_custom(sync::add_one_torrent::<TorrentsRwLockStd, _>);
@@ -74,7 +74,7 @@ fn add_multiple_torrents_in_parallel(c: &mut Criterion) {
     //group.sample_size(10);
 
     group.warm_up_time(Duration::from_millis(500));
-    group.measurement_time(Duration::from_millis(1000));
+    group.measurement_time(Duration::from_secs(1));
 
     group.bench_function("RwLockStd", |b| {
         b.to_async(&rt)
@@ -138,7 +138,7 @@ fn update_one_torrent_in_parallel(c: &mut Criterion) {
     //group.sample_size(10);
 
     group.warm_up_time(Duration::from_millis(500));
-    group.measurement_time(Duration::from_millis(1000));
+    group.measurement_time(Duration::from_secs(1));
 
     group.bench_function("RwLockStd", |b| {
         b.to_async(&rt)
@@ -202,7 +202,7 @@ fn update_multiple_torrents_in_parallel(c: &mut Criterion) {
     //group.sample_size(10);
 
     group.warm_up_time(Duration::from_millis(500));
-    group.measurement_time(Duration::from_millis(1000));
+    group.measurement_time(Duration::from_secs(1));
 
     group.bench_function("RwLockStd", |b| {
         b.to_async(&rt)

packages/torrent-repository-benchmarking/tests/entry/mod.rs

@@ -1,5 +1,4 @@
 use std::net::{IpAddr, Ipv4Addr, SocketAddr};
-use std::ops::Sub;
 use std::time::Duration;
 
 use aquatic_udp_protocol::{AnnounceEvent, NumberOfBytes};
@@ -430,7 +429,9 @@ async fn it_should_remove_inactive_peers_beyond_cutoff(
     let now = clock::Working::now();
     clock::Stopped::local_set(&now);
 
-    peer.updated = now.sub(EXPIRE);
+    peer.updated = now
+        .checked_sub(EXPIRE)
+        .expect("it_should_remove_inactive_peers_beyond_cutoff: EXPIRE must not exceed now");
 
     torrent.upsert_peer(&peer).await;
 

packages/torrent-repository-benchmarking/tests/repository/mod.rs

@@ -526,7 +526,6 @@ async fn it_should_remove_inactive_peers(
     repo: Repo,
     #[case] entries: Entries,
 ) {
-    use std::ops::Sub as _;
     use std::time::Duration;
 
     use torrust_tracker_clock::clock::stopped::Stopped as _;
@@ -556,7 +555,9 @@ async fn it_should_remove_inactive_peers(
         let now = clock::Working::now();
         clock::Stopped::local_set(&now);
 
-        peer.updated = now.sub(EXPIRE);
+        peer.updated = now
+            .checked_sub(EXPIRE)
+            .expect("it_should_remove_inactive_peers_beyond_cutoff: EXPIRE must not exceed now");
     }
 
     // Insert the infohash and peer into the repository

packages/tracker-client/src/udp/client.rs

@@ -256,7 +256,7 @@ pub async fn check(service_binding: &ServiceBinding) -> Result<String, String> {
                 }
             };
 
-            let sleep = time::sleep(Duration::from_millis(2000));
+            let sleep = time::sleep(Duration::from_secs(2));
             tokio::pin!(sleep);
 
             tokio::select! {

packages/udp-tracker-core/benches/udp_tracker_core_benchmark.rs

@@ -9,7 +9,7 @@ use crate::helpers::sync;
 fn bench_connect_once(c: &mut Criterion) {
     let mut group = c.benchmark_group("udp_tracker/connect_once");
     group.warm_up_time(Duration::from_millis(500));
-    group.measurement_time(Duration::from_millis(1000));
+    group.measurement_time(Duration::from_secs(1));
 
     group.bench_function("connect_once", |b| {
         b.iter(|| sync::connect_once(100));

packages/udp-tracker-server/src/server/launcher.rs

@@ -54,7 +54,7 @@ impl Launcher {
             panic!("it should not use udp if using authentication");
         }
 
-        let socket = tokio::time::timeout(Duration::from_millis(5000), BoundSocket::new(bind_to))
+        let socket = tokio::time::timeout(Duration::from_secs(5), BoundSocket::new(bind_to))
             .await
             .expect("it should bind to the socket within five seconds");
 

packages/udp-tracker-server/src/statistics/repository.rs

@@ -330,7 +330,7 @@ mod tests {
 
         // Calculate new average with processing time of 2000ns
         // This will increment the processed requests counter from 0 to 1
-        let processing_time = Duration::from_nanos(2000);
+        let processing_time = Duration::from_micros(2);
         let new_avg = repo
             .recalculate_udp_avg_processing_time_ns(processing_time, &connect_labels, now)
             .await;
@@ -417,7 +417,7 @@ mod tests {
         let now = CurrentClock::now();
 
         // Test with zero connections (should not panic, should handle division by zero)
-        let processing_time = Duration::from_nanos(1000);
+        let processing_time = Duration::from_micros(1);
 
         let connect_labels = LabelSet::from([("request_kind", "connect")]);
         let connect_avg = repo

packages/udp-tracker-server/tests/server/contract.rs

@@ -32,7 +32,7 @@ async fn send_connection_request(transaction_id: TransactionId, client: &UdpTrac
 
     match response {
         Response::Connect(connect_response) => connect_response.connection_id,
-        _ => panic!("error connecting to udp server {:?}", response),
+        _ => panic!("error connecting to udp server {response:?}"),
     }
 }